Bug 152869 - [maintainer] [patch] shells/scponly Fix rsync support for 3.0
Summary: [maintainer] [patch] shells/scponly Fix rsync support for 3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Olli Hauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 20:20 UTC by Robert Farmer
Modified: 2010-12-08 14:51 UTC (History)
0 users

See Also:


Attachments
file.diff (5.66 KB, patch)
2010-12-06 20:20 UTC, Robert Farmer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Farmer 2010-12-06 20:20:07 UTC
Rsync 3 needs the "-e" option, which is blocked by scponly:

Dec  6 12:03:13 cheese scponly[34130]: option 'e' or a related long option is not permitted for use with /usr/local/bin/rsync (arg was .iLsf) (username: newuser(11062), IP/port: XXX 24404 22))
Dec  6 12:03:13 cheese scponly[34130]: requested command (/usr/local/bin/rsync --server -vvlogDtpre.iLsf . /tmp/sl) tried to use disallowed argument (username: newuser(11062), IP/port: XXX 24404 22))

Patch pulled from upstream CVS, which states a full release will come soon:
http://lists.ccs.neu.edu/pipermail/scponly/2010-November/002170.html

Dropped MD5 distinfo while here.

Reported by: Frank Bartels

Fix: Patch attached with submission follows:
Comment 1 Olli Hauer freebsd_committer freebsd_triage 2010-12-07 21:27:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ohauer

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-12-07 21:46:56 UTC
ohauer      2010-12-07 21:46:51 UTC

  FreeBSD ports repository

  Modified files:
    shells/scponly       Makefile distinfo 
    shells/scponly/files patch-helper.c 
  Added files:
    shells/scponly/files patch-scponly.c 
  Log:
   - Fix support for rsync 3.0
  
   Rsync 3 needs the "-e" option, which is blocked without this patch by scponly
  
   Patch pulled from upstream CVS, which states a full release will come soon:
   http://lists.ccs.neu.edu/pipermail/scponly/2010-November/002170.html
  
   Reported by: Frank Bartels
  
  PR:             152869
  Submitted by:   Rob Farmer <rfarmer _at_ predatorlabs.net> (maintainer)
  
  Revision  Changes    Path
  1.35      +1 -2      ports/shells/scponly/Makefile
  1.16      +0 -1      ports/shells/scponly/distinfo
  1.4       +84 -4     ports/shells/scponly/files/patch-helper.c
  1.1       +38 -0     ports/shells/scponly/files/patch-scponly.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2010-12-07 21:49:09 UTC
State Changed
From-To: open->closed

Committed, 
Thanks. 

Maybe you can report the scponly developpers a cosmetic fix: 
In scponly.c after the patch. 

96     /* I use 'e' for val here because that's what's listed in cmd_arg_t->badarg  */ 
97     {"rsh",             1,  0,      (int)'r'}, 
98     /* the following are disabled because they use daemon mode */ 

The "I use 'e' is no longer valid!
Comment 4 Robert Farmer 2010-12-07 22:23:13 UTC
I sent them an email about the bad comment.

Thanks,
-- 
Rob Farmer