New port: games/instead INSTEAD was designed to interpret the games that are the mix of visual novels, text quests and classical 90'ss quests.
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
* Fluke (neuroworker@gmail.com) wrote: > XBUILD_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config \ You should add pkgconfig to USE_GNOME instead > XGNU_CONFIGURE= yes That's not GNU configure. Should use HAS_CONFIGURE instead. > X > X > XPort by: > X-enthru Fluke That's not needed in pkg-descr. > Xshare/applications/instead.desktop @dirrmtry share/applications missing > Xshare/doc/instead/index.html > Xshare/doc/instead/instead.txt > Xshare/doc/instead/manual.pdf > Xshare/doc/instead/writing_games-en.html > Xshare/doc/instead/writing_games-en.txt > Xshare/doc/instead/writing_games.html > Xshare/doc/instead/writing_games.txt It would be nice to make doc installation optional (dependent on NOPORTDOCS) and either use e.g. %%PORTDOCS%%%%DOCSDIR%%... or use PORTDOCS=* in the Makefile. > Xshare/instead/games/tutorial2-en/main.lua %%DATADIR%% should be used instead of share/instead > Xman/man6/instead.6.gz That should not be in the plist. Use MAN6=instead.6 in the Makefile insetad > X*** ./configure.sh.orig Tue Oct 12 19:06:42 2010 > X--- ./configure.sh Mon Dec 20 22:17:44 2010 > X*************** > X*** 1,6 **** > X! #!/bin/bash > X echo -n "Checking pkg-config..." > X if ! pkg-config --version >/dev/null 2>&1; then > X echo "error: no pkg-config in \$PATH." > X exit 1 > X fi > X--- 1,6 ---- > X! #!/usr/local/bin/bash > X echo -n "Checking pkg-config..." > X if ! pkg-config --version >/dev/null 2>&1; then > X echo "error: no pkg-config in \$PATH." > X exit 1 > X fi > X*************** > X*** 34,56 **** > X gtk_libs="pkg-config --libs gtk+-2.0" > X fi Please use unified diff format (diff -u) for patches. Also this configure script hardcodes /usr/local at least in shebang and here: > X! prefix="/usr/local" while values if ${LOCALBASE} and ${PREFIX} correspondingly should be used instead. You may pass these via CONFIGURE_ENV or replace with ${REINPLACE_CMD} in post-patch target. Also, the porting of configure script to sh seems to be trivial (at the first glance, only [[ ]] -> [ ] is needed), so you can do it and drop bash dependency. It's also nice to submit such changes upstream. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Ask for submitter fix.
amdmi3 2010-12-27 12:15:19 UTC FreeBSD ports repository Modified files: games Makefile Added files: games/instead Makefile distinfo pkg-descr pkg-plist games/instead/files patch-configure patch-makefile_games patch-makefile_themes Log: INSTEAD was designed to interpret the games that are the mix of visual novels, text quests and classical 90'ss quests. WWW: http://instead.google.com/ PR: 153343, 153411 Submitted by: Fluke <neuroworker@gmail.com> Revision Changes Path 1.1361 +1 -0 ports/games/Makefile 1.1 +36 -0 ports/games/instead/Makefile (new) 1.1 +2 -0 ports/games/instead/distinfo (new) 1.1 +108 -0 ports/games/instead/files/patch-configure (new) 1.1 +11 -0 ports/games/instead/files/patch-makefile_games (new) 1.1 +11 -0 ports/games/instead/files/patch-makefile_themes (new) 1.1 +4 -0 ports/games/instead/pkg-descr (new) 1.1 +90 -0 ports/games/instead/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed New port added, with minor changes. Thanks!