Bug 157917 - [PATCH] sysutils/pmap: multiple build problems
Summary: [PATCH] sysutils/pmap: multiple build problems
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 06:30 UTC by Dmitry Marakasov
Modified: 2011-12-01 23:05 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2011-06-16 06:30:10 UTC
On 7.x, plist is incomplete:

---
==>  Installing for pmap-20060622_1
===>   Generating temporary packing list
===>  Checking if sysutils/pmap already installed
===> pmap (install)
install -s -o root -g wheel -m 555   pmap /usr/local/bin
install -o root -g wheel -m 444 pmap.8.gz  /usr/local/man/man8
===> pmap_helper (install)
install -o root -g wheel -m 555   pmap_helper.ko /boot/modules
kldxref /boot/modules
===> dump_vmspace (install)
install -s -o root -g wheel -m 555   dump_vmspace /usr/local/bin

*******************************************************************************
* This port contains a prebuilt kernel module. Due to the ever changing       *
* nature of FreeBSD it may be necessary to rebuild the module after a kernel  *
* source update.  To do this reinstall the port.                              *
*******************************************************************************
===>   Registering installation for pmap-20060622_1
================================================================
====================<phase 7: make package>====================
===>  Building package for pmap-20060622_1
tar: Removing leading '/' from member names
Deleting pmap-20060622_1
================================================================

=== Checking filesystem state
list of extra files and directories in / (not present before this port was installed but present after it was deinstalled)
170282        4 -rw-r--r--    1 root             wheel                  40 Jun 16 04:24 boot/modules/linker.hints

=== Checking filesystem state after all packages deleted
================================================================
list of extra files and directories in / (not present on clean system but present after everything was deinstalled)
170282        4 -rw-r--r--    1 root             wheel                  40 Jun 16 04:24 boot/modules/linker.hints
================================================================
build of /usr/ports/sysutils/pmap ended at Thu Jun 16 04:24:01 UTC 2011
---

On 8.x, doesn't build at all:

---
cc -O2 -pipe -fno-strict-aliasing -g -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/work/a/ports/sysutils/pmap/work/pmap/pmap_helper -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c pmap_helper.c
pmap_helper.c: In function 'pmap_helper':
pmap_helper.c:152: error: too few arguments to function 'dev_refthread'
pmap_helper.c:154: error: too few arguments to function 'dev_relthread'
---

Port maintainer (skv@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-16 06:30:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->skv

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 eric 2011-07-29 18:29:51 UTC
Hello,

I've encountered the same build error using FreeBSD 9.0-BETA1 r224472 
GENERIC  amd64 (cf pr 157917 about 8.x) :

pmap_helper.c:152:37: error: too few arguments to function call, expected 2,
       have 1
                                 csw = dev_refthread(lobj->handle);
                                       ~~~~~~~~~~~~~             ^
pmap_helper.c:154:31: error: too few arguments to function call, expected 2,
       have 1
                                 dev_relthread(lobj->handle);
                                 ~~~~~~~~~~~~~             ^



I guess it's due to 
http://lists.freebsd.org/pipermail/svn-src-stable-8/2010-September/003310.html

I wrote this patch and could compile pmap :

diff pmap_helper.c.old pmap_helper.c
111c111
< 		int resident;
---
 > 		int resident,ref;
152c152
< 				csw = dev_refthread(lobj->handle);
---
 > 				csw = dev_refthread(lobj->handle, &ref);
154c154
< 				dev_relthread(lobj->handle);
---
 > 				dev_relthread(lobj->handle, ref);


Then i had trouble using pmap (complaining about pmap_helper). Exact 
error messages and a patch can be found at 
http://troysunix.blogspot.com/2011/07/process-memory-usage.html

Once both patch were applied, pmap started working fine, but I guess all 
of this might be tested a bit further.

Best Regards
Eric DANNIELOU
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-12-01 22:42:27 UTC
obrien      2011-12-01 22:42:14 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/pmap/files  patch-pmap_helper.c 
  Log:
  Catch up with 9.0's r210923 [2010-08-06] and 8.2's MFC r212229
  (new make_dev_p(9) flag MAKEDEV_ETERNAL).
  
  PR:             157917
  Feature safe:   yes
  
  Revision  Changes    Path
  1.2       +28 -7     ports/sysutils/pmap/files/patch-pmap_helper.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 David E. O'Brien freebsd_committer freebsd_triage 2011-12-01 23:05:15 UTC
State Changed
From-To: open->closed

Committed a fix. 


Comment 5 David E. O'Brien freebsd_committer freebsd_triage 2011-12-01 23:05:15 UTC
Responsible Changed
From-To: skv->obrien

Committed a fix.