The current version of the emulators/wine port can find alsa and gstreamer if they are installed, winealsa.drv and winegstreamer.dll will be created then, and they are missing in the pkg-plist file. To fix it, --without-alsa and --without-gstreamer can be used, but I made options instead. An option for mpg123 was added, too. Fix: This is a cumulative patch with the following fixes: * add options ALSA, MPG123, GSTREAMER * USE_LDCONFIG32 was used inappropriately (portlint was angry, and nobody uses this variable that way) * move the LICENSE block higher (portlint was angry) * remove unneeded dirrmtry's * use PORTDOCS and PORTDATA (make pkg-plist smaller) The maintainer is free to apply any subset of them. The separate patches will be attached to this pr, can also be found here: https://gist.github.com/1144321 Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->gerald Over to maintainer (via the GNATS Auto Assign Tool)
The separate patches. -- Mit freundlichen GrüÃen, Anatoly Borodin
gerald 2011-08-15 23:51:57 UTC FreeBSD ports repository Modified files: emulators/wine Makefile pkg-plist Log: Move LICENSE, LICENSE_COMB and LICENSE_FILE up to appease new portlint. [1] Use PORTDATA which allows simplifying pkg-plist significantly. [1][2] Explicitly disable ALSA support. [2] Add to PLIST_SUB instead of just setting it (for the OPENAL knob). [1] Bump PORTREVISION due to the potentially fixed package list. PR: 159749 Submitted by: Anatoly Borodin <anatoly.borodin@gmail.com> [1] Inspired by: Anatoly Borodin <anatoly.borodin@gmail.com> [2] Revision Changes Path 1.380 +13 -9 ports/emulators/wine/Makefile 1.199 +0 -50 ports/emulators/wine/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->feedback Thanks for your patches and pointing out several areas for improvement of this port, Anatoly! I have addressed nearly all of these, with a few twists like listing the PORTDATA entries a bit more explicitly than just via wildcard to be able to spot material changes and disabling ALSA unconditionally. The one open question I have is around gstreamer. How important do you consider this based on your own personal use (I have not received any other request whatsoever so far), and do we really need an option for that or could we simply disable it?
Hi! On Tue, Aug 16, 2011 at 01:55, <gerald@freebsd.org> wrote: > I have addressed nearly all of these, with a few twists like listing > the PORTDATA entries a bit more explicitly than just via wildcard to > be able to spot material changes and disabling ALSA unconditionally. Ok. > The one open question I have is around gstreamer. =C2=A0How important do > you consider this based on your own personal use (I have not received > any other request whatsoever so far), and do we really need an option > for that or could we simply disable it? My only concern was that there are no dangling files :) I'm in the middle of some bigger task, to find all the installed files not listed in the ports. You can disable them altogether - you are the maintainer. I'll have my patches locally anyway and will notify you if I will find something interesting. -- Mit freundlichen Gr=C3=BC=C3=9Fen, Anatoly Borodin
On Tue, 16 Aug 2011, Anatoly Borodin wrote: >> The one open question I have is around gstreamer. Â How important do >> you consider this based on your own personal use (I have not received >> any other request whatsoever so far), and do we really need an option >> for that or could we simply disable it? > My only concern was that there are no dangling files :) I'm in the > middle of some bigger task, to find all the installed files not listed > in the ports. > > You can disable them altogether - you are the maintainer. I'll have my > patches locally anyway and will notify you if I will find something > interesting. Okay, thanks! If there is a usecase that makes a knob around gstreamer interesting for a larger group of users, please advise, and I'll be happy to add one at that point. For know, I'll be disabling this, either with the new version update of the port or before (depending on when it happens). Cheers, Gerald
gerald 2011-08-27 20:56:47 UTC FreeBSD ports repository Modified files: emulators/wine Makefile distinfo pkg-plist Log: Update to Wine 1.3.26. This includes the following changes: - Support for multisampling in Direct3D. - New version of the Gecko engine. - Improvements to the network proxy handling. - Better write support in MSXML. - Side-by-side manifests for built-in libraries. - Various bug fixes. Explicitly disable gstreamer support, thus avoiding automatic detection and incorrect package lists in case. [1] PR: 159749 [1] Submitted by: Anatoly Borodin <anatoly.borodin@gmail.com> [1] Revision Changes Path 1.381 +3 -4 ports/emulators/wine/Makefile 1.236 +2 -2 ports/emulators/wine/distinfo 1.200 +2 -0 ports/emulators/wine/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed I believe I have now addressed all suggestions/fixes described here (except the part that is used to support the 64-bit flavor of this port). If I missed anything, or you have further suggestions, please advise! And thanks for taking the time to report all these!