Bug 159904 - [patch] type specifier error /sys/kern/sched_4bsd.c
Summary: [patch] type specifier error /sys/kern/sched_4bsd.c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 9.0-BETA1
Hardware: Any Any
: Normal Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 11:20 UTC by Ivan Klymenko
Modified: 2011-09-09 02:40 UTC (History)
0 users

See Also:

Attachments
file.diff (622 bytes, patch)
2011-08-19 11:20 UTC, Ivan Klymenko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Klymenko 2011-08-19 11:20:09 UTC 

Fix: Patch attached with submission follows:
Comment 1 Xin LI freebsd_committer freebsd_triage 2011-08-25 23:49:23 UTC 
Responsible Changed
From-To: freebsd-bugs->delphij

Take.
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-08-26 19:00:27 UTC 
Author: delphij
Date: Fri Aug 26 18:00:07 2011
New Revision: 225199
URL: http://svn.freebsd.org/changeset/base/225199

Log:
  Fix format strings for KTR_STATE in 4BSD ad ULE schedulers.
  
  Submitted by:	Ivan Klymenko <fidaj@ukr.net>
  PR:		kern/159904, kern/159905
  MFC after:	2 weeks
  Approved by:	re (kib)

Modified:
  head/sys/kern/sched_4bsd.c
  head/sys/kern/sched_ule.c

Modified: head/sys/kern/sched_4bsd.c
==============================================================================
--- head/sys/kern/sched_4bsd.c	Fri Aug 26 17:45:56 2011	(r225198)
+++ head/sys/kern/sched_4bsd.c	Fri Aug 26 18:00:07 2011	(r225199)
@@ -720,7 +720,7 @@ sched_exit(struct proc *p, struct thread
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(td), "proc exit",
-	    "prio:td", td->td_priority);
+	    "prio:%d", td->td_priority);
 
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 	sched_exit_thread(FIRST_THREAD_IN_PROC(p), td);
@@ -731,7 +731,7 @@ sched_exit_thread(struct thread *td, str
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	thread_lock(td);
 	td->td_estcpu = ESTCPULIM(td->td_estcpu + child->td_estcpu);
 	thread_unlock(td);

Modified: head/sys/kern/sched_ule.c
==============================================================================
--- head/sys/kern/sched_ule.c	Fri Aug 26 17:45:56 2011	(r225198)
+++ head/sys/kern/sched_ule.c	Fri Aug 26 18:00:07 2011	(r225199)
@@ -2022,7 +2022,7 @@ sched_exit(struct proc *p, struct thread
 	struct thread *td;
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "proc exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 	td = FIRST_THREAD_IN_PROC(p);
 	sched_exit_thread(td, child);
@@ -2039,7 +2039,7 @@ sched_exit_thread(struct thread *td, str
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "thread exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	/*
 	 * Give the child's runtime to the parent without returning the
 	 * sleep time as a penalty to the parent.  This causes shells that
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Xin LI freebsd_committer freebsd_triage 2011-08-26 19:00:28 UTC 
State Changed
From-To: open->patched

Patch applied against -HEAD, MFC reminder.
Comment 4 Xin LI freebsd_committer freebsd_triage 2011-09-09 02:38:15 UTC 
State Changed
From-To: patched->closed

MFC'ed to RELENG_8, thanks for your submission!
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-09-09 02:39:28 UTC 
Author: delphij
Date: Fri Sep  9 01:39:19 2011
New Revision: 225454
URL: http://svn.freebsd.org/changeset/base/225454

Log:
  MFC r225199:
  
  Fix format strings for KTR_STATE in 4BSD ad ULE schedulers.
  
  Submitted by:	Ivan Klymenko <fidaj@ukr.net>
  PR:		kern/159904, kern/159905

Modified:
  stable/8/sys/kern/sched_4bsd.c
  stable/8/sys/kern/sched_ule.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/kern/sched_4bsd.c
==============================================================================
--- stable/8/sys/kern/sched_4bsd.c	Thu Sep  8 23:59:16 2011	(r225453)
+++ stable/8/sys/kern/sched_4bsd.c	Fri Sep  9 01:39:19 2011	(r225454)
@@ -717,7 +717,7 @@ sched_exit(struct proc *p, struct thread
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(td), "proc exit",
-	    "prio:td", td->td_priority);
+	    "prio:%d", td->td_priority);
 
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 	sched_exit_thread(FIRST_THREAD_IN_PROC(p), td);
@@ -728,7 +728,7 @@ sched_exit_thread(struct thread *td, str
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	thread_lock(td);
 	td->td_estcpu = ESTCPULIM(td->td_estcpu + child->td_estcpu);
 	thread_unlock(td);

Modified: stable/8/sys/kern/sched_ule.c
==============================================================================
--- stable/8/sys/kern/sched_ule.c	Thu Sep  8 23:59:16 2011	(r225453)
+++ stable/8/sys/kern/sched_ule.c	Fri Sep  9 01:39:19 2011	(r225454)
@@ -2032,7 +2032,7 @@ sched_exit(struct proc *p, struct thread
 	struct thread *td;
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "proc exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 	td = FIRST_THREAD_IN_PROC(p);
 	sched_exit_thread(td, child);
@@ -2049,7 +2049,7 @@ sched_exit_thread(struct thread *td, str
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "thread exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	/*
 	 * Give the child's runtime to the parent without returning the
 	 * sleep time as a penalty to the parent.  This causes shells that
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"