rplayd (part of the audio/rplay port) crashes when parsing the rplay.hosts file. Investigation shows some references to undeclared libc functions which cause implicit return value of int. In addition, a number of standard library functions are reimplemented within rplay, and it includes its own regex library. In attempting to solve the declaration issues and including appropriate headers, I decided it would be better to excise the redundant functions and switch to the standard regex library. The attached patch implements these changes. I saved it as patch-ao in the port's files subdir and it applies and builds (more) cleanly. Fix: See attached patch. Patch attached with submission follows: How-To-Repeat: Try to start rplayd. Observe core file.
Callum: Fantastic find!. This port doesn't have a maintainer, would you be willing to step up and watch over it? make sure any pr's submitter patch/and work? You won't be alone, you can ask for help in freebsd-ports. Most of the work is just like you did, submit a pr and a patch. If there is an update, try to keep it updated, or if someone else submits a pr, test it, approve it, reject it, and/or come up with a better patch. any interest? -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
scheidell 2012-04-25 22:08:28 UTC FreeBSD ports repository Modified files: audio/rplay Makefile pkg-plist Added files: audio/rplay/files extra-patch-ao rplay.in Removed files: audio/rplay/files rplayd.sh Log: - Fix crash on amd64 when rplayd parses the rplay.hosts file (extra-patch for amd64 only) [1] - Channel dougb and re-write the rc script [2] - Bump PORTREVISION PR: ports/166658 [1] Submitted by: Callum Gibson <callumgibson@optusnet.com.au> [1] Reviewed by: scheidell@ [2] Revision Changes Path 1.32 +14 -5 ports/audio/rplay/Makefile 1.1 +268 -0 ports/audio/rplay/files/extra-patch-ao (new) 1.1 +28 -0 ports/audio/rplay/files/rplay.in (new) 1.3 +0 -21 ports/audio/rplay/files/rplayd.sh (dead) 1.13 +1 -1 ports/audio/rplay/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Comitted, with changes. Please review. Thanks!
scheidell 2012-04-25 22:14:19 UTC FreeBSD ports repository Modified files: audio/rplay Makefile pkg-plist Added files: audio/rplay/files rplayd.in Removed files: audio/rplay/files rplay.in Log: - Correct previous commit: rplay.in sb rplayd.in, rename file, fix Makefile PR: ports/166658 Submitted by: scheidell@ (me) Revision Changes Path 1.33 +1 -1 ports/audio/rplay/Makefile 1.2 +0 -28 ports/audio/rplay/files/rplay.in (dead) 1.1 +28 -0 ports/audio/rplay/files/rplayd.in (new) 1.14 +1 -1 ports/audio/rplay/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"