Bug 167036 - ambigious output of fdisk(8)
Summary: ambigious output of fdisk(8)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 1.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-17 20:40 UTC by kes-kes
Modified: 2024-10-11 21:58 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kes-kes 2012-04-17 20:40:01 UTC 
mfsbsd# dd if=/dev/zero of=/dev/ada0 bs=512 count=10
mfsbsd# fdisk -I ada0
******* Working on device ada0 *******
fdisk: invalid fdisk partition table found

this is ambigious: 
 a) it was error message, command fail
 b) this is error message but command success
 c) this is just some message, command success

May be that will be better: 
******* Working on device ada0 *******
fdisk: invalid fdisk partition table found
fdisk: partition was fixed and initialized sucessfully
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:21 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-11 18:07:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=2af5769e3431f6b5d1bc0ddaac9082e53096e308

commit 2af5769e3431f6b5d1bc0ddaac9082e53096e308
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2024-10-11 16:13:08 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-10-11 18:06:33 +0000

    fdisk: Make confusing fdisk messages a little less ambiguous

    We print an error when we can't read the MBR. Add minimal messages about
    continuing anyway.

    PR: 167036
    Sponsored by:           Netflix

 sbin/fdisk/fdisk.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 3 Warner Losh freebsd_committer freebsd_triage 2024-10-11 21:58:58 UTC 
I have no plans to MFC this, since fdisk is in the glide path for removal.