Updates from version 0.3.8 to 0.3.10 files changed: Makefile files/md5 patches/patch-ad patches patch-ae pkg/PLIST Patches were changed as it was brought to my attention that the setuid bit on the binary was a security risk. The last line on PLIST is installed only when built with the gnome option. I thought it would be best to add it anyhow.
On Sat, Feb 19, 2000 at 12:51:23PM -0800, Kristopher Zentner wrote: > > [snip] > > The last line on PLIST is installed only when built with the gnome > option. I thought it would be best to add it anyhow. > > [...] > +/share/gnome/apps/Multimedia/soundtracker.desktop I don't think that initial / should be there. If it's only installed when USE_GNOME is set, either make a separate PLIST.gnome (probably overkill), or add something like: post-install: .if defined(USE_GNOME) @${ECHO} share/gnome/apps/Multimedia/soundtracker.desktop >> ${TMPPLIST} .endif Finally, if you want this file to be picked up by GNOME, then you'll need to add a: USE_X_PREFIX= yes to the Makefile, since GNOME itself expects to find pretty much everything under the same directory (in this case, /usr/X11R6). [Yes, I know thats less than optimal :(] -aDe -- Ade Lovett, Austin, TX.
> > I don't think that initial / should be there. oops, fixed. > > If it's only installed when USE_GNOME is set, either make a separate > PLIST.gnome (probably overkill), or add something like: <cut rest of message> I've decided to go the PLIST.gnome route since it seems more modular and who knows what they'll add to this since this program is still under active development. Shall I submit my diffs under a new pr? Just in case I'm adding them here (yes I'm still fairly new to this whole ports thing). changed files: Makefile files/md5 patches/patch-ad patches/patch-ae pkg/PLIST new file: pkg/PLIST.gnome diff -urN /usr/ports/audio/soundtracker/Makefile audio/soundtracker/Makefile --- /usr/ports/audio/soundtracker/Makefile Sun Jan 9 15:24:19 2000 +++ audio/soundtracker/Makefile Sat Feb 19 16:53:42 2000 @@ -1,12 +1,12 @@ # New ports collection makefile for: soundtracker -# Version required: 0.3.8 +# Version required: 0.3.10 # Date created: 28 November 1999 # Whom: kzentner # # $FreeBSD: ports/audio/soundtracker/Makefile,v 1.2 2000/01/09 23:24:19 ade Exp $ # -DISTNAME= soundtracker-0.3.8 +DISTNAME= soundtracker-0.3.10 CATEGORIES= audio MASTER_SITES= ftp://ftp.soundtracker.org/pub/soundtracker/v0.3/ @@ -18,6 +18,8 @@ GNU_CONFIGURE= YES CONFIGURE_ENV= GTK_CONFIG="${GTK_CONFIG}" + +USE_X_PREFIX= yes .if defined(USE_GNOME) CONFIGURE_ARGS+= --enable-gnome diff -urN /usr/ports/audio/soundtracker/files/md5 audio/soundtracker/files/md5 --- /usr/ports/audio/soundtracker/files/md5 Sun Jan 9 15:24:29 2000 +++ audio/soundtracker/files/md5 Fri Feb 18 22:06:51 2000 @@ -1 +1 @@ -MD5 (soundtracker-0.3.8.tar.gz) = 960764d7e728819f8e3c466f723fcd42 +MD5 (soundtracker-0.3.10.tar.gz) = 6f31c7049c5d0906068015232f7867a3 diff -urN /usr/ports/audio/soundtracker/patches/patch-ad audio/soundtracker/patches/patch-ad --- /usr/ports/audio/soundtracker/patches/patch-ad Sat Dec 25 07:35:43 1999 +++ audio/soundtracker/patches/patch-ad Sat Feb 19 00:04:07 2000 @@ -1,7 +1,11 @@ ---- app/Makefile.in.orig Mon Nov 29 01:49:07 1999 -+++ app/Makefile.in Mon Nov 29 01:49:59 1999 -@@ -466,3 +466,3 @@ +--- app/Makefile.in.orig Fri Feb 18 23:15:50 2000 ++++ app/Makefile.in Fri Feb 18 23:18:29 2000 +@@ -475,6 +475,6 @@ + install-exec-local: - chown root.root $(bindir)/soundtracker +- chmod +s $(bindir)/soundtracker + chown root.wheel $(bindir)/soundtracker - chmod +s $(bindir)/soundtracker ++# chmod +s $(bindir)/soundtracker + + # Tell versions [3.59,3.63) of GNU make to not export all variables. diff -urN /usr/ports/audio/soundtracker/patches/patch-ae audio/soundtracker/patches/patch-ae --- /usr/ports/audio/soundtracker/patches/patch-ae Sat Dec 25 07:35:43 1999 +++ audio/soundtracker/patches/patch-ae Sat Feb 19 00:06:09 2000 @@ -1,7 +1,11 @@ ---- app/Makefile.am.orig Mon Nov 29 01:49:43 1999 -+++ app/Makefile.am Mon Nov 29 01:49:53 1999 -@@ -42,3 +42,3 @@ +--- app/Makefile.am.orig Fri Feb 18 23:16:48 2000 ++++ app/Makefile.am Fri Feb 18 23:18:42 2000 +@@ -44,6 +44,6 @@ + install-exec-local: - chown root.root $(bindir)/soundtracker +- chmod +s $(bindir)/soundtracker + chown root.wheel $(bindir)/soundtracker - chmod +s $(bindir)/soundtracker ++# chmod +s $(bindir)/soundtracker + + stdir = $(datadir)/soundtracker diff -urN /usr/ports/audio/soundtracker/pkg/PLIST audio/soundtracker/pkg/PLIST --- /usr/ports/audio/soundtracker/pkg/PLIST Sun Jan 9 15:24:31 2000 +++ audio/soundtracker/pkg/PLIST Sat Feb 19 16:52:19 2000 @@ -2,6 +2,6 @@ share/locale/de/LC_MESSAGES/soundtracker.mo share/locale/es/LC_MESSAGES/soundtracker.mo share/locale/it/LC_MESSAGES/soundtracker.mo -share/locale/ja/LC_MESSAGES/soundtracker.mo share/locale/pl/LC_MESSAGES/soundtracker.mo +share/locale/ja/LC_MESSAGES/soundtracker.mo share/locale/ru/LC_MESSAGES/soundtracker.mo diff -urN /usr/ports/audio/soundtracker/pkg/PLIST.gnome audio/soundtracker/pkg/PLIST.gnome --- /usr/ports/audio/soundtracker/pkg/PLIST.gnome Sat Feb 19 17:05:59 2000 +++ audio/soundtracker/pkg/PLIST.gnome Sat Feb 19 16:52:12 2000 @@ -0,0 +1,8 @@ +bin/soundtracker +share/locale/de/LC_MESSAGES/soundtracker.mo +share/locale/es/LC_MESSAGES/soundtracker.mo +share/locale/it/LC_MESSAGES/soundtracker.mo +share/locale/pl/LC_MESSAGES/soundtracker.mo +share/locale/ja/LC_MESSAGES/soundtracker.mo +share/locale/ru/LC_MESSAGES/soundtracker.mo +share/gnome/apps/Multimedia/soundtracker.desktop
State Changed From-To: open->closed Update committed. I made some other modifications for more correct dependency handling in the Makefile.