Bug 170076 - [lpt] [patch] check readiness with predefined macros
Summary: [lpt] [patch] check readiness with predefined macros
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 1.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-07-22 22:10 UTC by Arvydas Sidorenko
Modified: 2024-10-13 21:48 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.35 KB, patch)
2012-07-22 22:10 UTC, Arvydas Sidorenko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvydas Sidorenko 2012-07-22 22:10:10 UTC 
Fix: From cd8ed3e8a1f2d2ebb618e697c432d9fcf85f13a7 Mon Sep 17 00:00:00 2001
From: Arvydas Sidorenko <asido4@gmail.com>
Date: Fri, 20 Jul 2012 01:28:52 +0200
Subject: [PATCH] lpt: check readiness with predefined macros

Signed-off-by: Arvydas Sidorenko <asido4@gmail.com>
---
 sys/dev/ppbus/lpt.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:01:19 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:40:00 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 3 Warner Losh freebsd_committer freebsd_triage 2024-10-11 22:55:54 UTC 
Change looks good to my eye.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-12 20:59:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4584c8f0ef54e19f7be79aeee1ba1c1154af14e1

commit 4584c8f0ef54e19f7be79aeee1ba1c1154af14e1
Author:     Arvydas Sidorenko <asido4@gmail.com>
AuthorDate: 2024-10-11 22:54:17 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-10-12 20:40:24 +0000

    lpt: check readiness with predefined macros

    Replace spelled-out bits with pre-defined macros for those same bits.
    No functional change.

    PR: 170076
    Reviewed by: imp

 sys/dev/ppbus/lpt.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
Comment 5 Warner Losh freebsd_committer freebsd_triage 2024-10-13 21:48:49 UTC 
Not important enough to MFC, closing