Bug 17034 - update port: devel/kdevelop: 1.0 -> 1.1
Summary: update port: devel/kdevelop: 1.0 -> 1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-02-28 05:10 UTC by Will Andrews
Modified: 2000-03-07 16:59 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (37.37 KB, patch)
2000-02-28 05:10 UTC, Will Andrews
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Will Andrews 2000-02-28 05:10:01 UTC
Upgrade devel/kdevelop to new version (kdevelop 1.1 final).
Changes to port:
	1) Remove invalid MASTER_SITE and add new ones.
	2) Move USE_OPTIONAL_RUNDEPENDS around.
	3) Allow changing the shlib number on libldkgloader (new library).
	4) General Makefile cleanups.
	5) Sort pkg/PLIST. Add new entries.
	6) Removed 2 obsolete patches (-aa,-ae), added one (-af).

I suppose I should've uuencoded this since it's so big. :-)

CC to R. Imura for his reference. He will probably leech some of the upgrade
information for his kdevelop-i18n off this PR. ;-)

How-To-Repeat: 
Use the patch below to fix the current port.
Comment 1 Will Andrews 2000-02-28 14:20:37 UTC
On Mon, Feb 28, 2000 at 12:06:37AM -0500, Will Andrews wrote:
>  RUN_DEPENDS=	autoconf:${PORTSDIR}/devel/autoconf
> +.if defined(USE_OPTIONAL_DEPENDS)
                            ^^^^^^^

Er, whoops. No wonder my make -DWANT_OPTIONAL_RUNDEPENDS didn't work. :)

-- 
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 2 imura 2000-02-28 14:21:15 UTC
> Upgrade devel/kdevelop to new version (kdevelop 1.1 final).
> Changes to port:
> 	1) Remove invalid MASTER_SITE and add new ones.
> 	2) Move USE_OPTIONAL_RUNDEPENDS around.
> 	3) Allow changing the shlib number on libldkgloader (new library).
> 	4) General Makefile cleanups.
> 	5) Sort pkg/PLIST. Add new entries.
> 	6) Removed 2 obsolete patches (-aa,-ae), added one (-af).
> 
> I suppose I should've uuencoded this since it's so big. :-)
> 
> CC to R. Imura for his reference. He will probably leech some of the upgrade
> information for his kdevelop-i18n off this PR. ;-)

Thanks, but sad to say, my main machine's M/B seems to be crashed...
I'm writing this mail with old slow note book, no distfiles, no ports tree,
no disk space, so I can not test your PR right now.

However, I can give you hints from my remember when I tested 1.1-Beta2.

  1) If you symlink /usr/include/g++/FlexLexer.h to WRKSRC, you can
     remove all of patches.
  2) You should add CONFIGURE_ARGS=--with-extra-{includes,libs} to
     LOCALBASE in order to detect -lpng in configure.

-- R. Imura
// my private mail address has changed.
// imura@cs.titech.ac.jp ====> imura@af.airnet.ne.jp /(-.-)y-~~
Comment 3 Will Andrews 2000-02-28 14:32:36 UTC
On Mon, Feb 28, 2000 at 11:21:15PM +0900, R. Imura wrote:
> Thanks, but sad to say, my main machine's M/B seems to be crashed...
> I'm writing this mail with old slow note book, no distfiles, no ports tree,
> no disk space, so I can not test your PR right now.

Oh, that sucks!

Would you like me to try upgrading kdevelop-i18n for you? This way, it'll
get into the tree before 4.0-RELEASE. Let me know if there's anything
particularly different about the -i18n port.

> However, I can give you hints from my remember when I tested 1.1-Beta2.
> 
>   1) If you symlink /usr/include/g++/FlexLexer.h to WRKSRC, you can
>      remove all of patches.

Hmm, interesting idea. I'll try it!

>   2) You should add CONFIGURE_ARGS=--with-extra-{includes,libs} to
>      LOCALBASE in order to detect -lpng in configure.

Ok. I'll look at it ASAP.

-- 
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 4 imura 2000-02-28 14:56:30 UTC
> Would you like me to try upgrading kdevelop-i18n for you? This way, it'll
> get into the tree before 4.0-RELEASE. Let me know if there's anything
> particularly different about the -i18n port.

Yes, please. :)

- From kdevelop-1.0

  o No PATCHFILES/EXTRA_PATCHS required. All of them are included
    in this release.

- Difference between mine and yours

  o Name of libralies. (See old patch-aa)
  o CONFIGURE_ENV=X_EXTRA_LIBS="-lxpg4" - do not forget this argument.

What about c_c++_reference.tar.gz ?
I think it's better to include into this port.
Or create a new port to install the documents?

-- R. Imura
// my private mail address has changed.
// imura@cs.titech.ac.jp ====> imura@af.airnet.ne.jp /(-.-)y-~~
Comment 5 Will Andrews 2000-02-28 17:56:42 UTC
On Mon, Feb 28, 2000 at 11:56:30PM +0900, R. Imura wrote:
> Yes, please. :)

Ok, no problem. I'll send-pr (probably tomorrow) and you can take a look.

> - Difference between mine and yours
> 
>   o Name of libralies. (See old patch-aa)
>   o CONFIGURE_ENV=X_EXTRA_LIBS="-lxpg4" - do not forget this argument.

Ok. You say the PATCHFILES listed in kdevelop-i18n Makefile are no longer
needed?

> What about c_c++_reference.tar.gz ?
> I think it's better to include into this port.
> Or create a new port to install the documents?

I think it should be a separate port. Not everyone wants documentation..

What are the "ShowBookmarks.tar.gz commentfeaturediff" files?

-- 
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 6 imura 2000-02-28 18:19:06 UTC
> On Mon, Feb 28, 2000 at 11:56:30PM +0900, R. Imura wrote:
> > Yes, please. :)
> 
> Ok, no problem. I'll send-pr (probably tomorrow) and you can take a look.

Thanks.

> > - Difference between mine and yours
> > 
> >   o Name of libralies. (See old patch-aa)
> >   o CONFIGURE_ENV=X_EXTRA_LIBS="-lxpg4" - do not forget this argument.
> 
> Ok. You say the PATCHFILES listed in kdevelop-i18n Makefile are no longer
> needed?

Yes, they are no longer needed.

> > What about c_c++_reference.tar.gz ?
> > I think it's better to include into this port.
> > Or create a new port to install the documents?
> 
> I think it should be a separate port. Not everyone wants documentation..

Ok, would you create the c++ reference port, too?
If you won't, that's ok. You can get rid of the documentation from
my port, anyway.

> What are the "ShowBookmarks.tar.gz commentfeaturediff" files?

They are used by EXTRA_PATCHES.
Ignore them. :)
Should be in 1.1.

-- R. Imura
// my private mail address has changed.
// imura@cs.titech.ac.jp ====> imura@af.airnet.ne.jp /(-.-)y-~~
Comment 7 Will Andrews 2000-02-28 20:53:27 UTC
On Tue, Feb 29, 2000 at 03:19:06AM +0900, R. Imura wrote:
> > I think it should be a separate port. Not everyone wants documentation..
> 
> Ok, would you create the c++ reference port, too?
> If you won't, that's ok. You can get rid of the documentation from
> my port, anyway.

Actually, now that I've gone and made a port of this, I realized a couple
unsettling problems. So I've decided not to make this a separate port. I
will generate a mechanism to install the documentation as requested, built
into the devel/kdevelop[-i18n] ports.

> They are used by EXTRA_PATCHES.
> Ignore them. :)
> Should be in 1.1.

Ok. I will remove DISTFILES from your port, since it is no longer needed.

-- 
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 8 imura freebsd_committer freebsd_triage 2000-03-07 16:56:50 UTC
State Changed
From-To: open->closed

Committed, thanks! 
Please check it yourself. 
I added some optional RUN_DEPENDS and MESSAGE.