Bug 175195 - [MAINTAINER] japanese/mecab-ipadic: trim makefile header
Summary: [MAINTAINER] japanese/mecab-ipadic: trim makefile header
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-11 07:00 UTC by Yasuhiro Kimura
Modified: 2013-01-15 22:00 UTC (History)
0 users

See Also:


Attachments
patch-ja-mecab-ipadic (348 bytes, text/plain)
2013-01-11 07:00 UTC, Yasuhiro Kimura
no flags Details
patch-ja-mecab-ipadic (859 bytes, text/plain; charset=Shift_JIS)
2013-01-11 15:01 UTC, Yasuhiro Kimura
no flags Details
patch-ja-mecab-ipadic (860 bytes, text/plain; charset=Shift_JIS)
2013-01-12 00:07 UTC, Yasuhiro Kimura
no flags Details
patch-ja-mecab-ipadic (907 bytes, text/plain; charset=Shift_JIS)
2013-01-14 01:26 UTC, Yasuhiro Kimura
no flags Details
patch-ja-mecab-ipadic (2.99 KB, text/plain; charset=Shift_JIS)
2013-01-15 09:48 UTC, Yasuhiro Kimura
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2013-01-11 07:00:00 UTC
	Trim makefile header.
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2013-01-11 07:22:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-01-11 15:01:28 UTC
License information is added. So please commit attached patch instead
of original one.

Regards.
Comment 3 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-01-12 00:07:19 UTC
I misunderstood the meaning of LICENSE_COMB. So please commit attached
patch instead of original and 2nd ones.

Best Regards.
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-01-14 01:26:58 UTC
"Created by:" header is added to Makefile. Please commit attached patch
instead of previous ones.

Regards.
Comment 5 Yasuhiro Kimura freebsd_committer freebsd_triage 2013-01-15 09:48:02 UTC
(2013/01/15 14:59), Jason Helfman wrote:
> please consider this diff.
> it updates the pkg-descr to something more, and adds charset as an
> option and removes pre-everything (target should not be used, and in my
> humble opinion satisfies the need by adding it as an option)
>
> I left the charset option off by default.
> Thanks!

Thank you for feedback. I checked it and made following changes:

1. At first, thank you for updating pkg-descr. But there are some 
non-ASCII characters included. As they cause portlint warning I removed 
them.
2. Portlint says LICENSE_NAME_* should be before LICENSE_FILE_*. So I 
followed it.
3. As to character set option, I found convenient OPTIONS_RADIO and 
OPTIONS_RADIO_${NAME} variables. So I used them.

Best Regards.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-01-15 21:51:14 UTC
Author: jgh
Date: Tue Jan 15 21:51:01 2013
New Revision: 310466
URL: http://svnweb.freebsd.org/changeset/ports/310466

Log:
  - trim historical header, add LICENSES, convert CHARSET to optionsNG and drop
    pre-everything target
  - update pkg-descr
  
  PR:		175195
  Submitted by:	maintainer, yasu@utahime.org

Modified:
  head/japanese/mecab-ipadic/Makefile   (contents, props changed)
  head/japanese/mecab-ipadic/pkg-descr   (contents, props changed)

Modified: head/japanese/mecab-ipadic/Makefile
==============================================================================
--- head/japanese/mecab-ipadic/Makefile	Tue Jan 15 21:45:33 2013	(r310465)
+++ head/japanese/mecab-ipadic/Makefile	Tue Jan 15 21:51:01 2013	(r310466)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	mecab-ipadic
-# Date created:		2006-05-07
-# Whom:			TAKATSU Tomonari <tota@rtfm.jp>
-#
+# Created by: TAKATSU Tomonari <tota@rtfm.jp>
 # $FreeBSD$
-#
 
 PORTNAME=	mecab
 DISTVERSION=	2.7.0-20070801
@@ -15,20 +11,36 @@ DISTNAME=	${PORTNAME}${PKGNAMESUFFIX}-${
 MAINTAINER=	yasu@utahime.org
 COMMENT=	Japanese Morphological Dictionary for MeCab
 
+LICENSE=	NAIST ICOT
+LICENSE_COMB=	multi
+LICENSE_NAME_NAIST=	NAIST
+LICENSE_NAME_ICOT=	ICOT
+LICENSE_FILE_NAIST=	${WRKSRC}/COPYING
+LICENSE_FILE_ICOT=	${WRKSRC}/COPYING
+LICENSE_PERMS_NAIST=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
+LICENSE_PERMS_ICOT=	dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
+
 BUILD_DEPENDS=	ja-mecab>=0.94:${PORTSDIR}/japanese/mecab
 
+OPTIONS_RADIO=	CHARSET
+OPTIONS_RADIO_CHARSET=	EUCJP SHIFTJIS UTF8
+
+EUCJP_DESC=	Use EUC-JP as dictionary charset.
+SHIFTJIS_DESC=	Use SHIFT-JIS as dictionary charset.
+UTF8_DESC=	Use UTF-8 as dictionary charset.
+
 USE_PERL5_BUILD=	yes
 GNU_CONFIGURE=		yes
 CONFIGURE_ARGS+=	--with-dicdir=${PREFIX}/lib/mecab/dic/ipadic
 
-# Set charset (euc-jp/shift_jis/utf-8)
-.if defined(WITH_CHARSET)
-CONFIGURE_ARGS+=	--with-charset=${WITH_CHARSET}
-.endif
+.include <bsd.port.options.mk>
 
-pre-everything::
-	@${ECHO_MSG} ""
-	@${ECHO_MSG} "  WITH_CHARSET=charset  sets default charset (euc-jp/shift_jis/utf-8)"
-	@${ECHO_MSG} ""
+.if ${PORT_OPTIONS:MEUCJP}
+CONFIGURE_ARGS+=	--with-charset=euc-jp
+.elif ${PORT_OPTIONS:MSHIFTJIS}
+CONFIGURE_ARGS+=	--with-charset=shift_jis
+.elif ${PORT_OPTIONS:MUTF8}
+CONFIGURE_ARGS+=	--with-charset=utf-8
+.endif
 
 .include <bsd.port.mk>

Modified: head/japanese/mecab-ipadic/pkg-descr
==============================================================================
--- head/japanese/mecab-ipadic/pkg-descr	Tue Jan 15 21:45:33 2013	(r310465)
+++ head/japanese/mecab-ipadic/pkg-descr	Tue Jan 15 21:51:01 2013	(r310466)
@@ -1,4 +1,18 @@
-Japanese Morphological Dictionary for MeCab.
+MeCab the Graduate School of Informatics, Kyoto University Unit - Joint
+Research Project Communication Science Laboratories, Nippon Telegraph and
+Telephone Corporation morphological analysis engine that was developed
+through open source. The basic policy is to design a general-purpose
+language-independent, dictionary and corpus.  (Conditional Random Fields
+for the estimation of the parameters CRF has been used), ChaSen performance
+has improved compared to the hidden Markov model is employed. In addition,
+on average ChaSen , Juman , KAKASI run faster than.  Turnip Undaria pinnatifida
+(wear eye) is the way the author's favorite food.
+
+* Generic design that does not depend dictionary, the corpus
+* Conditional Random Fields ( CRF on the basis of high analysis accuracy)
+* ChaSen and KAKASI faster than
+* Structure algorithm / data dictionary lookup is a fast TRIE structure Double-Array adopted.
+* Libraries that can be re-entrant
+* Various scripting language bindings (perl / ruby / python / java / C #)
 
-Author:	Taku Kudo <taku@chasen.org>
 WWW:   http://mecab.sourceforge.net/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Jason Helfman freebsd_committer freebsd_triage 2013-01-15 21:51:17 UTC
State Changed
From-To: open->closed

Committed. Thanks!