Bug 177587 - [PATCH] audio/mp3guessenc: update 2 upstream versions to 0.25 beta 1
Summary: [PATCH] audio/mp3guessenc: update 2 upstream versions to 0.25 beta 1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 20:50 UTC by Matthias Andree
Modified: 2013-04-17 13:00 UTC (History)
1 user (show)

See Also:


Attachments
mp3guessenc-0.25.b1.patch (1.56 KB, patch)
2013-04-02 20:50 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2013-04-02 20:50:00 UTC
- Makefile adjusted to heed CPPFLAGS, LDFLAGS, LIBS.

- Upgrade two versions to 0.25 beta 1. No more stat64 hassles. As discussed
on IRC March 6th and with Elio (upstream maintainer) by email.

(Seems to work for me on amd64, but hangs noisily on one known broken MP3 file.)

Emanuel, please judge for yourself if this warrants portmgr@ permission to
upgrade, or if you can leave 0.23alphablah to ship and upgrade after the
freeze is lifted.

- Upstream changelog:
version 0.25 beta 1 (2013/03/24, "Please Please Please Let Me Release What I Want")
 - added a version check on the lame string found in xing vbr tag in order to
   avoid reading a lame tag where there isn't one (first lame tag appeared in v3.90,
   previous versions just added a signature string to the xing vbr tag)
 - detection of Ape tag v1/v2 - actually read main data, then skip it
 - increased buffer size due to the maximum length freeformat frames can have (5760 bytes
   when encoding 8 kHz content into a 640 kbps stream -- quite strange, yet still feasible)
 - fixed detection of mp3Surround streams encoded with OFL (original file length) feature
 - added detection of mp3Surround streams too!
   (mp3Surround is another extension of mp3 which brings multi channel audio out of a
   regular mp3 stream. Almost an un-flexible (only encodes 5.1 channels - 44.1 kHz and
   48 kHz, and that's all) and unknown one, though)
 - mp3guessenc is now able to detect mp3PRO streams!
   (Well, the detection method is somewhat trivial but it works with any sample stream I
   could test. Actually, I'm not aware of any other utility able to tell `normal'
   mp3 streams from mp3PRO ones without the need of external closed libraries.)
 - many integer variables are now declared as off_t (which can become 64 bit integers
   on systems supporting them) for correct handling of large files (> 256MB)
   Now mp3guessenc can scan files up to 2^60 bytes long. Thanks to Matthias Andree for
   pointing me to a portable solution for large files support.
 - show ancillary data infos (for layerIII only)
 - fixed encoder delay info for both fhg and lame encodings


version 0.25 alpha 24 (2013/02/21, the "Owner Of A Lonely Release" release)
 - added workaround for buggy lame vbr tag in freeformat streams
 - enhanced detection of frame size in layerIII free format streams
 - sync error counter now gets updated
 - update GUESSING ENGINE! Added support for gogo, helix and updated detection for known
   encoders (xing/lame/fhg)
 - refined memory requirements: less buffers, better managed
 - more comments in bit-handling routines (now everything is clear to me, eh eh)
 - fixed out-of-bound write in `extract_lame_string'
 - enhanced modularity: source was splitted into modules (so mp3guessenc.c is lighter now!)
 - refined detection of lame string into the first frame (xing/lame tag)
 - fixed regression in lame string detection into the very last frame
 - added missing structure initialization
 - added tag offset value (for xing/lame/vbri tags)
 - replaced old `for' cycles with more efficient memset/memcpy routines
 - replaced `stat' with `stat64' in order to avoid crashes when managing large files
 - fixed detection of long/mixed/switch blocks in compliance with lame results (short blocks
   were already correctly detected)
 - mp3guessenc is now lame-preset aware
 - fixed nice coherent alignment

Port maintainer (ehaupt@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-02 20:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2013-04-03 08:54:43 UTC
Thanks for your PR. I'll update the port right after the current port
freeze is lifted.
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2013-04-17 12:50:37 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-04-17 12:50:40 UTC
Author: ehaupt
Date: Wed Apr 17 11:50:32 2013
New Revision: 315960
URL: http://svnweb.freebsd.org/changeset/ports/315960

Log:
  Update to 0.25.b1
  
  PR:		177587
  Submitted by:	mandree
  Feature safe:	yes

Modified:
  head/audio/mp3guessenc/Makefile
  head/audio/mp3guessenc/distinfo

Modified: head/audio/mp3guessenc/Makefile
==============================================================================
--- head/audio/mp3guessenc/Makefile	Wed Apr 17 11:32:01 2013	(r315959)
+++ head/audio/mp3guessenc/Makefile	Wed Apr 17 11:50:32 2013	(r315960)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	mp3guessenc
-DISTVERSION=	${DIST_REL}${ALPHA_REL}
+DISTVERSION=	${DIST_REL}${BETA_REL}
 CATEGORIES=	audio
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}-${DIST_REL}
 
@@ -12,17 +12,17 @@ COMMENT=	Utility for guessing which enco
 MAKE_JOBS_SAFE=	yes
 
 DIST_REL=	0.25
-ALPHA_REL=	alpha23-HPR
+BETA_REL=	beta1
 
 PLIST_FILES=	bin/mp3guessenc
-SRC=		decode.c mp3guessenc.c
+SRC=		decode.c mp3guessenc.c bit_utils.c tags.c
 
 do-build:
 .for f in ${SRC}
 	${CC} ${CFLAGS} ${WRKSRC}/${f} -c -o ${WRKSRC}/${f:C/\.c/.o/}
 .endfor
 	${CC} ${SRC:S|\.c|${WRKSRC}/.o|:S|^|${WRKSRC}/|} \
-		-o ${WRKSRC}/${PORTNAME}
+		-o ${WRKSRC}/${PORTNAME} ${LDFLAGS}
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin

Modified: head/audio/mp3guessenc/distinfo
==============================================================================
--- head/audio/mp3guessenc/distinfo	Wed Apr 17 11:32:01 2013	(r315959)
+++ head/audio/mp3guessenc/distinfo	Wed Apr 17 11:50:32 2013	(r315960)
@@ -1,2 +1,2 @@
-SHA256 (mp3guessenc-0.25alpha23-HPR.tar.gz) = 50937dcb66d32ab2ff4e560d8f1f437a5d0ea76c9061e96cf78101e2bb84f1bd
-SIZE (mp3guessenc-0.25alpha23-HPR.tar.gz) = 53920
+SHA256 (mp3guessenc-0.25beta1.tar.gz) = df8ad7e94d8d2f0151a346d400d53ac8246d6deff4ffc968ffd02241777510e0
+SIZE (mp3guessenc-0.25beta1.tar.gz) = 84588
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"