Bug 179214 - audio/xcd: Fix build with clang
Summary: audio/xcd: Fix build with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-02 19:10 UTC by tkato432
Modified: 2013-06-04 09:30 UTC (History)
0 users

See Also:


Attachments
file.diff (3.45 KB, patch)
2013-06-02 19:10 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2013-06-02 19:10:02 UTC
- Fix build with clang

New file:
files/patch-aa
files/patch-ab

Remove file:
files/patch-cdplayer.cc
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-02 19:10:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2013-06-04 09:25:12 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-06-04 09:25:26 UTC
Author: miwi
Date: Tue Jun  4 08:25:12 2013
New Revision: 319833
URL: http://svnweb.freebsd.org/changeset/ports/319833

Log:
  - Fix build with clang
  
  PR:		179214
  Submitted by:	Ports Fury

Added:
  head/audio/xcd/files/patch-cdplayer.cc   (contents, props changed)
Modified:
  head/audio/xcd/Makefile   (contents, props changed)
  head/audio/xcd/files/patch-aa   (contents, props changed)
  head/audio/xcd/files/patch-ab   (contents, props changed)

Modified: head/audio/xcd/Makefile
==============================================================================
--- head/audio/xcd/Makefile	Tue Jun  4 08:24:32 2013	(r319832)
+++ head/audio/xcd/Makefile	Tue Jun  4 08:25:12 2013	(r319833)
@@ -5,31 +5,45 @@ PORTNAME=	xcd
 PORTVERSION=	1.7
 PORTREVISION=	3
 CATEGORIES=	audio tk
-MASTER_SITES=	${MASTER_SITE_LOCAL}
-MASTER_SITE_SUBDIR=	jmz
+MASTER_SITES=	LOCAL/jmz
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Tcl/Tk CD player
 
-USE_TK=		yes
-WRKSRC=		${WRKDIR}/xcd
+WRKSRC=		${WRKDIR}/${PORTNAME}
+
+USE_TK_WRAPPER=	yes
+
 MAN1=		xcd.1
 
 .if !defined(WITH_CDROM_PLAYER)
-WITH_CDROM_PLAYER=	acd0
+WITH_CDROM_PLAYER=	cd0
 .endif
 
 pre-extract:
 	@${ECHO_CMD} ""
 	@${ECHO_CMD} "You can define WITH_CDROM_PLAYER to set the default CD/DVD player"
-	@${ECHO_CMD} "Default: acd0"
+	@${ECHO_CMD} "Default: cd0"
 	@${ECHO_CMD} ""
 	@${ECHO_CMD} "Use the CDPLAYER environment variable to override it."
 	@${ECHO_CMD} ""
 
 post-patch:
 	@${REINPLACE_CMD} 's|cd0c|${WITH_CDROM_PLAYER}|' ${WRKSRC}/cdplayer.cc
-	@${REINPLACE_CMD} 's|/usr/local/bin/wish8.0|${WISH}|' ${WRKSRC}/xcd.in
-	@${REINPLACE_CMD} 's|/usr/local|${PREFIX}|' ${WRKSRC}/Makefile
+	@(cd ${WRKSRC} && ${SED} -e \
+		's|/usr/local/bin/wish8.0|${WISH}| ; \
+		 s|CDPLAYER|${PREFIX}/lib/xcd/cdplayer| ; \
+		 s|BITMAPDIR|${PREFIX}/lib/xcd|' \
+		< xcd.in > xcd)
+
+do-build:
+	(cd ${WRKSRC} && ${CXX} ${CXXFLAGS} -o cdplayer cdplayer.cc)
+
+do-install:
+	(cd ${WRKSRC} && ${INSTALL_SCRIPT} xcd ${PREFIX}/bin)
+	(cd ${WRKSRC} && ${INSTALL_MAN} xcd.1 ${MANPREFIX}/man/man1)
+	@${MKDIR} ${PREFIX}/lib/xcd
+	(cd ${WRKSRC} && ${INSTALL_PROGRAM} cdplayer ${PREFIX}/lib/xcd)
+	(cd ${WRKSRC}/bitmaps && ${INSTALL_DATA} *.xbm ${PREFIX}/lib/xcd)
 
 .include <bsd.port.mk>

Modified: head/audio/xcd/files/patch-aa
==============================================================================
--- head/audio/xcd/files/patch-aa	Tue Jun  4 08:24:32 2013	(r319832)
+++ head/audio/xcd/files/patch-aa	Tue Jun  4 08:25:12 2013	(r319833)
@@ -1,11 +0,0 @@
---- cdplayer.cc.orig	Sat Nov 27 16:20:49 1999
-+++ cdplayer.cc	Sat Nov 27 16:24:02 1999
-@@ -29,7 +29,7 @@
- public:
-     button (char *s) {state=0; strcpy (name, s);}
-     ~button () {}
--    set (int i) {
-+    void set (int i) {
- 	if (state != i) {
- 	    state = i;
- 	    if (state == 0)

Modified: head/audio/xcd/files/patch-ab
==============================================================================
--- head/audio/xcd/files/patch-ab	Tue Jun  4 08:24:32 2013	(r319832)
+++ head/audio/xcd/files/patch-ab	Tue Jun  4 08:25:12 2013	(r319833)
@@ -1,11 +0,0 @@
---- Makefile.orig	Mon Oct 26 16:14:26 1998
-+++ Makefile	Sun Sep  8 13:14:02 2002
-@@ -8,7 +8,7 @@
- 		< xcd.in > $@
- 	chmod ugo+x xcd
- cdplayer: cdplayer.cc
--	$(CC) $(CFLAGS) -o $@ cdplayer.cc -lm
-+	$(CXX) $(CXXFLAGS) -o $@ cdplayer.cc -lm
- 
- install: xcd cdplayer
- 	mkdir -p $(BINDIR)

Added: head/audio/xcd/files/patch-cdplayer.cc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/xcd/files/patch-cdplayer.cc	Tue Jun  4 08:25:12 2013	(r319833)
@@ -0,0 +1,20 @@
+--- cdplayer.cc.orig	Sat Nov 27 16:20:49 1999
++++ cdplayer.cc	Sat Nov 27 16:24:02 1999
+@@ -29,7 +29,7 @@
+ public:
+     button (char *s) {state=0; strcpy (name, s);}
+     ~button () {}
+-    set (int i) {
++    void set (int i) {
+ 	if (state != i) {
+ 	    state = i;
+ 	    if (state == 0)
+@@ -90,7 +90,7 @@
+ #define S(t) toc_buffer[t].addr.msf.second
+ #define F(t) toc_buffer[t].addr.msf.frame
+ 
+-main (int argc, char **argv)
++int main (int argc, char **argv)
+ {
+     char dev[20], line[50];
+     int i;
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"