Bug 183765 - /boot/{menu,loader}.rc do not get updated by "make installkernel"
Summary: /boot/{menu,loader}.rc do not get updated by "make installkernel"
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Allan Jude
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 22:20 UTC by Bertram Scharpf
Modified: 2016-01-07 01:52 UTC (History)
3 users (show)

See Also:


Attachments
remove menu.rc and loader.rc install guards (3.84 KB, patch)
2015-04-02 18:19 UTC, Nikolai Lifanov
no flags Details | Diff
remove menu.rc and loader.rc install guards (3.62 KB, patch)
2015-07-23 19:59 UTC, Nikolai Lifanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bertram Scharpf 2013-11-07 22:20:00 UTC
FreeBSD 9.2 provides newer versions for the files
"/boot/menu.rc" and "/boot/loader.rc". These will not be installed.

  # cd /usr/src
  # make installkernel

  # ls -lat /usr/src/sys/boot/forth/menu.rc /boot/menu.rc
  # diff    /usr/src/sys/boot/forth/menu.rc /boot/menu.rc

There was a question about this on the mailing list in July, but
the guy who asked did not receive one single answer. Before
encountering the same treatment, I decided to make a bug report
out of it.

After all, it is a behaviour no one could instinctively expect.

Fix: 

The decision is made in "/usr/src/sys/boot/$arch/loader/Makefile"
in about line 100.

Instead of a fix, maybe the handbook should be extended by
a pointer to the problem.
How-To-Repeat: Install FreeBSD 9.1. Then upgrade to 9.2 as descibed in
<http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html>.
Comment 1 Bertram Scharpf 2013-11-07 22:29:10 UTC
Another possibility would be to include the files into the
"make distribution" procedure.
Comment 2 lists 2013-11-22 15:47:18 UTC
Reminder: Not a single reaction in more than two weeks.

-- 
Bertram Scharpf
Stuttgart, Deutschland/Germany
http://www.bertram-scharpf.de
Comment 3 lists 2013-12-14 23:34:07 UTC
Reminder: Not a single reaction in more than 5 weeks.
Comment 4 Adam McDougall 2013-12-20 20:34:23 UTC
On 12/14/2013 18:40, Bertram Scharpf wrote:
> The following reply was made to PR kern/183765; it has been noted by GNATS.
> 
> From: Bertram Scharpf <lists@bertram-scharpf.de>
> To: bug-followup@FreeBSD.org
> Cc:  
> Subject: Re: kern/183765: /boot/{menu,loader}.rc do not get updated by "make
>  installkernel"
> Date: Sun, 15 Dec 2013 00:34:07 +0100
> 
>  Reminder: Not a single reaction in more than 5 weeks.

make installkernel only installs the kernel and kernel modules and
nothing else.  To me, it lives up to its name since /boot/loader.rc is
not a kernel.  make installworld installs the other files under /boot,
but doesn't update boot sector code.  What is the problem that is being
encountered?  Is make installworld not installing the files you expect?
 (Step 6).  Or is the reboot failing after step 4 because
/boot/{menu,loader}.rc are not updated?
Comment 5 Nikolai Lifanov 2015-04-02 18:19:17 UTC
Created attachment 155127 [details]
remove menu.rc and loader.rc install guards
Comment 6 Nikolai Lifanov 2015-04-02 18:20:40 UTC
Since r258270 try-include's menu.rc.local and loader.rc.local, the install guards can go away. This will make installworld experience match that of freebsd-update.
Comment 7 Andrey Fesenko 2015-07-23 19:05:55 UTC
Update r285736 to r285816, menu.rc not auto update
Comment 8 Nikolai Lifanov 2015-07-23 19:58:29 UTC
I opened Differential D3176 about it: https://reviews.freebsd.org/D3176
Comment 9 Nikolai Lifanov 2015-07-23 19:59:22 UTC
Created attachment 159122 [details]
remove menu.rc and loader.rc install guards

reroll patch
Comment 10 Allan Jude freebsd_committer freebsd_triage 2015-07-24 00:17:04 UTC
This blocks my D3167 as well
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-08-06 16:07:53 UTC
A commit references this bug:

Author: allanjude
Date: Thu Aug  6 16:07:32 UTC 2015
New revision: 286368
URL: https://svnweb.freebsd.org/changeset/base/286368

Log:
  Remove guards around overwriting loader.rc and menu.rc

  There have been .local version of each for user modifications for some time
  This allows users to receive future updates to these files

  PR:		183765
  Submitted by:	Bertram Scharpf, Nikolai Lifanov (patch)
  Reviewed by:	dteske, loos, eadler
  Approved by:	bapt (mentor)
  MFC after:	1 month
  Relnotes:	yes
  Sponsored by:	ScaleEngine Inc.
  Differential Revision:	https://reviews.freebsd.org/D3176

Changes:
  head/UPDATING
  head/sys/boot/forth/loader.rc
  head/sys/boot/forth/menu.rc
  head/sys/boot/i386/loader/Makefile
  head/sys/boot/mips/beri/loader/Makefile
  head/sys/boot/pc98/loader/Makefile
  head/sys/boot/powerpc/kboot/Makefile
  head/sys/boot/powerpc/ofw/Makefile
  head/sys/boot/powerpc/ps3/Makefile
  head/sys/boot/sparc64/loader/Makefile
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-01-07 01:51:15 UTC
A commit references this bug:

Author: dteske
Date: Thu Jan  7 01:50:51 UTC 2016
New revision: 293294
URL: https://svnweb.freebsd.org/changeset/base/293294

Log:
  MFC r286368: Remove guards around overwriting loader.rc and menu.rc

  There have been .local version of each for user modifications for some time
  This allows users to receive future updates to these files

  PR:		183765
  Differential Revision:	https://reviews.freebsd.org/D3176
  Submitted by:	Bertram Scharpf, Nikolai Lifanov (patch)
  Reviewed by:	dteske, loos, eadler
  Approved by:	bapt (mentor)
  Relnotes:	yes
  Sponsored by:	ScaleEngine Inc.

Changes:
_U  stable/10/
  stable/10/UPDATING
  stable/10/sys/boot/forth/loader.rc
  stable/10/sys/boot/forth/menu.rc
  stable/10/sys/boot/i386/loader/Makefile
  stable/10/sys/boot/pc98/loader/Makefile
  stable/10/sys/boot/powerpc/ofw/Makefile
  stable/10/sys/boot/powerpc/ps3/Makefile
  stable/10/sys/boot/sparc64/loader/Makefile