Exit status of route(8) command in case of failure depends of presence of '-q' flags: exit status is always 0 with '-q'. How-To-Repeat: # route delete default delete net default fib 0 # route -q change default 10.58.0.1; echo $? route: writing to routing socket: No such process 0 # route change default 10.58.0.1; echo $? route: writing to routing socket: No such process change net default: gateway 10.58.0.1 fib 0: not in table 1
Responsible Changed From-To: freebsd-bugs->hrs I'll take this.
Created attachment 182735 [details] fix exit status for "route -q add/change/delete" New fix for same problem.
batch change: For bugs that match the following - Status Is In progress AND - Untouched since 2018-01-01. AND - Affects Base System OR Documentation DO: Reset to open status. Note: I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
My PR.
A commit references this bug: Author: eugen Date: Sat Oct 27 07:59:19 UTC 2018 New revision: 339811 URL: https://svnweb.freebsd.org/changeset/base/339811 Log: route(8): correctly return exit status when "-q" flag is used. Previously, route returned 1 in case of error properly signalling failure but "route -q" it returned 0 for same case. Fix it. PR: 186333 MFC after: 1 month Changes: head/sbin/route/route.c
A commit references this bug: Author: eugen Date: Mon Nov 26 11:05:27 UTC 2018 New revision: 340940 URL: https://svnweb.freebsd.org/changeset/base/340940 Log: MFC r339811: route(8): correctly return exit status when "-q" flag is used. Previously, route returned 1 in case of error properly signalling failure but "route -q" it returned 0 for same case. Fix it. PR: 186333 Changes: _U stable/12/ stable/12/sbin/route/route.c
A commit references this bug: Author: eugen Date: Mon Nov 26 11:08:38 UTC 2018 New revision: 340943 URL: https://svnweb.freebsd.org/changeset/base/340943 Log: MFC r339811: route(8): correctly return exit status when "-q" flag is used. Previously, route returned 1 in case of error properly signalling failure but "route -q" returned 0 in the same case. Fix it. PR: 186333 Changes: _U stable/11/ stable/11/sbin/route/route.c