Bug 188651 - [PATCH] net-im/gajim add missing dependencies, fix icons and Options
Summary: [PATCH] net-im/gajim add missing dependencies, fix icons and Options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-15 11:10 UTC by Rusmir Dusko
Modified: 2014-10-05 20:36 UTC (History)
0 users

See Also:


Attachments
file.diff (13.84 KB, patch)
2014-04-15 11:10 UTC, Rusmir Dusko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rusmir Dusko freebsd_committer freebsd_triage 2014-04-15 11:10:00 UTC
- Bump PORTREVISION for dependencies changes
- Change master site
- Take maintainership
- Add dependencies for textproc/p5-XML-Parser and
  security/py-openssl
- Use tar:bzip2 instead of USE_BZIP2=yes
- Reordering USES and other dependencies to be
  more clean
- Rename Option CRYPTO to E2EE, according to Wikipedia
- Remove NLS from default Options
- Add descripton for GUPNP
- Add NLS_CONFIGURE_ENABLE=nls
- Add pkg-message, information about usage plugins,
  E2EE and OTR
- Add REINPLACE, fix icons and usage for E2EE
- Use and simplify do-build instead of pre-build
- Recreate pkg-plist with make makeplist, remove mtree

Fix: Apply enclosed diff. Many users have tested this patch and find it good.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-15 11:10:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2014-10-05 20:18:50 UTC
Hi,

 1. ${PORTVERSION:R} in MASTER_SITES doesn't work for 0.16. Rejected.
 2. Knobs sorting. Implemented. 
 3. GUPNP option description added.
 4. GUPNP_RUN_DEPENDS syntax works by accident. Rejected.
 5. NLS_CONFIGURE_ENABLE=nls is already default. Rejected.
 6. REINPLACE_CMD in post-patch is effectively noop against current
    state. Rejected. 
 7. p5-XML-Parser is an intltool dependency, not gajim itself. Rejected. But
    explicit intltool dependency is indeed required for gajim. 
 8. I'm ok with CRYPTO option name. Renaming rejected.
 9. HAVE_PYCRYPTO variable is a result of checking Crypto module existance. 
    User may already have pycrypto installed as another port dependency. Anyway,
    I see no reason to hardcode anything like this and prefer to stay closer to
    upstream. User will decide it by self after reading of your pkg-message. So,
    rejected.
10. I'm ok with changing compile/optimize command lines in pre-build.
11. pkg-message added. Please note there is also security/py-potr, that works
    with gotr gajim plugin.
12. I'd prefer to keep maintainership, as I already told you some time ago.
    
All the changes from this PR will appear in gajim 0.16 update tomorrow. Thank you.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-05 20:36:31 UTC
A commit references this bug:

Author: rm
Date: Sun Oct  5 20:35:47 UTC 2014
New revision: 370115
URL: https://svnweb.freebsd.org/changeset/ports/370115

Log:
  net-im/gajim: update to 0.16

  - update to 0.16
  - add LICENSE_FILE
  - add dependency on net-im/py-nbxmpp
  - remove local patch for host/nslookup issue - the proper solution was
    implemented upstream
  - remove dirrms from pkg-plist

  Changelog:
  https://bugs.launchpad.net/ubuntu/+source/gajim/+bug/1377589

  - cherrypicking changes from ports/188651 [1]:
    - sort knobs
    - add missing GUPNP option description
    - explicitly define intltool dependency
    - beautify commandline in pre-build target
    - add pkg-message with crypto plugins information

  PR:		188651
  Submitted by:   nemysis [1]

Changes:
  head/net-im/gajim/Makefile
  head/net-im/gajim/distinfo
  head/net-im/gajim/files/extra-patch-src-common_resolver.py
  head/net-im/gajim/files/patch-src-Makefile.in
  head/net-im/gajim/files/pkg-message.in
  head/net-im/gajim/pkg-plist