Bug 190328 - New port: graphics/ttygif
Summary: New port: graphics/ttygif
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 23:50 UTC by olivier
Modified: 2014-08-15 16:44 UTC (History)
3 users (show)

See Also:


Attachments
file.shar (1.66 KB, text/plain)
2014-05-27 23:50 UTC, olivier
no flags Details
portlint, redports and poudriere testport log (21.29 KB, text/plain)
2014-08-12 17:30 UTC, olivier
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description olivier 2014-05-27 23:50:00 UTC
ttygif permit to convert ttyrec record into animated gif.
It's a 3 steps process:
1. Generate a ttyrecord file with misc/ttyrec
2. convert the ttyrecord in multiple image file with ttygif
3. convert the multiple image with a unique animated gif file with concat

Fix: Patch attached with submission follows:
Comment 1 Steve Wills freebsd_committer freebsd_triage 2014-07-11 17:24:41 UTC
Built this, but when I tested it, all I get is:

Syntax error: "(" unexpected
snapshot: No error: 0

Any ideas?
Comment 2 olivier 2014-07-11 17:56:34 UTC
Did you correctly start it from an xterm terminal under xorg ?
Comment 3 Steve Wills freebsd_committer freebsd_triage 2014-07-11 17:57:43 UTC
(In reply to olivier from comment #2)
> Did you correctly start it from an xterm terminal under xorg ?

No, I was running it remotely. Does it have to be local?

Steve
Comment 4 olivier 2014-07-11 18:00:34 UTC
Yes: this software do xterm screenshot for each frame during replay, then assemble each screenshots in one animated file.
I don't know how to be sure user understand they NEED to start it from a local xterm session: A message file ?
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-11 10:43:34 UTC
swills, what do you want to do with this port?  It's stalled because of your questioning.
Comment 6 Steve Wills freebsd_committer freebsd_triage 2014-08-11 20:02:37 UTC
(In reply to John Marino from comment #5)
> swills, what do you want to do with this port?  It's stalled because of your
> questioning.

Oh, don't let my confusion get in the way, sorry. I was looking at committing it, but ran into that issue testing it and haven't had time to get back to it, but assuming it works OK when used properly (I wasn't using it properly), then go ahead and commit it.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-11 20:16:03 UTC
Olivier, do you have any verification available?  In order of preference, examples of what I'm looking for are:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output  (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)

Also, please run "portlint" and paste the output.
Comment 8 olivier 2014-08-12 17:30:54 UTC
Created attachment 145725 [details]
portlint, redports and poudriere testport log
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-12 18:14:38 UTC
Okay, I'll recommend to the committer that takes this PR to fix the portlint warning:

root@orange:/usr/ports/graphics/ttygif # portlint -A
WARN: Makefile: [27]: use ${VARIABLE}, instead of $(VARIABLE).

I'll move this to patch-ready.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-15 15:15:53 UTC
I'm not getting the warning (you must be using an older portlint) but I see what's happening.

You have sed -e 's:gcc:$(CC):' <file>

I think you wanted to replace "gcc" with the text "$(CC)" but instead replace "gcc" with "cc" (which is the value of $CC).  If that's right, it was a bug that does exactly what you wanted.

to be explicit, I'm going to change this to ${CC} so we know it's intended to replace the value and not the name of the environment variable.
Comment 11 John Marino freebsd_committer freebsd_triage 2014-08-15 15:16:33 UTC
also tabs are all over the place so it's like you had different editors or different tab settings.
Comment 12 commit-hook freebsd_committer freebsd_triage 2014-08-15 15:31:13 UTC
A commit references this bug:

Author: marino
Date: Fri Aug 15 15:30:25 UTC 2014
New revision: 364980
URL: http://svnweb.freebsd.org/changeset/ports/364980

Log:
  Add new port graphics/ttygif

  PR:		190328
  Submitted by:	Olivier (cochard.me)

  ttygif permit to convert ttyrec record into animated gif.
  It's a 3 steps process:
  1. Generate a ttyrecord file with misc/ttyrec
  2. convert the ttyrecord in multiple image file with ttygif
  3. convert the multiple image with a unique animated gif file with concat

Changes:
  head/graphics/Makefile
  head/graphics/ttygif/
  head/graphics/ttygif/Makefile
  head/graphics/ttygif/distinfo
  head/graphics/ttygif/pkg-descr
Comment 13 John Marino freebsd_committer freebsd_triage 2014-08-15 15:32:41 UTC
It built fine, thanks!
Comment 14 John Marino freebsd_committer freebsd_triage 2014-08-15 15:37:29 UTC
what's the different between ttygif and this port which was committed today?

http://www.freshports.org/graphics/seq2gif/

CC'ing pi@ as he committed it.
Maybe they are the same s/w or very similar?
Comment 15 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-15 16:44:35 UTC
(In reply to John Marino from comment #14)
> what's the different between ttygif and this port which was committed today?
> 
> http://www.freshports.org/graphics/seq2gif/

Good question: From the usage of seq2gif, it looks like it does
steps 2 and 3 in one go:

seq2gif [Options] -i ttyrecord -o record.gif