Bug 191478 - [maintainer update] security/ccrypt stagify and license
Summary: [maintainer update] security/ccrypt stagify and license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-29 13:23 UTC by Oliver Heesakkers
Modified: 2014-06-29 19:39 UTC (History)
2 users (show)

See Also:


Attachments
stagify and license ccrypt (1.18 KB, patch)
2014-06-29 13:23 UTC, Oliver Heesakkers
no flags Details | Diff
Revised patch (1.53 KB, patch)
2014-06-29 15:40 UTC, Oliver Heesakkers
dev2: maintainer-approval+
Details | Diff
Next revision (1.56 KB, patch)
2014-06-29 18:25 UTC, Oliver Heesakkers
dev2: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Heesakkers 2014-06-29 13:23:53 UTC
Created attachment 144245 [details]
stagify and license ccrypt

The attached patch stagifies ccrypt and also adds license information.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-29 15:03:43 UTC
I get an error here when building the patch with Poudriere:

===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
====>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}):
extra: usr/local/share/doc/ccrypt
Comment 2 Oliver Heesakkers 2014-06-29 15:40:38 UTC
Created attachment 144250 [details]
Revised patch

Right, ${STAGEDIR} before ${DOCSDIR}, revised patch attached.
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-29 16:54:14 UTC
Different error now :)

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/README
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccrypt.html
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/cypfaq01.txt
Error: Orphaned: %%PORTDOCS%%@dirrmtry %%DOCSDIR%%
Comment 4 Oliver Heesakkers 2014-06-29 18:25:04 UTC
Created attachment 144261 [details]
Next revision

I'm sure you saw what I did there, but for prosperity: I did a check-plist without the ${STAGEDIR} in place and I didn't bother doing check-plist again for the first revision.

So three times will have to be a charm. Meanwhile I'll dig up my redports credentials from my crashed server, so I can save myself these embarassements in the future.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-06-29 19:39:21 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jun 29 19:39:09 UTC 2014
New revision: 359790
URL: http://svnweb.freebsd.org/changeset/ports/359790

Log:
  - Support staging.
  - Add licensing information.

  PR:		191478
  Submitted by:	Oliver Heesakkers <dev2@heesakkers.info> (maintainer)

Changes:
  head/security/ccrypt/Makefile
  head/security/ccrypt/pkg-plist
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-06-29 19:39:33 UTC
Committed, thank you!