Created attachment 144916 [details] Update of graphics/poppler - Update to 0.26.3 (the latest stable release) - Add LICENSE_FILE - Adjust dependencies - Add new option, CURL - switch to USES= libtool tar:xz - Add Qt5 support Build log on RedPorts: https://redports.org/buildarchive/20140723173301-15852/
Created attachment 144917 [details] Update of graphics/poppler-glib - Don't install API documentation - Switch to USES= libtool
Created attachment 144918 [details] Update of graphics/poppler-qt4 - Switch to USES= libtool
Created attachment 144919 [details] Add graphics/poppler-qt5 - Add graphics/poppler-qt5 - Fix dependencies - Use ${MOC} variable, define in Mk/bsd.qt.mk (because moc utility is installed in ${LOCALBASE}/lib/qt5/bin/) Build log on RedPorts: https://redports.org/buildarchive/20140723174101-40357/
*** Bug 194992 has been marked as a duplicate of this bug. ***
(In reply to Olivier Duchateau from comment #4) > *** Bug 194992 has been marked as a duplicate of this bug. *** Hi Olivier, I didn't notice your patch has -qt5 port already. Could you merge some changes from my patch, particularly USE_QT5 list. Any plans to commit this soon?
Created attachment 149510 [details] Complete diff to update graphics/poppler and related ports New patch, to update graphics/poppler to 0.26.3 (and related ports) with Max's remark (regarding Qt5 support). In this new one, static libraries removed.
(In reply to Max Brazhnikov from comment #5) > (In reply to Olivier Duchateau from comment #4) > > *** Bug 194992 has been marked as a duplicate of this bug. *** > > Hi Olivier, > > I didn't notice your patch has -qt5 port already. Could you merge some > changes from my patch, particularly USE_QT5 list. Any plans to commit this > soon? These ports belong to kwm@.
(In reply to Olivier Duchateau from comment #7) > (In reply to Max Brazhnikov from comment #5) > > (In reply to Olivier Duchateau from comment #4) > > > *** Bug 194992 has been marked as a duplicate of this bug. *** > > > > Hi Olivier, > > > > I didn't notice your patch has -qt5 port already. Could you merge some > > changes from my patch, particularly USE_QT5 list. Any plans to commit this > > soon? > > These ports belong to kwm@. Koop, do you have time for this update? Olivier, have you tested all dependent ports? Do we need exp-run?
(In reply to Max Brazhnikov from comment #8) > (In reply to Olivier Duchateau from comment #7) > > (In reply to Max Brazhnikov from comment #5) > > > (In reply to Olivier Duchateau from comment #4) > > > > *** Bug 194992 has been marked as a duplicate of this bug. *** > > > > > > Hi Olivier, > > > > > > I didn't notice your patch has -qt5 port already. Could you merge some > > > changes from my patch, particularly USE_QT5 list. Any plans to commit this > > > soon? > > > > These ports belong to kwm@. > > Koop, do you have time for this update? > > Olivier, have you tested all dependent ports? Do we need exp-run? I use poppler-glib for a while, and I've not noticed any problems. Not tested Qt ports, just check if everything build fine. I think exp-run is needed, but feel free to ask.
Request exp-run.
Take
poppler-qt5 fails to build, it probably needs a patch similar to patch-qt4_src_Makefile.in: http://package18.nyi.freebsd.org/data/91amd64-default-PR192068/2014-11-20_00h12m46s/logs/errors/poppler-qt5-0.26.3.log
(In reply to Antoine Brodin from comment #13) > poppler-qt5 fails to build, it probably needs a patch similar to > patch-qt4_src_Makefile.in: > > http://package18.nyi.freebsd.org/data/91amd64-default-PR192068/2014-11- > 20_00h12m46s/logs/errors/poppler-qt5-0.26.3.log It's right, I forget to add patches in latest diff.
Created attachment 149647 [details] Full patch to upgrade graphics/poppler to 0.26.3
(In reply to Antoine Brodin from comment #13) > poppler-qt5 fails to build, it probably needs a patch similar to > patch-qt4_src_Makefile.in: > > http://package18.nyi.freebsd.org/data/91amd64-default-PR192068/2014-11- > 20_00h12m46s/logs/errors/poppler-qt5-0.26.3.log Is there any other problem?
Exp-run results on 91amd64: http://package18.nyi.freebsd.org/jail.html?mastername=91amd64-default-PR192068 No new failures Limited exp-run (only ports using poppler) results on 10.1 amd64: http://package18.nyi.freebsd.org/build.html?mastername=101amd64-default-PR192068&build=2014-11-20_20h05m47s No new failures I don't know if you want i386 too, it's probably not necessary if you tested the 5 ports already
(In reply to Antoine Brodin from comment #17) > Exp-run results on 91amd64: > http://package18.nyi.freebsd.org/jail.html?mastername=91amd64-default- > PR192068 > No new failures > > Limited exp-run (only ports using poppler) results on 10.1 amd64: > http://package18.nyi.freebsd.org/build.html?mastername=101amd64-default- > PR192068&build=2014-11-20_20h05m47s > No new failures Great! > > I don't know if you want i386 too, it's probably not necessary if you tested > the 5 ports already I believe testing on 9/10-amd64 is enough. Olivier, will you commit the update?
if you remove the bogus @dirrm in poppler-qt4/pkg-plist, it good.
(In reply to Max Brazhnikov from comment #18) > (In reply to Antoine Brodin from comment #17) > > Exp-run results on 91amd64: > > http://package18.nyi.freebsd.org/jail.html?mastername=91amd64-default- > > PR192068 > > No new failures > > > > Limited exp-run (only ports using poppler) results on 10.1 amd64: > > http://package18.nyi.freebsd.org/build.html?mastername=101amd64-default- > > PR192068&build=2014-11-20_20h05m47s > > No new failures > > Great! > > > > > I don't know if you want i386 too, it's probably not necessary if you tested > > the 5 ports already > > I believe testing on 9/10-amd64 is enough. > > Olivier, will you commit the update? No (I would like to update some ports, now GNOME3 is present), you can or let Koop do it.
If makc doesn't do it I will tackle it after I'm done with gstreamer.
makc, do you want to do it?
(In reply to Antoine Brodin from comment #22) > makc, do you want to do it? I've already promised kwm to finish it.
Committed. Thanks all!