Bug 192091 - net/libbgpdump: fix binary garbage at the end of output
Summary: net/libbgpdump: fix binary garbage at the end of output
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: mjl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-24 13:12 UTC by Anton Yuzhaninov
Modified: 2014-07-25 03:52 UTC (History)
1 user (show)

See Also:


Attachments
Fix for issue 12 (349 bytes, patch)
2014-07-24 13:12 UTC, Anton Yuzhaninov
no flags Details | Diff
incorporate submitter's patch, bump port revision (977 bytes, patch)
2014-07-24 21:17 UTC, mjl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Yuzhaninov 2014-07-24 13:12:04 UTC
Created attachment 144940 [details]
Fix for issue 12

There is a bug in bgpdump:
https://bitbucket.org/ripencc/bgpdump/issue/12/binary-garbage-at-the-end-of-output

And the bug is not fixed by upstream for a long time.

Please add this patch to port.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-24 20:54:29 UTC
can you have a look at this patch ?
Comment 2 mjl 2014-07-24 21:17:30 UTC
Created attachment 144945 [details]
incorporate submitter's patch, bump port revision
Comment 3 mjl 2014-07-24 21:18:14 UTC
Kurt, approved, please commit.  Submitter, if you have other patches you'd like to see applied to bgpdump then I'm happy to review and incorporate them.
Comment 4 mjl 2014-07-24 21:20:24 UTC
Oh, for the audit trail, I checked the output of bgpdump -m for http://data.ris.ripe.net/rrc00/2001.06/bview.20010624.1611.gz with and without the patch and can confirm the observation in the bitbucket url.  I time'd bgpdump and it made zero difference in run time (wall, user, sys).
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-25 03:50:33 UTC
A commit references this bug:

Author: pi
Date: Fri Jul 25 03:50:02 UTC 2014
New revision: 362865
URL: http://svnweb.freebsd.org/changeset/ports/362865

Log:
  net/libbgpdump: add patch from bitbucket

  https://bitbucket.org/ripencc/bgpdump/issue/12/binary-garbage-at-the-end-of-output

  PR:		192091
  Submitted by:	citrin+pr@citrin.ru
  Approved by:	mjl@luckie.org.nz (maintainer)

Changes:
  head/net/libbgpdump/Makefile
  head/net/libbgpdump/files/
  head/net/libbgpdump/files/patch-bgpdump.c
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-25 03:52:30 UTC
Committed, thanks.

And sorry for the drive-by-commit for the bitbucket url, but the list of
issues is very useful. RIPE lost contact with the software, it seems.