Bug 192129 - [patch] textproc/p5-xmltv: Fix missing dependancy
Summary: [patch] textproc/p5-xmltv: Fix missing dependancy
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-26 08:34 UTC by dreamcat4
Modified: 2014-07-27 10:36 UTC (History)
2 users (show)

See Also:

Attachments
svn diff (923 bytes, patch)
2014-07-26 08:34 UTC, dreamcat4 		no flags Details | Diff
fix dependancy p5-Slurp --> p5-File-Slurp (933 bytes, patch)
2014-07-26 13:26 UTC, dreamcat4 		dreamcat4: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dreamcat4 2014-07-26 08:34:32 UTC 
Created attachment 144994 [details]
svn diff

This dependancy (p5-Slurp) was found to be missing. It is needed for at least the included grabber 'tv_grab_uk_rt'. And perhaps some of the other grabbers (don't know).

Anyway the 'tv_grab_uk_rt' is the one needed for UK. So please include the necessary dependancy. Many thanks.

SVN diff included.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-26 09:57:36 UTC 
over to group maintainer
Comment 2 dreamcat4 2014-07-26 12:27:26 UTC 
Ah wait, it seems to have a problem because:

* The dependancy i put was 'p5-Slurp', which installs "Slurp.pm" into this folder:

ls /usr/local/lib/perl5/site_perl/5.16/Slurp.pm
/usr/local/lib/perl5/site_perl/5.16/Slurp.pm

But the program 'tv_grab_uk_rt' is looking for it in this folder:

ls /usr/local/lib/perl5/site_perl/5.16/File/
./             ../            GlobMapper.pm  Listing.pm


tv_grab_uk_rt --configure
Can't locate File/Slurp.pm in @INC (@INC contains: /usr/local/lib/perl5/5.16/BSDPAN /usr/local/lib/perl5/site_perl/5.16/mach /usr/local/lib/perl5/site_perl/5.16 /usr/local/lib/perl5/5.16/mach /usr/local/lib/perl5/5.16 .) at /usr/local/lib/perl5/site_perl/5.16/XMLTV/Supplement.pm line 16.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.16/XMLTV/Supplement.pm line 16.
Compilation failed in require at /usr/local/bin/tv_grab_uk_rt line 11.
BEGIN failed--compilation aborted at /usr/local/bin/tv_grab_uk_rt line 11.


I am not sure why this difference, not being a Perl expert or anything. However it worked from CPAN to install to the correct location like this:

cpan
yes
<return>
yes
install File::Slurp
exit


So probably this dependancy aught to be 'p5-File-Slurp' instead of 'p5-Slurp'. I will test it again. If ok then upload some new patch with the correction.
Comment 3 dreamcat4 2014-07-26 13:26:41 UTC 
Created attachment 144999 [details]
fix dependancy p5-Slurp --> p5-File-Slurp

svn diff updated to v2.

OK. I tested again new build from scratch. This time it works.
Please take as final patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-07-27 10:31:30 UTC 
A commit references this bug:

Author: riggs
Date: Sun Jul 27 10:30:37 UTC 2014
New revision: 363040
URL: http://svnweb.freebsd.org/changeset/ports/363040

Log:
  - Add missing dependency on devel/p5-File-Slurp
  - Add LICENSE
  - Bump PORTREVISION

  PR:		192129
  Submitted by:	dreamcat4@gmail.com
  Approved by:	mentors (implicit)

Changes:
  head/textproc/p5-xmltv/Makefile
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2014-07-27 10:36:59 UTC 
Committed, thanks!