Bug 192762 - [build] [patch] LIBCURSESW and LIBTERMCAPW are missing from bsd.libnames.mk
Summary: [build] [patch] LIBCURSESW and LIBTERMCAPW are missing from bsd.libnames.mk
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-17 18:45 UTC by Enji Cooper
Modified: 2014-10-23 00:44 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2014-08-17 18:45:39 UTC 
Many Makefiles reference wide-character support ncurses libraries in DPADD, but the variables aren't defined in bsd.libnames.mk.

The "patch" noted below fixes (mutes) a lot of make checkdpadd errors:

diff --git a/share/mk/bsd.libnames.mk b/share/mk/bsd.libnames.mk
index c7ad449..fa63163 100644
--- a/share/mk/bsd.libnames.mk
+++ b/share/mk/bsd.libnames.mk
@@ -39,6 +39,7 @@ LIBCRYPT?=    ${DESTDIR}${LIBDIR}/libcrypt.a
 LIBCRYPTO?=    ${DESTDIR}${LIBDIR}/libcrypto.a
 LIBCTF?=       ${DESTDIR}${LIBDIR}/libctf.a
 LIBCURSES?=    ${DESTDIR}${LIBDIR}/libcurses.a
+LIBCURSESW?=   ${DESTDIR}${LIBDIR}/libcursesw.a
 LIBDEVINFO?=   ${DESTDIR}${LIBDIR}/libdevinfo.a
 LIBDEVSTAT?=   ${DESTDIR}${LIBDIR}/libdevstat.a
 LIBDIALOG?=    ${DESTDIR}${LIBDIR}/libdialog.a
@@ -136,6 +137,7 @@ LIBSTAND?=  ${DESTDIR}${LIBDIR}/libstand.a
 LIBSTDCPLUSPLUS?= ${DESTDIR}${LIBDIR}/libstdc++.a
 LIBTACPLUS?=   ${DESTDIR}${LIBDIR}/libtacplus.a
 LIBTERMCAP?=   ${DESTDIR}${LIBDIR}/libtermcap.a
+LIBTERMCAPW?=  ${DESTDIR}${LIBDIR}/libtermcapw.a
 LIBTERMLIB?=   "don't use LIBTERMLIB, use LIBTERMCAP"
 LIBTINFO?=     "don't use LIBTINFO, use LIBNCURSES"
 LIBUFS?=       ${DESTDIR}${LIBDIR}/libufs.a
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-08-26 09:11:28 UTC 
A commit references this bug:

Author: ngie
Date: Tue Aug 26 09:10:29 UTC 2014
New revision: 270650
URL: http://svnweb.freebsd.org/changeset/base/270650

Log:
  Convert LIBCURSES to LIBNCURSES to fix "make checkdpadd"

  Also, add a missing LIBPANEL dependency for lldb

  Approved by: rpaulo (mentor)
  Suggested by: brooks
  MFC after: 5 days
  Phabric: D675 (as part of a larger diff)
  PR: 192762

Changes:
  head/usr.bin/bc/Makefile
  head/usr.bin/clang/lldb/Makefile
  head/usr.bin/talk/Makefile
  head/usr.sbin/gstat/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-08-26 09:13:29 UTC 
A commit references this bug:

Author: ngie
Date: Tue Aug 26 09:12:41 UTC 2014
New revision: 270651
URL: http://svnweb.freebsd.org/changeset/base/270651

Log:
  Introduce missing definition for LIBTERMCAPW

  Some Makefiles expect this value to exist

  Approved by: rpaulo (mentor)
  MFC after: 5 days
  Phabric: D675 (as part of a larger diff)
  PR: 192762

Changes:
  head/share/mk/bsd.libnames.mk
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2014-09-02 05:59:25 UTC 
r270651 was not MFCed because other changes that use LIBTERMCAPW weren't MFCed by brooks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-23 00:41:06 UTC 
A commit references this bug:

Author: ngie
Date: Thu Oct 23 00:40:40 UTC 2014
New revision: 273497
URL: https://svnweb.freebsd.org/changeset/base/273497

Log:
  MFC r270650:

    Convert LIBCURSES to LIBNCURSES to fix "make checkdpadd"

    Also, add a missing LIBPANEL dependency for lldb

    Approved by: rpaulo (mentor)
    Suggested by: brooks
    Phabric: D675 (as part of a larger diff)
    PR: 192762

Changes:
_U  stable/10/
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-10-23 00:44:07 UTC 
A commit references this bug:

Author: ngie
Date: Thu Oct 23 00:43:09 UTC 2014
New revision: 273499
URL: https://svnweb.freebsd.org/changeset/base/273499

Log:
  MFC r270650 (this is what should have been committed in r273497):

    Convert LIBCURSES to LIBNCURSES to fix "make checkdpadd"

    Also, add a missing LIBPANEL dependency for lldb

    Approved by: rpaulo (mentor)
    Suggested by: brooks
    Phabric: D675 (as part of a larger diff)
    PR: 192762

Changes:
  stable/10/usr.bin/bc/Makefile
  stable/10/usr.bin/clang/lldb/Makefile
  stable/10/usr.bin/talk/Makefile
  stable/10/usr.sbin/gstat/Makefile