This port is currently broken -- has no viable source location, and is UN STAGED. Apparently hasn't had a maintainer for some time, either. This is a request for maintainership of this port, and hosting of it's source (which I posses). If this request is approved. I can submit a svn diff with all the necessary changes, as well as the redports.org logs. Thank you for all your time, and considersaion. --Chris
If you submit a patch that: - stages it - changes the master site - sets you as maintainer It will be approved. Don't forget to post a link to the redports logs.
moving to open status (out of triage)
Created attachment 146119 [details] [maintainer] STAGED, PATCH, SVN DIFF Here it all is, as requested, John. Modified all but pkg-plist Adds STAGE works on all CURRENT FreeBSD releases (8.4 - 11). Tested locally, as well as @ redports.org Please find attached, an svn diff. redports logs: 8.4 https://redports.org/~portmaster/20140821173417-78999-236150/pr-1.1.log 9.2 https://redports.org/~portmaster/20140821173417-78999-236149/pr-1.1.log 10.0 https://redports.org/~portmaster/20140821173417-78999-236148/pr-1.1.log 11 https://redports.org/~portmaster/20140821173417-78999-236147/pr-1.1.log Thanks, for all your time, and dedication, John! --Chris
In my 10-second review, I only spotted one set of things I'd change (besides the USES= not be 2-tabbed) +do-install: +.for P in ${PROGRAMS} + ${CP} ${WRKSRC}/sbin/$P ${STAGEDIR}${PREFIX}/sbin +.endfor +.for C in ${ETCFILES} + ${CP} ${WRKSRC}/etc/$C ${STAGEDIR}${PREFIX}/etc +.endfor +.for R in ${RCDFILES} + ${CP} ${WRKSRC}/etc/rc.d/$R ${STAGEDIR}${PREFIX}/etc/rc.d +.endfor + +.for D in ${DOCFILES} + @${MKDIR} ${STAGEDIR}${DOCSDIR} + ${INSTALL_DATA} ${WRKSRC}/share/doc/pr/$D ${STAGEDIR}${DOCSDIR} +.endfor problem 1) You use $CP instead of $INSTALL_ macros problen 2) See the top 3 loops? The don't need to exist at all. For example, the first one should be: (cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX} problem 3) you create the DOCSDIR directory once per file. It's inside the loop!! and you don't need a loop either (see problem 2) You need to check ${PORT_OPTIONS:MDOC} also, portlint did not complain about ${CP}? or you didn't run portlint?
the should be a closing ")" on the problem 2 example btw.
(In reply to John Marino from comment #5) > the should be a closing ")" on the problem 2 example btw. You're merciless, John! I _did_ say it was a mess in the Makefile comment. Or did you miss that. :) portlint on my box said nadda. I don't see the missing paren. Are you _sure_ you're reading that right? P.S. I _do_ appreciate your critique. :) --Chris
I posted this as an example: "(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX}" it should have been: "(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX})" The missing ")" pertains to the end of my example, that's all.
(In reply to John Marino from comment #7) > I posted this as an example: > "(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX}" > > it should have been: > "(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX})" > > The missing ")" pertains to the end of my example, that's all. Ahh. OK. For the record, that's the direction I initially attempted. But ${INSTALL_PROGRAM} insists on using strip(1). Which fails, because the sbin/$files are simply scripts, not bin(ary). Thanks again, John. --Chris
Created attachment 146131 [details] UPDATES [maintainer] STAGED LICENSE SVN DIFF OK. This is as good as it gets. All incantations of your proposed install loop(s) failed. I'm not sure if you had a chance to examine the source itself. But it's a pure copy operation. No bin(aries), or lib's involved. Anyhow. I've made a couple of the other corrections regarding your "nit's" with this, and added a LICENSE, as well. I can imagine no reason for not letting this through. It passes with flying colors. See attached svn diff, for details. BTW ${CP} is completely valid, and provided in bsd.port.mk. Which I think is why no ALARM's were set off. :) I'm going to make a "proper" dev box, running on 11, now. So kindly mark this fixed. :) The following, are for your "magnifying glass". :) https://redports.org/~portmaster/20140821213600-1345-236245/pr-1.1.log https://redports.org/~portmaster/20140821213600-1345-236244/pr-1.1.log https://redports.org/~portmaster/20140821213600-1345-236243/pr-1.1.log https://redports.org/~portmaster/20140821213600-1345-236242/pr-1.1.log All the best to you, John. --Chris
(In reply to C Hutchinson from comment #9) > Created attachment 146131 [details] > UPDATES [maintainer] STAGED LICENSE SVN DIFF > > OK. This is as good as it gets. Then we have a problem. > All incantations of your proposed install loop(s) failed. Then it wasn't implemented correctly. I do this all the time. And I convert loops to single commands all the time. It works. > I'm not sure if you had a chance to examine the source itself. > But it's a pure copy operation. No bin(aries), or lib's > involved. > Anyhow. I've made a couple of the other corrections regarding > your "nit's" with this, and added a LICENSE, as well. I can > imagine no reason for not letting this through. It passes with > flying colors. > > See attached svn diff, for details. > > BTW ${CP} is completely valid, and provided in bsd.port.mk. > Which I think is why no ALARM's were set off. :) No, ${CP} is not valid. You are supposed to use INSTALL_PROGRAM, INSTALL_MAN, INSTALL_SCRIPT, INSTALL_DATA macros, never CP. Those macros do more than copy, they control permissions, ownership, and stripping. > > I'm going to make a "proper" dev box, running on 11, now. > So kindly mark this fixed. :) I can't. While the loops could be let go because they do the same thing more inefficiently, the CP issue is a dealbreaker. Attempting to create a DOCDIR directory each time a file is installed is a dealbreaker. Not using PORT_OPTIONS:MDOCS or equivalent is a dealbreaker. so I can accept this is the best it's going to get. I could fix all of that in < 5 minutes. > > The following, are for your "magnifying glass". :) those problems aren't going to show in redports
(In reply to John Marino from comment #10) > (In reply to C Hutchinson from comment #9) > > Created attachment 146131 [details] > > UPDATES [maintainer] STAGED LICENSE SVN DIFF > > > > OK. This is as good as it gets. > > Then we have a problem. OK. I'm following... > > > All incantations of your proposed install loop(s) failed. > > Then it wasn't implemented correctly. I do this all the time. And I > convert loops to single commands all the time. It works. So do I. But I'm not finding the right incantation, I guess. > > > I'm not sure if you had a chance to examine the source itself. > > But it's a pure copy operation. No bin(aries), or lib's > > involved. > > Anyhow. I've made a couple of the other corrections regarding > > your "nit's" with this, and added a LICENSE, as well. I can > > imagine no reason for not letting this through. It passes with > > flying colors. > > > > See attached svn diff, for details. > > > > BTW ${CP} is completely valid, and provided in bsd.port.mk. > > Which I think is why no ALARM's were set off. :) > > No, ${CP} is not valid. You are supposed to use INSTALL_PROGRAM, > INSTALL_MAN, INSTALL_SCRIPT, INSTALL_DATA macros, never CP. Those macros do > more than copy, they control permissions, ownership, and stripping. OK INSTALL_PROGRAM won't work for simple script copies. It _tries_ but insists on strip(1)ing them. So that's out. INSTALL_MAN is quite nice. I've used it before, and it's simple as one could hope for. But doesn't apply here. INSTALL_SCRIPT looked like a real winner. But [for reasons yet to be discovered] it failed (while attempting to use your suggestion). I'm _sure_ it's correct for the ${PREFIX}/sbin files. But I guess I'll to work out some other way to use it. INSTALL_DATA is also the perfect choice for ${PREFIX}/etc && ${PREFIX}etc/rd.d. But again, see: INSTALL_SCRIPT. > > > > > > > I'm going to make a "proper" dev box, running on 11, now. > > So kindly mark this fixed. :) > > > I can't. > While the loops could be let go because they do the same thing more > inefficiently, the CP issue is a dealbreaker. > > Attempting to create a DOCDIR directory each time a file is installed is a > dealbreaker. Not using PORT_OPTIONS:MDOCS or equivalent is a dealbreaker. OK. While I whole heartedly agree, when talking more than one doc file. But we're not. It's one simple html file. As to PORT_OPTIONS:MDOCS. I've used it. I get it. It works great. But I'm not making it an option. It still matters? > > so I can accept this is the best it's going to get. I could fix all of that > in < 5 minutes. That's why you're @freebsd, and I'm simply @. :) P.S. ${CP} is in bsd.port.mk. Which is where I got the hint. I found it was used hundreds of times, in ports, in the ports tree. So while I absolutely comply with your wishes. We will have to agree to disagree on the use of ${CP}. :P OK. I'm grumpy about it. But I understand. So I'll get back on it. It's just that I really had my hopes up to create that new "dev box". :( Thanks for your critique, John. Even if it's not what I wanted to hear. :) --Chris > > > > > > The following, are for your "magnifying glass". :) > > those problems aren't going to show in redports
(In reply to C Hutchinson from comment #11) > (In reply to John Marino from comment #10) > > (In reply to C Hutchinson from comment #9) > > > Created attachment 146131 [details] > > > UPDATES [maintainer] STAGED LICENSE SVN DIFF > > > > > > OK. This is as good as it gets. > > > > Then we have a problem. ... > Thanks for your critique, John. Even if it's not what I wanted > to hear. :) > > --Chris > > > > > > > > > > > The following, are for your "magnifying glass". :) > > > > those problems aren't going to show in redports Well. I'm stumped. Using your example verbatim, and in every other possible variance, the build fails with: "Makefile", line 33: Missing dependency operator for all three lines (33, 34, 35). I've also copied blocks that use your same technique, out of other ports. But same results. I've also used examples out of the porters handbook. Same results. Altho, you will probably be happy to know I've changed the DOC install block to something you'd probably approve of: .if !defined(NOPORTDOCS) @${MKDIR} ${STAGEDIR}${DOCSDIR} cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} .endif There are no problems with that, at least. But that's all that works. FWIW I tried this, and several variations: (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX}) I had to use INSTALL_SCRIPT to avoid strip(1) being called against ${PROGRAMS}. Which are simply Perl scripts. I used: (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFILES} ${STAGEDIR}${PREFIX}) for the .conf, and rc(8) files. But same results. OH well. Thanks for all your time, and consideration, John. --Chris
(In reply to C Hutchinson from comment #12) > Well. I'm stumped. > Using your example verbatim, and in every other possible variance, > the build fails with: > > "Makefile", line 33: Missing dependency operator attach your working version of the makefile so I can see it (not shar, just upload it as it is) > > for all three lines (33, 34, 35). > I've also copied blocks that use your same technique, out of other > ports. But same results. I've also used examples out of the porters > handbook. Same results. Altho, you will probably be happy to know > I've changed the DOC install block to something you'd probably > approve of: > > .if !defined(NOPORTDOCS) > @${MKDIR} ${STAGEDIR}${DOCSDIR} > cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} > .endif unfortunately NOPORTDOCS is deprecated. portlint should complain. Just define OPTIONS_DEFINE=DOCS and use PORT_OPTIONS:MDOCS, there a thousand examples in ports > > There are no problems with that, at least. But that's all that > works. > > FWIW I tried this, and several variations: > > (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX}) > > I had to use INSTALL_SCRIPT to avoid strip(1) being called against > ${PROGRAMS}. Which are simply Perl scripts. INSTALL_SCRIPT is correct in this case > > I used: > > (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFILES} ${STAGEDIR}${PREFIX}) > > for the .conf, and rc(8) files. But same results. > OH well. I suspect the error message you get isn't for these lines, but something else. I don't see anything wrong them them.
(In reply to John Marino from comment #13) > (In reply to C Hutchinson from comment #12) > > Well. I'm stumped. > > Using your example verbatim, and in every other possible variance, > > the build fails with: > > > > "Makefile", line 33: Missing dependency operator > > attach your working version of the makefile so I can see it (not shar, just > upload it as it is) > > > > > > for all three lines (33, 34, 35). > > I've also copied blocks that use your same technique, out of other > > ports. But same results. I've also used examples out of the porters > > handbook. Same results. Altho, you will probably be happy to know > > I've changed the DOC install block to something you'd probably > > approve of: > > > > .if !defined(NOPORTDOCS) > > @${MKDIR} ${STAGEDIR}${DOCSDIR} > > cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} > > .endif > > > > unfortunately NOPORTDOCS is deprecated. portlint should complain. > Just define OPTIONS_DEFINE=DOCS and use PORT_OPTIONS:MDOCS, there a thousand > examples in ports Yep, and a couple of them are mine. :) > > > > > > There are no problems with that, at least. But that's all that > > works. > > > > FWIW I tried this, and several variations: > > > > (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX}) > > > > I had to use INSTALL_SCRIPT to avoid strip(1) being called against > > ${PROGRAMS}. Which are simply Perl scripts. > > INSTALL_SCRIPT is correct in this case I also tried COPYTREE_BIN > > > > > > I used: > > > > (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFILES} ${STAGEDIR}${PREFIX}) > > > > for the .conf, and rc(8) files. But same results. > > OH well. > > I suspect the error message you get isn't for these lines, but something > else. I don't see anything wrong them them. Here goes... PORTNAME= pr PORTVERSION= 1.1 CATEGORIES= comms net MASTER_SITES= http://bsdforge.com/projects/source/comms/pr/ DISTNAME= pr-${PORTVERSION} MAINTAINER= portmaster@bsdforge.com COMMENT= Daemon that connects local terminal device to a terminal server LICENSE= ARTPERL10 USE_XZ= yes OPTIONS_DEFINE= DOCS DOCS= PR.html WRKSRC= ${WRKDIR}/${PORTNAME} PROGRAMS= PortRedirector PortTest ETCFLS= PortRedirector.conf.sample RCDFILES= pr.sh.sample NO_BUILD= YES # doesn't work do-install: (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX}) (cd ${WRKSRC}/etc/rc.d && ${INSTALL_DATA} ${RCDFILES} ${STAGEDIR}${PREFIX}) (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFLS} ${STAGEDIR}${PREFIX}) # does work .if ${PORT_OPTIONS:MDOCS} @${MKDIR} ${STAGEDIR}${DOCSDIR} cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} .endif .include <bsd.port.mk> Thanks for your reply, John. :) --Chris
(In reply to C Hutchinson from comment #14) > Here goes... > USE_XZ= yes This is obsolete, change it to "USES=tar:xz" > # doesn't work > do-install: > (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX}) > (cd ${WRKSRC}/etc/rc.d && ${INSTALL_DATA} ${RCDFILES} ${STAGEDIR}${PREFIX}) > (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFLS} ${STAGEDIR}${PREFIX}) Do you start each line with a "tab" character? It looks like a space character. Yes it matters. (I could tell if you uploaded the makefile instead of pasted it) > # does work > .if ${PORT_OPTIONS:MDOCS} > @${MKDIR} ${STAGEDIR}${DOCSDIR} > cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} > .endif This is fine. It's a bit unnecessary for a single file, but if a second file comes in the future, you're prepared.
Created attachment 146157 [details] test case (ignore) OK here it is, and YES, tabs DO matter. My bad. I've added tabs, and all that fails now, is the PORT_OPTIONS:MDOCS block. I'll modify it using what I usually use. I want the ability to add a plain text doc, as well. So the block is indeed a good choice. --Chris
add ".include <bsd.port.options.mk>" before do-install target. DOCS option should work then.
or, as an alternative change DOCS to PORTDOCS (everywhere except the OPTION name) and remove the .if PORT_OPTIONS:DOCS line completely (install the PORTDOCS unconditionally)
(In reply to John Marino from comment #18) > or, as an alternative > > change DOCS to PORTDOCS (everywhere except the OPTION name) > > and remove the .if PORT_OPTIONS:DOCS line completely (install the PORTDOCS > unconditionally) BRILLIANT advice, as always, John. Thank you _very_ much. I _greatly_ appreciate it. Everything works, as intended. I'll upload an svn diff of the changes in a couple of minutes. --Chris
Created attachment 146160 [details] comms/pr UPDATES [maintainer] STAGED LICENSE SVN DIFF OK. FINALLY, a port worth commiting. :) Here it is, in all it's glory. MODIFIES: Makefile distinfo pkg-descr ADDS: STAGING MAINTAINER MASTER_SITES Note: I left optional PROTDOCS commented for later use. It's currently not optional. Thanks again, John, for all your time, dedication, and help. --Chris
You don't understand how DOCS and PORTDOCS works. They should be enabled. It should install unconditionally. The staging mechanism will decide based on the state of the OPTION DOCS where or not to put it into the pkg-plist. This is why all references to %%PORTDOCS%% has to be removed from the pkg-plist too when it's used this way. It's the user that gets to decide if he wants docs. You've already basically got this 90% implemented, just finish it off. Read the second on in the porters handbook on PORTDOCS for more information.
(In reply to John Marino from comment #21) > You don't understand how DOCS and PORTDOCS works. > > They should be enabled. > It should install unconditionally. > The staging mechanism will decide based on the state of the OPTION DOCS > where or not to put it into the pkg-plist. > > This is why all references to %%PORTDOCS%% has to be removed from the > pkg-plist too when it's used this way. > > It's the user that gets to decide if he wants docs. > You've already basically got this 90% implemented, just finish it off. Read > the second on in the porters handbook on PORTDOCS for more information. Understood. I left it commented for later use, should I have more than one doc. So that I might make it optional. I guess I could just uncomment it. Given it'll still install it, anyway. Is that what you need? --Chris
yes, activate the DOCS options. I already said this, but REMOVE "#.include <bsd.port.options.mk>" With PORTDOCS defined, you don't need it. However, you do need to modify pkg-plist to remove %%PORTDOCS%% so I expect pkg-plist to have a diff to. and check it with "make check-plist", that should tell you if you got it right.
Created attachment 146164 [details] comms/pr UPDATES [maintainer] STAGED LICENSE SVN DIFF Alright. I uncommented the lines, and removed one completely. I also named the doc explicitly in the PORTDOC install block. All testing indicated this was the best set of choices. $ make check-plist don't know how to make check-plist. Stop With the choices indicated above. Modification of the current pkg-plist seemed to prove unnecessary. Hope you like it. :) --Chris
okay, that looks valid. try "make stage" and then "make check-plist" then. Hopefully it will do something.
(In reply to John Marino from comment #25) > okay, that looks valid. > > try "make stage" and then "make check-plist" then. Hopefully it will do > something. $ make stage ... ==> Staging for pr-1.1 ... $ make check-plist don't know how to make check-plist. Stop Hmm. Oh well. At least the stage process finished as expected/intended. Shall we call it a wrap? Thanks a million, John! --Chris
oh well? It means your system doesn't understand stage and it means this PR is 100% untested. Grep "check-plist" in Mk/bsd.stage.mk, it is obviously a target, so that fact that it doesn't recognize it is a big problem. Maybe not at the port level, but the entire tree level. You don't have "NO_STAGE=yes" in your make.conf do you? Or anything else that blocks it? How far away is your poudriere setup from coming online? why don't we just wait until you can test it?
(In reply to John Marino from comment #27) > oh well? > > It means your system doesn't understand stage and it means this PR is 100% > untested. > > Grep "check-plist" in Mk/bsd.stage.mk, it is obviously a target, so that > fact that it doesn't recognize it is a big problem. Maybe not at the port > level, but the entire tree level. > > You don't have "NO_STAGE=yes" in your make.conf do you? Or anything else > that blocks it? > > How far away is your poudriere setup from coming online? why don't we just > wait until you can test it? My bsd.stage.mk indicates February 2014. Was check-plist created later? No I have nothing that could possibly interfere with porting in make, or src.conf. The box stages as one would anticipate. In fact, it _insists_ on it. I'll be building the 11 box, once I finish here. I hate leaving things unresolved. Too many "loose ends". I'll be rescuing _many_ ports, once I finish the new box (Saturday, or Sunday). That should prove a good enough "test bed". Don't you think? --Chris
There are over 50 PRs in the queue, even if I moved this to patch-ready, nothing would happen for a while, so 1-2 days delay isn't going to make much of a difference and I'd sure feel better with a "pouriere testport" log.
(In reply to John Marino from comment #29) > There are over 50 PRs in the queue, even if I moved this to patch-ready, > nothing would happen for a while, so 1-2 days delay isn't going to make much > of a difference and I'd sure feel better with a "pouriere testport" log. Yea. Sure. I guess. Why not. Speaking of test logs. I don't suppose the foundation has enough hardware on hand to rig up a couple more Pointy Hats. That the ports tree could be run against. Sure the users provide feedback, and all. But I've got ~24 ports in my own queue, and given what I'm having to do, in order to even get them close to "stable". Let's me know that there's a lot of room for improvement. It'd be kind of like RedPorts is now. It'd send failure reports to the maintainer. Much the same as PointHat does with Base builds. Seems a valuable resource. Both to the maintainers, and it's users. But even more so to FreeBSD itself. Because of the reputation it would get, not only for the quality of it's OS, but for the ports it provides, as well. Wish I had more hardware on hand. I'd do it myself. Well. Off to build that shiny new 11 dev box. :) Thanks for all your time, and help, John. Have a great weekend. --Chris
OK. The results are in... Either it, or I should be committed -- you decide. /usr/ports/comms/pr 12:07pm Tue, 26 devbox# make stage ===> License ARTPERL10 accepted by the user ===> Found saved configuration for pr-1.1 ===> pr-1.1 depends on file: /usr/local/sbin/pkg - found ===> Fetching all distfiles required by pr-1.1 for building ===> Extracting for pr-1.1 => SHA256 Checksum OK for pr-1.1.tar.xz. ===> Patching for pr-1.1 ===> Configuring for pr-1.1 ===> Staging for pr-1.1 ===> Generating temporary packing list (cd /usr/ports/comms/pr/work/pr/sbin && install -o root -g wheel -m 555 PortRedirector PortTest /usr/ports/comms/pr/work/stage/usr/local/sbin) (cd /usr/ports/comms/pr/work/pr/etc/rc.d && install -o root -g wheel -m 444 pr.sh.sample /usr/ports/comms/pr/work/stage/usr/local/etc/rc.d) (cd /usr/ports/comms/pr/work/pr/etc && install -o root -g wheel -m 444 PortRedirector.conf.sample /usr/ports/comms/pr/work/stage/usr/local/etc) install -o root -g wheel -m 444 /usr/ports/comms/pr/work/pr/share/doc/pr/PR.html /usr/ports/comms/pr/work/stage/usr/local/share/doc/pr ====> Compressing man pages (compress-man) /usr/ports/comms/pr 12:07pm Tue, 26 devbox# make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) /usr/ports/comms/pr 12:07pm Tue, 26 devbox# This is from the last svn diff I submitted. Anything else? Thanks, John. For all your time, and trouble. --Chris
Created attachment 146711 [details] comms/pr [request for maintainer] MASTER_SITES STAGE svn diff test logs comms/pr This patch obsoletes my previously not-well-tested patch. This patch reqests MAINTAINER replaces MASTER_SITES adds STAGE makes necessary corrections to pass following tests output also attached) make check-plist make stage-qa make check-sanity portlint See also comms-pr-test-output (attached) Thank you for all your time, and consideration. --Chris
Created attachment 146712 [details] comms/pr output logs from requisite tests comms/pr This attachment contains the output from requisite tests against the most recent patch (2014-09-02.diff), also attached. Thank you for all your time, and consideration. --Chris
Now it's tested at an adequate level. Moving to patch-ready.
(In reply to John Marino from comment #34) > Now it's tested at an adequate level. Moving to patch-ready. WhooHoo! Imagine that! I _finally_ did something right! What a door knob I can be sometimes. :P Thanks, John. --Chris
A commit references this bug: Author: marino Date: Sat Sep 6 17:36:35 UTC 2014 New revision: 367459 URL: http://svnweb.freebsd.org/changeset/ports/367459 Log: Stage comms/pr and assign maintainership to submitter The source files were no longer available, so the submitter is also hosting those. PR: 192878 Submitted by: Chris Hutchinson Changes: head/comms/pr/Makefile head/comms/pr/distinfo head/comms/pr/pkg-descr
Thanks, committed. Tweaks I made: 1) You removed the original "Created by" and replaced it with your name, thus rewriting history (and taking undue credit). this line was ignored 2) You should have bumped PORTREVISION for multiple reasons. I did that 3) I re-arranged a bunch of new lines. Options goes as low as possible conventionally, the other lines did not need to be separated by blank lines in most cases. 4) I wrapped at 80 columns
(In reply to John Marino from comment #37) > Thanks, committed. > > Tweaks I made: > 1) You removed the original "Created by" and replaced it with your name, > thus rewriting history (and taking undue credit). this line was ignored > 2) You should have bumped PORTREVISION for multiple reasons. I did that > 3) I re-arranged a bunch of new lines. Options goes as low as possible > conventionally, the other lines did not need to be separated by blank lines > in most cases. > 4) I wrapped at 80 columns Thanks, John! All points, duely noted! :) --Chris