Bug 193704 - pw: group disappeared during update
Summary: pw: group disappeared during update
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.0-RELEASE
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-17 10:28 UTC by Andrej Zverev
Modified: 2015-07-08 18:17 UTC (History)
0 users

See Also:
bugmeister: mfc-stable10?
bugmeister: mfc-stable9?
bugmeister: mfc-stable8?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Zverev freebsd_committer freebsd_triage 2014-09-17 10:28:17 UTC
# pw groupadd test
# pw groupmod test -l newgroupname
pw: group disappeared during update

What does it mean?
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-10-28 11:21:02 UTC
A commit references this bug:

Author: bapt
Date: Tue Oct 28 11:20:31 UTC 2014
New revision: 273772
URL: https://svnweb.freebsd.org/changeset/base/273772

Log:
  When a group is renamed then the group has been invalidated for sure.
  In that case get the group information using the new name.

  Add a regression test about this bug

  PR:		193704
  Reported by:	az

Changes:
  head/usr.sbin/pw/pw_group.c
  head/usr.sbin/pw/tests/pw_modify.sh
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-11-04 07:51:44 UTC
A commit references this bug:

Author: bapt
Date: Tue Nov  4 07:50:51 UTC 2014
New revision: 274082
URL: https://svnweb.freebsd.org/changeset/base/274082

Log:
  MFC: 272445,272578,273772,273779,273782,273786,273787,273791

  Add a test for bug 191427 where pw(8) will go into an infinite loop
  Add some tests for modifying groups
  When a group is renamed then the group has been invalidated for sure.
  In that case get the group information using the new name.

  Fix a regression in pw usermod -G list

  The user was perperly adding the to different groups from "list" but was not
  removed from the other groups it could have belong to.

  Do not delete the group wheel when bad argument is passed to pw groupdel -g

  Check that the -g argument is actually a number, if not report an error.
  This argument is converted without checking with atoi(3) later so without this
  check it converts any alpha entries into 0 meaning it deletes the group wheel

  Ensure pw userdel -u <invalid> do not try to remove root

  Check the uid passed is actually a number as early as possible

  Fix renaming a group via the gr_copy function

  Add a regression test to pw(8) because the bug was discovered via using:
  pw groupmod

  PR:		193704 [1], 185666 [2], 90114 [3], 187189 [4]
  Submitted by:	Marc de la Gueronniere [4]
  Reported by:	az [1], sub.mesa@gmail.com [2], bkoenig@cs.tu-berlin.de [3],
  		mcdouga9@egr.msu.edu [4]

Changes:
_U  stable/10/
  stable/10/etc/mtree/BSD.tests.dist
  stable/10/lib/libutil/gr_util.c
  stable/10/usr.sbin/pw/Makefile
  stable/10/usr.sbin/pw/pw_group.c
  stable/10/usr.sbin/pw/pw_user.c
  stable/10/usr.sbin/pw/tests/
  stable/10/usr.sbin/pw/tests/Makefile
  stable/10/usr.sbin/pw/tests/pw_delete.sh
  stable/10/usr.sbin/pw/tests/pw_modify.sh
Comment 3 Glen Barber freebsd_committer freebsd_triage 2015-07-08 18:17:08 UTC
Close PRs that have had a corresponding fix committed.