Bug 194235 - [MAINTAINER UPDATE] [PATCH] astro/geographiclib: update to 1.38
Summary: [MAINTAINER UPDATE] [PATCH] astro/geographiclib: update to 1.38
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-08 04:36 UTC by Tatsuki Makino
Modified: 2014-10-14 19:01 UTC (History)
1 user (show)

See Also:

Attachments
patch for astro/geographiclib (9.78 KB, patch)
2014-10-08 04:36 UTC, Tatsuki Makino 		no flags Details | Diff
test logs (459.85 KB, text/plain)
2014-10-08 04:39 UTC, Tatsuki Makino 		no flags Details
patch for astro/geographiclib (7.67 KB, patch)
2014-10-13 12:04 UTC, Tatsuki Makino 		no flags Details | Diff
test log (options default) (93.04 KB, text/plain)
2014-10-13 12:14 UTC, Tatsuki Makino 		no flags Details
test log (all options enabled) (94.67 KB, text/plain)
2014-10-13 12:15 UTC, Tatsuki Makino 		no flags Details
test log (all options disabled) (91.10 KB, text/plain)
2014-10-13 12:17 UTC, Tatsuki Makino 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2014-10-08 04:36:30 UTC 
Created attachment 148086 [details]
patch for astro/geographiclib

Update to GeographicLib-1.38.

Add some options.
Comment 1 Tatsuki Makino 2014-10-08 04:39:30 UTC 
Created attachment 148087 [details]
test logs
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-08 18:57:07 UTC 
Not bad, but why are you creating a MANPAGES option?  There seems to be no dependencies pulled in for it, so you should be installing manpages unconditionally.

Secondly, why did you convert the log to a shar?  Just upload it as it is.

Please update the patch to remove the manpages option and just install them always.
Comment 3 Tatsuki Makino 2014-10-13 12:04:00 UTC 
Created attachment 148239 [details]
patch for astro/geographiclib

(In reply to John Marino from comment #2)
> Not bad, but why are you creating a MANPAGES option?  There seems to be no
> dependencies pulled in for it, so you should be installing manpages
> unconditionally.
> 
> Please update the patch to remove the manpages option and just install them
> always.

Options that control the install files are removed because it cannot control only changing SUBDIR. It needs more changes to source dependency of build targets. So, I'm not modify in this version. The system that doesn't need all files must be removed unnecessary files manually.
Comment 4 Tatsuki Makino 2014-10-13 12:14:02 UTC 
Created attachment 148240 [details]
test log (options default)

(In reply to John Marino from comment #2)
> Secondly, why did you convert the log to a shar?  Just upload it as it is.

Is bulk upload form provided?
If it existed already, I split them.
Comment 5 Tatsuki Makino 2014-10-13 12:15:29 UTC 
Created attachment 148241 [details]
test log (all options enabled)
Comment 6 Tatsuki Makino 2014-10-13 12:17:01 UTC 
Created attachment 148243 [details]
test log (all options disabled)
Comment 7 John Marino freebsd_committer freebsd_triage 2014-10-14 17:14:53 UTC 
Yes, just do what you did, upload one at a time.

This looks fine now, moving to patch-ready pool.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-14 19:01:53 UTC 
A commit references this bug:

Author: pawel
Date: Tue Oct 14 19:00:58 UTC 2014
New revision: 370880
URL: https://svnweb.freebsd.org/changeset/ports/370880

Log:
  - Update to version 1.38
  - Add options for additional datasets

  PR:		194235
  Submitted by:	maintainer

Changes:
  head/astro/geographiclib/Makefile
  head/astro/geographiclib/distinfo
  head/astro/geographiclib/pkg-plist