Bug 194302 - [documentation] Broken link in single html porters handbook
Summary: [documentation] Broken link in single html porters handbook
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Warren Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-11 17:19 UTC by Fernando Apesteguía
Modified: 2014-10-12 01:32 UTC (History)
1 user (show)

See Also:


Attachments
patch against documentation head svn branch (642 bytes, patch)
2014-10-11 17:19 UTC, Fernando Apesteguía
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer freebsd_triage 2014-10-11 17:19:39 UTC
Created attachment 148197 [details]
patch against documentation head svn branch

In the single html version of the porter's handbook, in the section 12.5

... The numeric version of the operating system; the same as __FreeBSD_version.

The __FreeBSD_version tag link does not work. It points to freebsd-version that does not exist. It should just point to "versions".

The splitted html version is not affected.

Attached patch to address the issue is provided. It applies cleanly to r45766.

Tested using both make and make FORMATS='html'

With the patch both versions (single and splitted html) work fine.
Comment 1 Warren Block freebsd_committer freebsd_triage 2014-10-11 21:30:44 UTC
The current document links work for me in Firefox 32.0.3, on both single and split HTML.  "freebsd-versions" is an ID for a title element, and not necessary.  But it would be nice to know what browser is having trouble with this.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2014-10-11 22:22:01 UTC
(In reply to Warren Block from comment #1)
> The current document links work for me in Firefox 32.0.3, on both single and
> split HTML.  "freebsd-versions" is an ID for a title element, and not
> necessary.  But it would be nice to know what browser is having trouble with
> this.

Sorry, I forgot to include that information :(

I'm running firefox 31.0 from binary repository on FreeBSD beastie 10.0-RELEASE-p7 FreeBSD 10.0-RELEASE-p7 #0: Tue Jul  8 06:37:44 UTC 2014     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-12 01:30:21 UTC
A commit references this bug:

Author: wblock
Date: Sun Oct 12 01:29:26 UTC 2014
New revision: 45794
URL: https://svnweb.freebsd.org/changeset/doc/45794

Log:
  Link to the versions chapter rather than the title ID.  Since the title
  ID is no longer needed, remove it.

  PR:		194302
  Submitted by:	fernando.apesteguia@gmail.com

Changes:
  head/en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
  head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml