Created attachment 148795 [details] patch for updating port - update 1.10 -> 1.15 Tested with portlint -AC. Just warns against non-empty $FreeBSD$ tag. Tested with poudriere (logs attached) at: - 10.0-amd64 - 9.3-amd64 - 8.4-amd64 During this testing, built-in tests were activated with pre-install: test construct in the port's Makefile.
Created attachment 148796 [details] log from poudriere at 10.0-amd64
Created attachment 148797 [details] log from poudriere at 9.3-amd64
Created attachment 148798 [details] log from poudriere at 8.4-amd64
Thanks for the test logs. I have real concerns about the changes to the pkg-plist though. Why are using @dir for those perl directories? @dir is only for creating empty directories or those outside of $PREFIX with absolute path (e.g. /var/run/something) Could this be a misunderstanding of what @dir is meant for?
Created attachment 148913 [details] patch for updating port
Created attachment 148914 [details] log from poudriere at 10.0-amd64
Created attachment 148915 [details] log from poudriere at 9.3-amd64
Created attachment 148916 [details] log from poudriere at 8.4-amd64
Please find attached a new fixed patch and new test logs. You are absolutely right. Thank you very much. Sorry about my previous ill contribution. Sure it is me who is solely responsible for the quality of submitted pkg-plist. But see how it happens: - "make makeplist" generates pkg-plist with wrong "@dir ..." lines, - "make check-plist" finds no pkg-plist issues, - "portlint -AC" ver 2.16.1 finds no pkg-plist issues, - poudriere testport ver 3.0.19 finds no pkg-plist issues After updating of the ports infrastructure on Nov 1, 2014, "make makeplist" generates much more wrong "@dir ..." lines than 2 days ago. Looks like at the moment people are actively working on support of "@dir ...". What would you recommend? Wait until it stabilizes by itself? Or submit a PRs against Mk infrastructure etc. right now?
the @dir structure is complete basically, use it now. Maybe some sanity checks were added. I know things like "make makeplist" (in particular) had to be updated and may need more work. But people *always* trusted make makeplist much more than should be allowed and were turning in garbage because they didn't manually edit it afterwards. Now you have to manually edit it even more. So as long as you understand that make makeplist gives you a bad product (and always has) and you must manually tweak it to be good, I think it will be okay.
I'm promoting this based on patch and poudriere logs.
A commit references this bug: Author: robak Date: Mon Nov 10 15:49:40 UTC 2014 New revision: 372401 URL: https://svnweb.freebsd.org/changeset/ports/372401 Log: devel/p5-Connector: update 1.10 -> 1.15 - Fix COMMENT PR: 194702 Submitted by: Sergei Vyshenski <svysh.fbsd@gmail.com> Approved by: mentors (implicit) Changes: head/devel/p5-Connector/Makefile head/devel/p5-Connector/distinfo head/devel/p5-Connector/pkg-plist
Committed, thanks for your work!