Bug 195065 - [multimedia/mplayer] Added USES+=iconv, cleaned up how iconv is handled
Summary: [multimedia/mplayer] Added USES+=iconv, cleaned up how iconv is handled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-16 06:48 UTC by Yuri Victorovich
Modified: 2014-11-16 17:27 UTC (History)
0 users

See Also:
yuri: maintainer-feedback? (riggs)

Attachments
patch (13.57 KB, patch)
2014-11-16 06:48 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2014-11-16 06:48:51 UTC 
Created attachment 149473 [details]
patch

mplayer uses iconv, but had no USES clause for it. I fixed this, and brought patch for -liconv closer to what https://www.freebsd.org/doc/en/books/porters-handbook/using-iconv.html recommends. (removed some hackish parts from configure script)

Please note that dependencies still use /usr/local/lib/libiconv.so so this one will probably be actually used anyway.

Additionally, ignored patch file files/patch-configure.orig should probably be deleted from the repository.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-16 06:48:51 UTC 
Auto-assigned to maintainer riggs@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-11-16 17:21:03 UTC 
A commit references this bug:

Author: riggs
Date: Sun Nov 16 17:20:33 UTC 2014
New revision: 372644
URL: https://svnweb.freebsd.org/changeset/ports/372644

Log:
  Correct iconv handling
  Bump PORTREVISION

  While on it:
  - Remove @dirrm(try) from pkg-plists

  PR:		195065
  Submitted by:	yuri@rawbw.com
  Reviewed by:	riggs

Changes:
  head/multimedia/mencoder/Makefile
  head/multimedia/mencoder/pkg-plist
  head/multimedia/mplayer/Makefile
  head/multimedia/mplayer/pkg-plist
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2014-11-16 17:27:30 UTC 
Committed a modified version of your patch. Thanks!
(The changes in patch-configure were not necessary.)