Bug 19510 - grap port update
Summary: grap port update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-06-26 04:50 UTC by faber
Modified: 2000-06-28 14:27 UTC (History)
0 users

See Also:


Attachments
file.diff (2.86 KB, patch)
2000-06-26 04:50 UTC, faber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description faber 2000-06-26 04:50:04 UTC
	port update grap 1.05 -> 1.10

Fix: Patch follows:
How-To-Repeat: 
	N/A
Comment 1 Will Andrews 2000-06-26 08:31:54 UTC
On Sun, Jun 25, 2000 at 08:41:59PM -0700, Ted Faber wrote:
> diff -ruN grap.bak/Makefile grap/Makefile
> --- grap.bak/Makefile	Sun Apr 30 15:13:18 2000
> +++ grap/Makefile	Sun Jun 25 20:34:26 2000
> @@ -1,18 +1,19 @@
>  # New ports collection makefile for:   grap
> -# Date created:        4 February 2000
> +# Version required:    1.10
> +# Date created:        25 Jun 2000
>  # Whom:                faber@lunabase.org

Don't do this.  This means don't re-add the "Version required" line or
change the "date created" line.

> -# $FreeBSD: ports/textproc/grap/Makefile,v 1.9 2000/04/30 19:31:06 steve Exp $
> +# $Id: Makefile,v 1.9 2000/06/26 03:25:58 faber Exp $

Don't do this either.  You can simply ``cvs diff -u'' against a FreeBSD
ports repository.

>  MAINTAINER=	faber@lunabase.org
> -
> -GNU_CONFIGURE=yes
> +HAS_CONFIGURE=	yes
> +GNU_CONFIGURE=	yes

You can't put all these strings together.  And GNU_CONFIGURE implies
HAS_CONFIGURE.  Read ports/Mk/bsd.port.mk.

> -You can learn more about grap as specified by Kernigan and Bentley at
> +You can learn more about grap as specified by Kernigan and Bentley at 

Whitespace changes are not cool.

>  WWW: http://www.lunabase.org/~faber/Vault/software/grap/
>  
>  -- Ted Faber
>  faber@lunabase.org
> +

Don't add extra lines at the end of pkg/DESCR.

Did you use (a reasonably up-to-date) portlint to check this port before
you submitted the diff?

-- 
Will Andrews <andrewsw@purdue.edu> <will@FreeBSD.org>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 2 faber 2000-06-27 03:00:38 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Content-Type: text/plain; charset=us-ascii


Sorry for the substandsrd diff.  I've used the same algorithm without
problem before.

Hopefully this one will be better.

diff -ruN grap.bak/Makefile grap/Makefile
- --- grap.bak/Makefile	Sun Apr 30 15:13:18 2000
+++ grap/Makefile	Mon Jun 26 18:54:46 2000
@@ -6,13 +6,12 @@
 #
 
 PORTNAME=	grap
- -PORTVERSION= 	1.05
- -CATEGORIES=	textproc graphics
+PORTVERSION=	1.10
+CATEGORIES=	textproc graphics 
 MASTER_SITES=	http://www.lunabase.org/~faber/Vault/software/grap/
 
 MAINTAINER=	faber@lunabase.org
- -
- -GNU_CONFIGURE=yes
+GNU_CONFIGURE=	yes
 
 MAN1=		grap.1
 
diff -ruN grap.bak/files/md5 grap/files/md5
- --- grap.bak/files/md5	Sun Apr 30 15:13:18 2000
+++ grap/files/md5	Sun Jun 25 20:34:26 2000
@@ -1 +1 @@
- -MD5 (grap-1.05.tar.gz) = 12ad99302ece30e2c53a934ac35c2c77
+MD5 (grap-1.10.tar.gz) = 7e61bf289d29c380859590d785ca7b1d
diff -ruN grap.bak/pkg/PLIST grap/pkg/PLIST
- --- grap.bak/pkg/PLIST	Tue Feb 22 15:20:00 2000
+++ grap/pkg/PLIST	Mon Jun 26 18:58:40 2000
@@ -20,5 +20,6 @@
 share/grap/examples/states3.d
 share/grap/examples/usapop.d
 share/grap/grap.defines
+share/grap/grap.tex.defines
 @dirrm share/grap/examples
 @dirrm share/grap


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (FreeBSD)
Comment: Exmh version 2.1.1 10/15/1999

iD8DBQE5WArGaUz3f+Zf+XsRAifgAJ9VBucPYb3xAqc6UjT9BBaGZE/AXgCfcBZJ
bB4/M6SadPN541ePeO1l7LE=
=ZXvD
-----END PGP SIGNATURE-----
Comment 3 alex freebsd_committer freebsd_triage 2000-06-28 14:25:48 UTC
State Changed
From-To: open->closed

Commited, thanks. 

However, next time, please: 

- Don't change $FreeBSD$ -> $Id$ 
- Do not add whitespaces to every point you could find 
- Do not change "Date created:" line. 

Also, GNU_CONFIGURE implies HAS_CONFIGURE.