rc bug: command_interpreter not set correctly, mailgraph can't start: changed to %%PERL%% to match shebang_fix I propose here some minor improvements: - add customizable $mailgraph_maillog - use $mailgraph_chdir instead of %%DATADIR%% in rc script where possible (this makes user able to change it without recompiling the port) - check readability of maillog before start as mailgraph process is lanched with '>/dev/null 2>&1', thus hidding errors HTH,
Auto-assigned to maintainer rafan@FreeBSD.org
Created attachment 150713 [details] proposed changes
*** Bug 196089 has been marked as a duplicate of this bug. ***
looks good. one question, do you want to take maintainership of this port? I am no longer an active user.
Created attachment 150798 [details] proposed changes + take maintainership Yes I may maintain it :)
A commit references this bug: Author: rafan Date: Sat Dec 20 13:25:58 UTC 2014 New revision: 375003 URL: https://svnweb.freebsd.org/changeset/ports/375003 Log: - rc script enhancements - pass maintainership - bump PORTREVISION PR: 196090 Submitted by: geoffroy desvernay <dgeo at centrale-marseille.fr> Changes: head/mail/mailgraph/files/mailgraph.in
A commit references this bug: Author: rafan Date: Sat Dec 20 13:27:05 UTC 2014 New revision: 375004 URL: https://svnweb.freebsd.org/changeset/ports/375004 Log: - rc script enhancements - pass maintainership - bump PORTREVISION PR: 196090 Submitted by: geoffroy desvernay <dgeo at centrale-marseille.fr> Changes: head/mail/mailgraph/Makefile
I've just upgraded mailgraph, but current rc script does not start correctly. I've made some changes which are correct (IMHO :-) ). Should I reopen this bug or make new one?
Created attachment 150922 [details] [patch] fix broken rc script after last commit variable wrapped in '' are not expanded and the following error is thrown during start. su: unknown login: $mailgraph_user MAILGRAPH CANNOT RUN: /var/log/maillog not readable by www /usr/local/etc/rc.d/mailgraph: WARNING: failed precmd routine for mailgraph
Open PR since last patch broke the RC script.
A commit references this bug: Author: ohauer Date: Thu Dec 25 13:44:01 UTC 2014 New revision: 375551 URL: https://svnweb.freebsd.org/changeset/ports/375551 Log: - fix broken rc script from last commit. (var do not expandinside singel quote, so the port failed to start) - bump PORTREVISION PR: 196090 (followup) Approved by: maintainer (implicit) Changes: head/mail/mailgraph/Makefile head/mail/mailgraph/files/mailgraph.in
I've committed the rc script patch, else the ports has to be marked as broken!
@ohauer: thank you ! And sorry for the wrong patch, not sufficiently tested :-/