Bug 196121 - textproc/topic: Update to 1.04
Summary: textproc/topic: Update to 1.04
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: easy, needs-qa, patch, patch-ready
Depends on: 195900 196058
Blocks:
  Show dependency treegraph
 
Reported: 2014-12-19 09:32 UTC by Michael Sanders
Modified: 2014-12-22 13:34 UTC (History)
0 users

See Also:


Attachments
Shar file for ports tree (1.66 KB, text/plain)
2014-12-19 09:32 UTC, Michael Sanders
koobs: maintainer-approval-
Details
unified diff (ugrades topic-1.03 to topic-1.04) (1.73 KB, patch)
2014-12-21 01:41 UTC, Michael Sanders
email: maintainer-approval+
Details | Diff
output of "make stage && make check-plist && make stage-qa && make package" (629 bytes, application/x-gzip)
2014-12-21 05:28 UTC, Michael Sanders
email: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Sanders 2014-12-19 09:32:02 UTC
Created attachment 150749 [details]
Shar file for ports tree

. final 1.04 update supersedes and replaces bug id 196058 and bug id 195900

. updated pkg-descr

. new build includes read/eval/print/loop

. misc documentation updates

. misc bug fixes and tweaks

. updated make file

. merged code base with builds for freebsd/android/windows

. bumped up version number
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-20 13:34:02 UTC
Can you attach this update as a unified diff please. Shell Archives (.shar) are only used for new ports.

Also:

* Attach successful build output (poudriere)
* Run the port through portlint and resolve any issues
* Use PLIST_FILES instead of pkg-plist (since it only contains two entries)
Comment 2 Michael Sanders 2014-12-21 01:41:35 UTC
Created attachment 150822 [details]
unified diff (ugrades topic-1.03 to topic-1.04)
Comment 3 Michael Sanders 2014-12-21 01:46:26 UTC
(In reply to Kubilay Kocak from comment #1)

> Can you attach this update as a unified diff please.

Yes sir, unified diff attached.

> * Attach successful build output (poudriere)

I do not have acess to poudriere or jails in this environment...

> * Run the port through portlint and resolve any issues

Okay, complete.

> * Use PLIST_FILES instead of pkg-plist (since it only contains two entries)

Okay complete.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-21 02:25:22 UTC
Thank you for the updated patch :)

In the absence of poudriere, please run:

make stage && make check-plist && make stage-qa && make package

Resolve any issues, and then attach the output once successful.

Bonus Points: 

Put DEVELOPER=yes in /etc/make.conf for extra QA
Comment 5 Michael Sanders 2014-12-21 05:28:16 UTC
Created attachment 150823 [details]
output of "make stage && make check-plist && make stage-qa && make package"

output is gzipped (attachments have a 1000kb limit)
Comment 6 Michael Sanders 2014-12-21 05:31:11 UTC
(In reply to Kubilay Kocak from comment #4)

> make stage && make check-plist && make stage-qa && make package

Yes sir, output attached.

> Resolve any issues, and then attach the output once successful.

No issues that I see.

> Bonus Points:
>
> Put DEVELOPER=yes in /etc/make.conf for extra QA

Yes sir, complete.

Many thanks Kubilay, for your excellent mentoring and help =)
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-22 04:32:57 UTC
A commit references this bug:

Author: koobs
Date: Mon Dec 22 04:32:08 UTC 2014
New revision: 375207
URL: https://svnweb.freebsd.org/changeset/ports/375207

Log:
  textproc/topic: Update to 1.04

  - Update to 1.04
  - Use PLIST_FILES, delete pkg-plist accordingly
  - Update pkg-descr

  PR:		196121
  Submitted by:	maintainer <email at freebsd hypermart net>

Changes:
  head/textproc/topic/Makefile
  head/textproc/topic/distinfo
  head/textproc/topic/pkg-descr
  head/textproc/topic/pkg-plist
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-22 04:34:24 UTC
Committed, thanks!

If you'd like your name credited in commit logs, please set your Full Name in your Bugzilla profile settings
Comment 9 Michael Sanders 2014-12-22 13:34:52 UTC
Thanks again for your help Kubilay, I appreciate it.