Created attachment 150813 [details] Remove USE_GCC knob from Makefile, add patch-clang into files/ The port currently insists on GCC without a really good reason. The attached patch makes the necessary fixes for the compile to succeed. On a related not, the upstream code has a suit of self-tests -- it may be worth the trouble to hook those up to the "regression-test" target. The attached patch does not do that.
Auto-assigned to maintainer amdmi3@FreeBSD.org
I'll deal with this after holidays, probably around Jan 7th. Meanwhile, it would be nice if you submit these changes upstream: https://github.com/DentonW/DevIL
*** Bug 205305 has been marked as a duplicate of this bug. ***
up
Created attachment 165389 [details] Add more patches from SF This update would incorporate all patches submitted over the last 6 years to the upstream through SourceForge. One of them fixes the upstream's configure to allow ILUT to be built with X11 disabled. The bundled rudimentary collection of self-tests is now reachable as the "regression-test" target (a.k.a. test- and check-target). I'd also like to turn Squish and Allegro back on -- even if only as options defaulting to off, but this update does not do that.
Up :D
(In reply to fcsk.aim from comment #6) > Up :D Could you confirm, that my latest patch works for you?
(In reply to Mikhail Teterin from comment #7) I use pkg. And as i can saw there's no changes :D
A commit references this bug: Author: mi Date: Tue Mar 1 00:49:29 UTC 2016 New revision: 409837 URL: https://svnweb.freebsd.org/changeset/ports/409837 Log: Make buildable with clang. While here, add patches submitted upstream by others. Also make use of the author's own self-test suit. PR: 196161 Approved by: maintainer timeout Changes: head/graphics/devil/Makefile head/graphics/devil/files/patch-41 head/graphics/devil/files/patch-42 head/graphics/devil/files/patch-43 head/graphics/devil/files/patch-46 head/graphics/devil/files/patch-47 head/graphics/devil/files/patch-49 head/graphics/devil/files/patch-50 head/graphics/devil/files/patch-51 head/graphics/devil/files/patch-52 head/graphics/devil/files/patch-clang head/graphics/devil/files/patch-testing head/graphics/devil/pkg-plist
This does not build on current. If that's not fixed soon I'll have to revert the change.
Please, post or provide a link to a build log showing the failure you are referring to. Thank you.
Sorry, but it's your responsibility to check that the port builds before committing, especially if you're committing to others' ports. You can build it in poudriere yourself. Or you can check pkg-fallout@.
Created attachment 167960 [details] Improve CXXFLAGS workaround clang37 and clang38 no longer allow -fgnu89-inline as part of CXXFLAGS. As devil engages in unsafe practice of populating from CFLAGS as is let's strip incompatible flags using GNU Make syntax. This leaves only -mgoo from GENERAL_CFLAGS as @IL_CFLAGS@ expands to an empty string. error: invalid argument '-fgnu89-inline' not allowed with 'C++/ObjC++' http://beefy3.nyi.freebsd.org/data/head-i386-default/p410591_s296480/logs/errors/devil-1.7.8_21,1.log
Comment on attachment 167960 [details] Improve CXXFLAGS workaround My build on 93i386, 93amd64, 101i386, 102amd64, head-i386 with default options went fine. Would it be acceptable to land the fix by stretching the timeout blanket (reset approval flag)? Mikhail, can you forward my change upstream to get feedback, maybe as part of bug212 like patch-clang? I don't have a SF account (signup issue via Tor), and CMakeLists.txt in the tree only supports Windows build.
A commit references this bug: Author: amdmi3 Date: Fri Mar 11 12:36:19 UTC 2016 New revision: 410826 URL: https://svnweb.freebsd.org/changeset/ports/410826 Log: - Fix build on 11.x [1] - Switch to USES=localbase - Switch to options helpers - Fix testing PR: 196161 Submitted by: jbeich [1] Changes: head/graphics/devil/Makefile head/graphics/devil/files/patch-clang