This patch adds hw.usb.wsp.one_finger_tap which allows toggling left clicking by tapping on the trackpad with a single finger. Setting it to 0 disables, setting it to >= 1 enables. I have not updated the wsp(4) man page yet, but will be doing so shortly. Environment: FreeBSD 10.1-RELEASE
Hi, Due to an issue with the backend FreeBSD Bugzilla database, your original PR and any updates to it since have been lost. I've recreated the original PR as best as I can, however any attachments and updates you submitted to the PR have been lost. Please could you resubmit them? Thanks, and apologies.
Created attachment 151509 [details] wsp.c one finger tap. One finger tap left-click for wsp.c. Resubmitting after Bugzilla maintenance issues.
Created attachment 151510 [details] wsp(4) updated to include details of one finger tap. wsp(4) man page with one finger tap details.
I did exactly the same thing under a different OID before seeing this :D Tested on 10.3-RELEASE
Hi, Is this issue fixed in 10-stable? Or is this patch still needed? --HPS
A quick look at the source for wsp.c on github suggests that the patch is still needed, however work on wsp.c since I submitted this patch means it won't apply cleanly anymore. If there is still interest in this feature, I should be able to clean up the .diff later on so that it once again apples to HEAD.
The patch still needs to be applied. None of the branches have this in wsp.c (or anything equivalent). wsp.c in STABLE is at the same commit as RELEASE. CURRENT has a couple of small changes that aren't for touch click.
Hi David I think your patch will still work, there's only one additional line and one line change on master, it should be able to figure out the displacement.
No I'm wrong... it fails, sorry. I can submit a new one based on the same changes later today if you like, I need it anyway.
I would be interested in this too if it can be bumped for 11 or 12.
Created attachment 179770 [details] wsp.c one finger tap One finger tap patch updated for 10.3
Created attachment 179771 [details] wsp.4 man page update Updated man page for 10.3.
This feature has now been updated for 10.3. I'll be looking at FreeBSD 11 shortly and providing a new patch if needed.
This feature had been committed (in a different form) as r314467. Hijacking this PR for MFC tracking, and wsp(4) should probably be updated in a similar fashion to the patch attached here to indicate the existence of this new sysctl.
A commit references this bug: Author: kevans Date: Mon Jan 15 21:53:33 UTC 2018 New revision: 328027 URL: https://svnweb.freebsd.org/changeset/base/328027 Log: wsp(4): Update to reflect new sysctl from r314467 r314467 introduced hw.usb.wsp.enable_single_tap_clicks to enable/disable single-tap left click behavior. Update the man page to reflect the new sysctl. PR: 196624 MFC after: 3 days X-MFC-With: r314467 Changes: head/share/man/man4/wsp.4
A commit references this bug: Author: kevans Date: Sat Jan 27 06:10:21 UTC 2018 New revision: 328460 URL: https://svnweb.freebsd.org/changeset/base/328460 Log: MFC r314467,r328027: Add hw.usb.wsp.enable_single_tap_clicks sysctl MFC r314467 (imp): Make wsp process a single touchpad tap and interpret it as a left-click event. It can be disabled by setting the new hw.usb.wsp.enable_single_tap_clicks sysctl to 0. MFC r328027: wsp(4): Update to reflect new sysctl from r314467 r314467 introduced hw.usb.wsp.enable_single_tap_clicks to enable/disable single-tap left click behavior. Update the man page to reflect the new sysctl. PR: 196624 Changes: _U stable/11/ stable/11/share/man/man4/wsp.4 stable/11/sys/dev/usb/input/wsp.c