Bug 19681 - patch to fix devel/libcoro
Summary: patch to fix devel/libcoro
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-07-03 21:10 UTC by kbyanc
Modified: 2000-07-04 11:26 UTC (History)
0 users

See Also:


Attachments
file.diff (2.42 KB, patch)
2000-07-03 21:10 UTC, kbyanc
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kbyanc 2000-07-03 21:10:00 UTC
	I erroniously tried to make libcoro into a shared library. While
	the tests bundled with the library passed, I have since been
	informed by the author that the library is position-independent
	unfriendly and that more ellaborate code will fail. Reverted back
	to static library (not a big deal, the library itself is just a
	few K).

	I left this as 'non-critical' since I doubt there is anyone using
	the port yet. On a related note, I'll be posting a follow-up patch
	to the still-open PR ports/19466 (which depends on libcoro).

	Thanks,

	Kelly
Comment 1 kbyanc 2000-07-03 21:39:40 UTC
  Alright, last patch, I promise :)
  This patch fixes the port so it doesn't strip the library when
installing it (very important). Just apply it after applying the patch
originally supplied in this PR. Thanks,

  Kelly

diff -ru libcoro.orig/patches/patch-ab libcoro/patches/patch-ab
--- libcoro.orig/patches/patch-ab	Mon Jul  3 13:31:14 2000
+++ libcoro/patches/patch-ab	Mon Jul  3 13:34:25 2000
@@ -1,6 +1,6 @@
---- arch/x86-freebsd/Makefile.in.orig	Mon Jul  3 12:52:20 2000
-+++ arch/x86-freebsd/Makefile.in	Mon Jul  3 12:53:50 2000
-@@ -1,10 +1,13 @@
+--- arch/x86-freebsd/Makefile.in.orig	Mon Jul  3 13:33:09 2000
++++ arch/x86-freebsd/Makefile.in	Mon Jul  3 13:33:55 2000
+@@ -1,10 +1,12 @@
 -CFLAGS=-O2 -Wall
 +CFLAGS?=-O2 -Wall
  
@@ -9,20 +9,19 @@
  HINST=@HINST@
  MINST=@MINST@
  
-+BSD_INSTALL_PROGRAM?=install -C -m 644
 +BSD_INSTALL_DATA?=install -C -m 644
 +
  all: libcoro.a
  
  libcoro.a: coro.o
-@@ -14,9 +17,9 @@
+@@ -14,9 +16,9 @@
  coro.o: coro.h
  
  install: libcoro.a coro.h $(MAN)
 -	install -m 644 libcoro.a $(LINST)/libcoro.a
 -	install -m 644 coro.h $(HINST)/coro.h
 -	install -m 644 $(MAN) $(MINST)/man2/coro.2
-+	$(BSD_INSTALL_PROGRAM) libcoro.a $(LINST)/libcoro.a
++	$(BSD_INSTALL_DATA) libcoro.a $(LINST)/libcoro.a
 +	$(BSD_INSTALL_DATA) coro.h $(HINST)/coro.h
 +	$(BSD_INSTALL_DATA) $(MAN) $(MINST)/man2/coro.2
Comment 2 Maxim Sobolev freebsd_committer freebsd_triage 2000-07-04 11:26:17 UTC
State Changed
From-To: open->closed

Committed, thanks!