Created attachment 151801 [details] Patch from 0.84.4 to 0.85.1 New release 0.85.1 available. See announcement at http://www.glpi-project.org/spip.php?page=annonce&id_breve=333&lang=en
this line is no correct: "@${CP} -R ${WRKSRC}/* ${STAGEDIR}${WWWDIR}" That should probably be ${COPYTREE_SHARE}. Also, I'd like to see the output of portlint (which would have squawked on $CP) and the output of poudriere bulk -t as this is a new version: (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-poudriere.html)
Created attachment 151919 [details] Full portlint -v output
portlint reports no error (see attachment). I'm giving it a try with poudriere.
Created attachment 151924 [details] poudriere build log Here is the output of poudriere bulk -t.
Ok, thanks. It's strange that portlint did not complain about ${CP}, it should have. Anyway, that needs to change for two reasons: 1) You masked the command with "@" in front, you can't mask installation commands 2) This really needs to be changed to COPYTREE_SHARE. If that causes any permissions or ownership issues, you need to fix that in pkg-plist with @mode or @owner or @group keywords. Can you rework that? After you resubmit, it will be sufficient to say it again passes poudriere without having to upload a new log.
Created attachment 151974 [details] Full patch using COPYTREE_SHARE Here it is, this time using COPYTREE_SHARE. Thanks for sharing this, I was not aware of this variable.
BTW, it passes poudriere bulk -t. No error reported.
Great! I only see one issue. Please change "cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}" to "(cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR})" Compound commands require the parenthesis in order to properly support multijob building. In this case, it's probably not really needed but lets set a good example or CYA in case I'm wrong about that. It definitely is not wrong to add the parentheses. :) When you update the new version, I'll promote the PR.
Created attachment 151983 [details] Full patch Well, I think I finally made it!
Well, you made it pass the initial review. I'm promoting the PR to "patch-ready" status for somebody to take it in the final review and they'll commit it if it passes or only needs minor tweak. :) Good job!
Wow, seems like FreeBSD's PR review process has been greatly enhanced recently! Don't know if it's related to the move to Bugzilla, but I like it. It gives maintainers more responsabilities. Thanks for you feedback.
A commit references this bug: Author: marino Date: Fri Feb 6 14:10:33 UTC 2015 New revision: 378541 URL: https://svnweb.freebsd.org/changeset/ports/378541 Log: www/glpi: Upgrade version 0.84.4 => 0.85.1 PR: 196843 Submitted by: maintainer (Mathias Monnerville) Changes: head/www/glpi/Makefile head/www/glpi/distinfo head/www/glpi/files/pkg-message.in head/www/glpi/pkg-plist
Thanks, it was fine. :)