Bug 197502 - Mk/Uses/libtool.mk: don't use the default backup suffix
Summary: Mk/Uses/libtool.mk: don't use the default backup suffix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-10 00:19 UTC by Jan Beich
Modified: 2015-02-16 07:58 UTC (History)
3 users (show)

See Also:

Attachments
-i .libtool.bak (933 bytes, patch)
2015-02-10 00:19 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-02-10 00:19:41 UTC 
Created attachment 152826 [details]
-i .libtool.bak

Rename in order to not make maintainer's life harder with |make makepatch| or |diff configure{.bak,}|. This is similar to run-autotools-fixup.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2015-02-10 09:58:20 UTC 
Looks good to me.  Over to portmgr for approval.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2015-02-14 18:47:59 UTC 
Take,  I will exp-run this with the patch from bug #194393
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2015-02-15 23:44:31 UTC 
Looks good, approved.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-16 07:57:48 UTC 
A commit references this bug:

Author: jbeich
Date: Mon Feb 16 07:56:48 UTC 2015
New revision: 379071
URL: https://svnweb.freebsd.org/changeset/ports/379071

Log:
  Don't use the default backup suffix

  Rename backup file in order to avoid conflict with default suffix as
  used by REINPLACE_CMD in post-patch. This facilitates reviewing
  changes done by each step after the build.

  PR:		197502
  Exp-run by:	antoine
  Approved by:	autotools (tijl, maintainer)
  Approved by:	portmgr (antoine)
  Approved by:	mentors (implicit)

Changes:
  head/Mk/Uses/libtool.mk
Comment 5 Jan Beich freebsd_committer freebsd_triage 2015-02-16 07:58:51 UTC 
-1 tab for alignment in the commit. Hopefully, I didn't overstep my boundaries on the first try with Mk/* stuff.