Created attachment 153195 [details] shell archive Python module adding smart cards support.
Created attachment 153196 [details] poudriere build logs poudriere build logs for 10.1, 10.0, 9.3 and 8.4, all are amd64.
Created attachment 153201 [details] shell archive v2 fix: use ${PYTHONPREFIX_SITELIBDIR} instead hardcoded path
Shouldn't it be called devel/py-scard instead, like all other python modules are?
Pyscard is a full original name of the software. I doubt that renaming is a good idea. Another example is a devel/pybugz.
You're both partially correct :) * Python ports must be prefixed with py- unless there is a compelling case not to do so. * Python ports must be named py-<[upstream|pypi]name] unless there is a compelling case not to do so. Please rename the port (and svn directory) to py-pyscard. PORTNAME should be upstream name, with PKGNAMEPREFIX set to PYTHON_PKGNAMEPREFIX.
Currently python ports can be built in different flavors using different versions of python. So the port py-xxx will become the package named ex. py27-xxx or py34-xxx. While this in itself is a hack, I am sure that framework will choke on the python port names without py- prefix in this regard. This should really be fixed in the framework, but for the time being it is better to follow this convention for port names.
Created attachment 157550 [details] shell archive v3 2koobs: shar updated - i've renamed pyscard dir to py-pyscard, I didn't quiet understood what did you mean by 'rename the port'.
Created attachment 158256 [details] shell archive v4 - update to 1.7.0
On initial review, there are a few improvements that can be made It's a shame they don't make their sdist (tar.gz) available on PyPI. The CHEESEHOP mirror network is backed by Fast.ly and is often much better than the SourceForge network. Submitting an upstream issue requesting it would be nice. Categories: The upstream developers have categorized the package in the Topic :: Security trove classification. Perhaps security would be a better primary port (devel is not preferred if there is more specific category) Add 'python' as a secondary (virtual) category There appears to be a LICENSE file in the source distribution, add LICENSE_FILE to reference it in WRKSRC
Created attachment 158425 [details] shell archive v5 (In reply to Kubilay Kocak from comment #9) > On initial review, there are a few improvements that can be made > > It's a shame they don't make their sdist (tar.gz) available on PyPI. The > CHEESEHOP mirror network is backed by Fast.ly and is often much better than > the SourceForge network. Submitting an upstream issue requesting it would be > nice. I've sent email to the developer about this, but didn't get any answer yet, to not forget this - I've also put a comment in Makefile, to check the PyPI hosting on next update. > The upstream developers have categorized the package in the Topic :: > Security trove classification. Perhaps security would be a better primary > port (devel is not preferred if there is more specific category) > Add 'python' as a secondary (virtual) category > There appears to be a LICENSE file in the source distribution, add > LICENSE_FILE to reference it in WRKSRC All three are fixed.
Created attachment 158426 [details] poudriere build logs v2 fresh poudriere logs (10.1, 9.3, 8.4), only for i386, since I don't have other hardware right now
A commit references this bug: Author: koobs Date: Tue Jul 7 07:32:47 UTC 2015 New revision: 391494 URL: https://svnweb.freebsd.org/changeset/ports/391494 Log: [NEW] security/py-pyscard: Smartcard module for Python The pyscard smartcard library is a framework for building smart card aware applications in Python. The smartcard module is built on top of the PCSC API Python wrapper module. WWW: http://pyscard.sourceforge.net/ PR: 197834 Submitted by: <mp39590 gmail com> Changes: head/security/Makefile head/security/py-pyscard/ head/security/py-pyscard/Makefile head/security/py-pyscard/distinfo head/security/py-pyscard/pkg-descr
Committed, with changes. Thank you * Match COMMENT to upstream setup.py description= field (where it meets FreeBSD standards) * Use PYDISTUTILS_BUILD_TARGET and PYDISTUTILS_BUILDARGS to pass extra include directories. See: setup.py --help build_ext
A commit references this bug: Author: koobs Date: Tue Jul 7 07:38:30 UTC 2015 New revision: 391495 URL: https://svnweb.freebsd.org/changeset/ports/391495 Log: security/py-pyscard: Make supported Python versions explicit This package doesn't require lang/python2, so set USES=python:2.7 explicitly to avoid pulling in an unecessary dependency. The upstream setup.py states that it supports 2.6 and 2.7. PR: 197834 Changes: head/security/py-pyscard/Makefile