Bug 197915 - [kernel] change return type of readlinkat
Summary: [kernel] change return type of readlinkat
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-02-22 08:58 UTC by henning.petersen
Modified: 2020-03-09 13:35 UTC (History)
2 users (show)

See Also:


Attachments
Change return type of readlinkat from int to ssize_t (615 bytes, text/plain)
2015-02-22 08:58 UTC, henning.petersen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description henning.petersen 2015-02-22 08:58:09 UTC
Created attachment 153309 [details]
Change return type of readlinkat from int to ssize_t

in man pages and posix return type of readlinkat should be ssize_t.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2019-04-16 13:18:06 UTC
For reference, readlink return type changed in r176215 https://reviews.freebsd.org/rS176215
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-16 13:27:31 UTC
A commit references this bug:

Author: emaste
Date: Tue Apr 16 13:26:32 UTC 2019
New revision: 346273
URL: https://svnweb.freebsd.org/changeset/base/346273

Log:
  correct readlinkat(2) return type

  r176215 corrected readlink(2)'s return type and the type of the last
  argument.  readlink(2) was introduced in r177788 after being developed
  as part of Google Summer of Code 2007; it appears to have inherited the
  wrong return type.

  Man pages and header files were already ssize_t; update syscalls.master
  to match.

  PR:		197915
  Submitted by:	Henning Petersen <henning.petersen@t-online.de>
  MFC after:	2 weeks

Changes:
  head/sys/compat/freebsd32/syscalls.master
  head/sys/kern/syscalls.master
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-26 12:56:41 UTC
A commit references this bug:

Author: emaste
Date: Fri Apr 26 12:55:53 UTC 2019
New revision: 346739
URL: https://svnweb.freebsd.org/changeset/base/346739

Log:
  make sysent after r346273 (readlinkat arg correction)

  PR:		197915
  Reminded by:	dchagin

Changes:
  head/sys/compat/freebsd32/freebsd32_systrace_args.c
  head/sys/kern/systrace_args.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-03-09 13:34:15 UTC
A commit references this bug:

Author: emaste
Date: Mon Mar  9 13:33:59 UTC 2020
New revision: 358805
URL: https://svnweb.freebsd.org/changeset/base/358805

Log:
  MFC r346273: correct readlinkat(2) return type

  r176215 corrected readlink(2)'s return type and the type of the last
  argument.  readlink(2) was introduced in r177788 after being developed
  as part of Google Summer of Code 2007; it appears to have inherited the
  wrong return type.

  Man pages and header files were already ssize_t; update syscalls.master
  to match.

  PR:		197915
  Submitted by:	Henning Petersen <henning.petersen@t-online.de>

Changes:
_U  stable/12/
  stable/12/sys/compat/freebsd32/syscalls.master
  stable/12/sys/kern/syscalls.master