Bug 198375 - [patch] mail/opensmtpd Add option to not modify mailer.conf
Summary: [patch] mail/opensmtpd Add option to not modify mailer.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-06 22:35 UTC by Adam Weinberger
Modified: 2015-03-29 05:26 UTC (History)
0 users

See Also:
ashish: maintainer-feedback+

Attachments
patch (1.48 KB, patch)
2015-03-06 22:35 UTC, Adam Weinberger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2015-03-06 22:35:47 UTC 
Created attachment 153939 [details]
patch

The OpenSMTPD port always modifies /etc/mail/mailer.conf. This makes installing it a destructive event---you cannot install it and tweak the configuration before making it live. To me this is a POLA violation, as other mail servers don't do that.

The attached patch adds a new OPTION, and defaults it to on, to determine whether mailer.conf is written on installation. The end result is the same for binary package users.

Also, the attached patch suggests a new COMMENT line... the current COMMENT line doesn't really say much and it violates rule #2 from https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-comment.html
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-03-29 05:17:57 UTC 
A commit references this bug:

Author: ashish
Date: Sun Mar 29 05:17:46 UTC 2015
New revision: 382567
URL: https://svnweb.freebsd.org/changeset/ports/382567

Log:
  - Add OPTION to only update mailer.conf(5) on demand
  - Update COMMENT so it complies with guidelines in Porter's
    Handbook

  PR:		198375
  Submitted by:	adamw

Changes:
  head/mail/opensmtpd/Makefile
  head/mail/opensmtpd/files/pkg-deinstall.in
  head/mail/opensmtpd/files/pkg-install.in
  head/mail/opensmtpd-devel/Makefile
  head/mail/opensmtpd-devel/files/pkg-deinstall.in
  head/mail/opensmtpd-devel/files/pkg-install.in
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2015-03-29 05:26:56 UTC 
Committed with minor changes.

Thanks!