Bug 198767 - [PATCH] security/tlswrap: Make EGD conditional/Fix build with LibreSSL
Summary: [PATCH] security/tlswrap: Make EGD conditional/Fix build with LibreSSL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Johan van Selst
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-03-21 13:33 UTC by Bernard Spil
Modified: 2015-04-19 14:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (johans)

Attachments
svn diff for security/tlswrap (283.16 KB, patch)
2015-03-21 13:33 UTC, Bernard Spil 		koobs: maintainer-approval? (johans)
 Details | Diff
Poudriere build log for security/tlswrap (16.04 KB, text/plain)
2015-03-21 13:33 UTC, Bernard Spil 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2015-03-21 13:33:30 UTC 
Created attachment 154624 [details]
svn diff for security/tlswrap

security/tlswrap unconditionally relies on RAND_egd which makes building fail with LibreSSL which has removed EGD. FreeBSD does not require EGD at all, /dev/random has been available since FreeBSD 4.2

This patch checks for the existence of RAND_egd in libcrypto and disables the code using egd.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2015-03-21 13:33:55 UTC 
Created attachment 154625 [details]
Poudriere build log for security/tlswrap
Comment 2 Johan van Selst freebsd_committer freebsd_triage 2015-04-19 14:33:45 UTC 
This patch failed to define HAVE_RAND_EGD during build because conf.h.in was not updated.
I have also reduced the 8635(!) line patch to configure to a 81 line patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-04-19 14:34:36 UTC 
A commit references this bug:

Author: johans
Date: Sun Apr 19 14:33:54 UTC 2015
New revision: 384291
URL: https://svnweb.freebsd.org/changeset/ports/384291

Log:
  security/tlswrap unconditionally relies on RAND_egd which makes building fail with LibreSSL which has removed EGD. FreeBSD does not require EGD at all, /dev/random has been available since FreeBSD 4.2
  This patch checks for the existence of RAND_egd in libcrypto and disables the code using egd when it is not available.

  The default build remains unchanged

  PR:		198767
  Submitted by:	Bernard Spil <spil.oss@gmail.com>

Changes:
  head/security/tlswrap/files/
  head/security/tlswrap/files/patch-conf.h.in
  head/security/tlswrap/files/patch-configure
  head/security/tlswrap/files/patch-configure.in
  head/security/tlswrap/files/patch-tls.c