Bug 199413 - [UPDATE] devel/ocaml-opam: update to 1.2.1
Summary: [UPDATE] devel/ocaml-opam: update to 1.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 10:25 UTC by mmatalka
Modified: 2015-04-30 08:35 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (joris)


Attachments
Diff for port upgrade (1.13 KB, patch)
2015-04-13 10:25 UTC, mmatalka
no flags Details | Diff
update opam to 1.2.1 (3.53 KB, patch)
2015-04-26 09:57 UTC, joris
joris: maintainer-approval+
Details | Diff
remove check for curl in configure (2.44 KB, patch)
2015-04-29 18:40 UTC, joris
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mmatalka 2015-04-13 10:25:49 UTC
Created attachment 155537 [details]
Diff for port upgrade

The latest version of opam is 1.2.1.
Comment 1 John Marino freebsd_committer freebsd_triage 2015-04-14 14:13:46 UTC
mmatalka, there is a new format for GITHUB specification.   We need to use that, this is continuing the legacy format.

For example, GH_COMMIT is no longer used and we should be seeing GITHUB in MASTER_SITES.

Please see: https://svnweb.freebsd.org/ports/head/CHANGES?revision=383626&view=markup
entry 20150319

Can you rework your patch to move away from GITHUB_LEGACY?
Comment 2 joris 2015-04-14 14:17:39 UTC
Thanks for the hint. I tried the patch this morning but it failed because of this reason, i haven't had time to investigate.
@mmatalka thanks for the patch, we'll also need to check if the hardcoded dependencies have changed, but i can do that.
Comment 3 mmatalka 2015-04-14 14:57:18 UTC
Thanks!  @joris, do you want me to fix the github link or did you want to do that?  I have verified I can install opam via this patch if that is of any consequence.

I'm happy to fix the patch, just let me know if you want me to do it.
Comment 4 joris 2015-04-14 15:11:26 UTC
I was trying to make it myself, but there are a few difficulties. The current port is kind of a hack because it uses USE_GITHUB without using it. Indeed, it needs to download a few more archives but only extract the one from github. Hence, i put a custom DISTFILES= field and an EXTRACT_ONLY= field. But it messes up with USE_GITHUB, and i had to manually add the distfile. I'm not sure it's supposed to work like this because i need to guess the distfile name.

marino, any hint about this ?
Comment 5 John Marino freebsd_committer freebsd_triage 2015-04-16 09:26:51 UTC
I think what you are doing is okay, but you just need to use the new GITHUB url (see bsd.sites.mk probably) which will change the checksum hash.

Basically I think you need to see what the current USE_GITHUB MASTER_SITES is and just use that.

I'd have to look myself to be more specific.

also, this probably works:

MASTER_SITES= GH <site2>:site2 <site3>:site3

So then you can just use the github framework as designed.
Comment 6 joris 2015-04-26 09:57:08 UTC
Created attachment 156003 [details]
update opam to 1.2.1
Comment 7 joris 2015-04-26 09:58:05 UTC
Hi,
sorry for the delay, i was on holidays. Here is a patch to upgrade opam to 1.2.1
Comment 8 John Marino freebsd_committer freebsd_triage 2015-04-29 17:38:38 UTC
There are some problems that portlint would have caught, but I'll clean those up.

Also extract suffix can use USES=tar:<arg>
Comment 9 joris 2015-04-29 18:40:23 UTC
Created attachment 156113 [details]
remove check for curl in configure

A patch to remove configure check for curl/wget
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-04-29 19:08:48 UTC
A commit references this bug:

Author: marino
Date: Wed Apr 29 19:08:05 UTC 2015
New revision: 385004
URL: https://svnweb.freebsd.org/changeset/ports/385004

Log:
  devel/ocaml-opam: Upgrade version 1.2.0 => 1.2.1

  PR:		199413
  Submitted by:	mmatalka (gmail)
  Revised by:	maintainer (Joris Giovannangeli)

Changes:
  head/devel/ocaml-opam/Makefile
  head/devel/ocaml-opam/distinfo
  head/devel/ocaml-opam/files/
  head/devel/ocaml-opam/files/patch-configure
Comment 11 John Marino freebsd_committer freebsd_triage 2015-04-29 19:09:12 UTC
Thanks guys!
Comment 12 mmatalka 2015-04-30 08:35:04 UTC
Thank you for turning my patch into a reality!