Bug 200005 - irc/znc: rc script assumes a user that is not created with package
Summary: irc/znc: rc script assumes a user that is not created with package
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2015-05-06 17:58 UTC by Josh Galvez
Modified: 2016-11-24 14:55 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (jase)
amdmi3: merge-quarterly+


Attachments
znc_user_group.patch (4.61 KB, patch)
2016-09-03 21:08 UTC, Danilo G. Baio
no flags Details | Diff
znc_user_group_v2.patch (3.89 KB, patch)
2016-09-12 01:16 UTC, Danilo G. Baio
no flags Details | Diff
poudriere - 93-amd64 - znc-1.6.3_3.log (92.26 KB, text/plain)
2016-09-12 09:57 UTC, Danilo G. Baio
no flags Details
poudriere - 12-amd64 - znc-1.6.3_3.log (85.94 KB, text/plain)
2016-09-12 10:02 UTC, Danilo G. Baio
no flags Details
znc_user_group_v3.patch (3.65 KB, patch)
2016-10-09 15:01 UTC, Danilo G. Baio
no flags Details | Diff
poudriere - 93-amd64 - znc-1.6.3_4.log (92.27 KB, text/plain)
2016-10-09 15:01 UTC, Danilo G. Baio
no flags Details
poudriere - 103-amd64 - znc-1.6.3_4.log (85.18 KB, text/plain)
2016-10-09 15:02 UTC, Danilo G. Baio
no flags Details
poudriere - 12-amd64 - znc-1.6.3_4.log (85.77 KB, text/plain)
2016-10-09 15:02 UTC, Danilo G. Baio
no flags Details
znc_user_group_v4_svn.patch (2.96 KB, patch)
2016-10-12 11:08 UTC, Danilo G. Baio
no flags Details | Diff
znc_user_group_v4_patch-compatible.patch (2.92 KB, patch)
2016-10-12 11:09 UTC, Danilo G. Baio
no flags Details | Diff
znc_user_group_v4_svn.patch (3.70 KB, patch)
2016-10-20 23:54 UTC, Danilo G. Baio
no flags Details | Diff
znc_user_group_v4_patch-compatible.patch (3.67 KB, patch)
2016-10-20 23:54 UTC, Danilo G. Baio
no flags Details | Diff
znc_user_group_v5_svn.patch (3.71 KB, patch)
2016-10-22 10:39 UTC, Danilo G. Baio
dbaio: maintainer-approval+
Details | Diff
znc_user_group_v5_patch-compatible.patch (3.67 KB, patch)
2016-10-22 10:39 UTC, Danilo G. Baio
dbaio: maintainer-approval+
Details | Diff
znc_user_group--patch-compatible.patch (3.76 KB, patch)
2016-10-22 11:47 UTC, Danilo G. Baio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Galvez 2015-05-06 17:58:18 UTC
When installing ZNC it assumes in the rc script that ZNC will be ran as the user 'znc'

This user is not created when installing znc.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-19 10:52:11 UTC
Maintainer timeout (> 1 year). Open to take.
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-03 21:08:21 UTC
Created attachment 174356 [details]
znc_user_group.patch

patch attached to fix this:

- znc user/group are now being created on the system.
- move pkg-message to files directory
- remove pre-configure sections to fix building on head.
- replace OPENSSL_USE to USES=ssl

testport: 
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)


there isn't new warnings on portlint:

[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [63]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [46]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-11 11:31:39 UTC
Wonderful Danilo, thank you.
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-12 01:16:58 UTC
Created attachment 174668 [details]
znc_user_group_v2.patch


I've updated the patch, there is an update upstream.
CCing @amdmi3 could you take a look, please ?

- Create znc user/group
- Move pkg-message to files directory
- Insert an information about znc user/group on pkg-message
- Bump PORTREVISION
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-12 08:09:35 UTC
@Danilo, Please confirm QA on the updated patch (attachment 174668 [details]) ?
Comment 6 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-12 09:57:35 UTC
Created attachment 174679 [details]
poudriere - 93-amd64 - znc-1.6.3_3.log
Comment 7 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-12 10:02:33 UTC
Created attachment 174680 [details]
poudriere - 12-amd64 - znc-1.6.3_3.log


Sure.

Same warnings on portlint:

[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [74]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [48]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.

Poudriere testport: 
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

This and attachment 174679 [details] as poudriere testport examples.

I am an user of znc and the attachment 174668 [details] worked fine.

Thank you.
Comment 8 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-18 12:49:04 UTC
In this moment irc/znc has no maintainer. ports r422375
I could take this maintainer'ship, I am a daily user of irc/znc.

Thank you.
Comment 9 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-09 15:01:00 UTC
Created attachment 175572 [details]
znc_user_group_v3.patch


Hi.
Port irc/znc was updated. 
Updating outdated patch.

- Create znc user/group
- Set permissions properly on ETCDIR
- Move pkg-message to files directory
- Insert an information about znc user/group on pkg-message
- Update distinfo with TIMESTAMP
- Bump PORTREVISION
- Take maintainer'ship

[QA]

Poudriere testport: 
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

Same warnings on portlint:

[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [73]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [47]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.

I will attach some poudriere logs for the record.
Comment 10 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-09 15:01:53 UTC
Created attachment 175573 [details]
poudriere - 93-amd64 - znc-1.6.3_4.log
Comment 11 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-09 15:02:21 UTC
Created attachment 175574 [details]
poudriere - 103-amd64 - znc-1.6.3_4.log
Comment 12 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-09 15:02:43 UTC
Created attachment 175575 [details]
poudriere - 12-amd64 - znc-1.6.3_4.log
Comment 13 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-12 11:08:44 UTC
Created attachment 175658 [details]
znc_user_group_v4_svn.patch


Updating outdated patch by ports r423687 

- Create znc user/group
- Set permissions properly on ETCDIR
- Move pkg-message to files directory
- Insert an information about znc user/group on pkg-message
- Update distinfo with TIMESTAMP
- Bump PORTREVISION
- Take maintainer'ship

[QA]

Poudriere testport: 
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  11    (OK)
	poudriere: amd64, 11    (OK)	
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

Same warnings on portlint:

[~/FreeBSD/ports/irc/znc]$ portlint -C
WARN: Makefile: [73]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: [47]: possible direct use of command "perl" found. use ${PERL} instead.
0 fatal errors and 2 warnings found.
Comment 14 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-12 11:09:10 UTC
Created attachment 175659 [details]
znc_user_group_v4_patch-compatible.patch
Comment 15 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-20 23:54:18 UTC
Created attachment 175997 [details]
znc_user_group_v4_svn.patch

missing GIDs/UIDs
Comment 16 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-20 23:54:59 UTC
Created attachment 175998 [details]
znc_user_group_v4_patch-compatible.patch

missing GIDs/UIDs
Comment 17 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-22 10:39:21 UTC
Created attachment 176055 [details]
znc_user_group_v5_svn.patch

Port updated on ports r424427
Comment 18 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-22 10:39:54 UTC
Created attachment 176056 [details]
znc_user_group_v5_patch-compatible.patch

Port updated on ports r424427
Comment 19 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-22 11:47:26 UTC
Created attachment 176061 [details]
znc_user_group--patch-compatible.patch
Comment 20 commit-hook freebsd_committer freebsd_triage 2016-11-23 11:43:18 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Nov 23 11:43:14 UTC 2016
New revision: 426896
URL: https://svnweb.freebsd.org/changeset/ports/426896

Log:
  - Create znc user/group
  - Set permissions properly on ETCDIR
  - Add an information on znc user/group to pkg-message
  - Pass maintainership to dbaio

  PR:		200005
  Submitted by:	josh+freebsd@zevlag.com, dbaio@bsd.com.br

Changes:
  head/GIDs
  head/UIDs
  head/irc/znc/Makefile
  head/irc/znc/distinfo
  head/irc/znc/files/pkg-message.in
  head/irc/znc/pkg-message
  head/irc/znc/pkg-plist
Comment 21 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-23 12:59:15 UTC
Re-open for MFH
Comment 22 commit-hook freebsd_committer freebsd_triage 2016-11-24 14:55:28 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Nov 24 14:55:01 UTC 2016
New revision: 427021
URL: https://svnweb.freebsd.org/changeset/ports/427021

Log:
  MFH: r426896

  - Create znc user/group
  - Set permissions properly on ETCDIR
  - Add an information on znc user/group to pkg-message
  - Pass maintainership to dbaio

  PR:		200005
  Submitted by:	josh+freebsd@zevlag.com, dbaio@bsd.com.br
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/GIDs
  branches/2016Q4/UIDs
  branches/2016Q4/irc/znc/Makefile
  branches/2016Q4/irc/znc/distinfo
  branches/2016Q4/irc/znc/files/pkg-message.in
  branches/2016Q4/irc/znc/pkg-message
  branches/2016Q4/irc/znc/pkg-plist