Bug 201007 - [maintainer update] upgrade textproc/fop to v2.0
Summary: [maintainer update] upgrade textproc/fop to v2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-21 15:42 UTC by Geoff Speicher
Modified: 2015-08-13 13:41 UTC (History)
0 users

See Also:


Attachments
diff -ruN fop.orig fop (3.84 KB, patch)
2015-06-21 15:42 UTC, Geoff Speicher
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Speicher 2015-06-21 15:42:15 UTC
Created attachment 157931 [details]
diff -ruN fop.orig fop

Attached patch upgrades textproc/fop from 1.1 to 2.0. Although it is a major version bump, the impact is minimal to fop users:

  https://xmlgraphics.apache.org/fop/2.0/releaseNotes_2.0.html
  https://xmlgraphics.apache.org/fop/2.0/upgrading.html

Patch also updates port to use offo-hyphenation v2.1 (bumped from 2.0).
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-06-23 14:29:27 UTC
A commit references this bug:

Author: amdmi3
Date: Tue Jun 23 14:28:26 UTC 2015
New revision: 390415
URL: https://svnweb.freebsd.org/changeset/ports/390415

Log:
  - Update to 2.0

  PR:		201007
  Submitted by:	geoff@sea-incorporated.com (maintainer)

Changes:
  head/textproc/fop/Makefile
  head/textproc/fop/distinfo
  head/textproc/fop/pkg-plist
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-25 12:25:54 UTC
This has broken FreeBSD documentation building. Could you please take a look:

http://package23.nyi.freebsd.org/data/101amd64-default-D2897/2015-06-24_20h54m55s/logs/errors/zh_cn-freebsd-doc-46616_1,1.log
Comment 3 Geoff Speicher 2015-06-25 13:18:08 UTC
Can you help troubleshoot to determine if this is related to the offo-hyphenation upgrade to 2.1 or to the fop upgrade to 2.0?

There are three lines in the Makefile for the hyphenation upgrade. If you revert those lines, does that fix the doc build?
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-06-25 14:21:57 UTC
(In reply to geoff from comment #3)

> There are three lines in the Makefile for the hyphenation upgrade. If you
> revert those lines, does that fix the doc build?

No, after reverting hyphenation upgrade it still fails.
Comment 5 Geoff Speicher 2015-06-25 14:42:22 UTC
Looks like this might be a known issue:

   https://issues.apache.org/jira/browse/FOP-2461

The comments in that link contain a suggested "lazy workaround" for ListItemLayoutManager but no fix has been committed. If you want to try that workaround, and it works, then we can add a patch to the local port until they commit a fix upstream.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-27 13:34:14 UTC
A commit references this bug:

Author: amdmi3
Date: Sat Jun 27 13:33:42 UTC 2015
New revision: 390702
URL: https://svnweb.freebsd.org/changeset/ports/390702

Log:
  - Add workaround patch to fix misc/freebsd-doc-* building

  See https://issues.apache.org/jira/browse/FOP-2461

  PR:		201007
  Submitted by:	geoff@sea-incorporated.com (maintainer)

Changes:
  head/textproc/fop/Makefile
  head/textproc/fop/files/
  head/textproc/fop/files/patch-src_java_org_apache_fop_layoutmgr_list_ListItemLayoutManager.java
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-09 17:20:59 UTC
This still fails on i386 with infinite recursion:

http://beefy5.nyi.freebsd.org/data/101i386-default/391608/logs/el-freebsd-doc-46616_1,1.log

is there a fix for that?
Comment 8 Geoff Speicher 2015-07-09 21:18:27 UTC
I have seen similar complaints like this for large documents and/or custom hyphenation rules that were solved by using a bigger Java stack size (-Xss). Can you try cranking up that setting to see if that makes a difference?
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-13 17:38:45 UTC
Umm, where should I add this? Could you please provide a patch?
Comment 10 Geoff Speicher 2015-07-14 00:29:01 UTC
I'm not sure the best way to do this in the broken port's Makefile, but you can try defining the environment variable FOP_OPTS during the build target, or whichever target executes fop, for the broken port. For example,

   FOP_OPTS="-Xss8m"

should give an 8MB stack to the fop utility when it runs. I believe the default is 256KB.
Comment 11 Dmitry Marakasov freebsd_committer freebsd_triage 2015-08-13 13:41:43 UTC
The freebsd-doc problem seems to have fixed itself after Jul 21, so closing the PR.