Bug 201680 - [patch] astro/gpsbabel: add GUI option, clean up dependencies
Summary: [patch] astro/gpsbabel: add GUI option, clean up dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-18 19:09 UTC by Andriy Voskoboinyk
Modified: 2015-08-18 20:07 UTC (History)
1 user (show)

See Also:
dev2: maintainer-feedback+

Attachments
Patch.diff (3.25 KB, patch)
2015-07-18 19:09 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (186 bytes, text/plain)
2015-07-18 19:09 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-no-gui.log (47.86 KB, text/plain)
2015-07-18 19:10 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386-with-gui.log (93.50 KB, text/plain)
2015-07-18 19:11 UTC, Andriy Voskoboinyk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:09:27 UTC 
Created attachment 158946 [details]
Patch.diff

- Add GUI option (requires qt4-gui,qt4-xml,qt4-network and qt4-webkit at runtime).
- Remove autoconf/pcre/glib20/gettext dependencies (unused).
- USE_QT4=linguist_build -> USE_QT4=linguisttools_build (GUI option only).
- Use system zlib.
- Regenerate patch.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:09:51 UTC 
Created attachment 158947 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:10:09 UTC 
Created attachment 158948 [details]
poudriere-9.3-i386-no-gui.log
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-18 19:11:25 UTC 
Created attachment 158949 [details]
poudriere-9.3-i386-with-gui.log
Comment 4 Oliver Heesakkers 2015-08-02 11:41:51 UTC 
I (maintainer) am OK with this.
Thanks for the patch!
Comment 5 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-12 01:51:22 UTC 
Take.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-08-18 19:58:34 UTC 
A commit references this bug:

Author: pgollucci
Date: Tue Aug 18 19:58:07 UTC 2015
New revision: 394642
URL: https://svnweb.freebsd.org/changeset/ports/394642

Log:
  astro/gpsbabel: add GUI option, clean up dependencies

  - Add GUI option (requires qt4-gui,qt4-xml,qt4-network and qt4-webkit at runtime).
  - Remove autoconf/pcre/glib20/gettext dependencies (unused).
  - USE_QT4=linguist_build -> USE_QT4=linguisttools_build (GUI option only).
  - Use system zlib.
  - Regenerate patch.

  PR:                  201680
  Submitted by:        s3erios@gmail.com
  Approved by:         dev2@heesakkers.info

Changes:
  head/astro/gpsbabel/Makefile
  head/astro/gpsbabel/files/patch-jeeps-gpslibusb.cc
  head/astro/gpsbabel/pkg-plist
Comment 7 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-18 20:07:21 UTC 
Committed. Thanks!