Bug 202076 - x11/lxpanel: Misses gettext if compiled without NLS
Summary: x11/lxpanel: Misses gettext if compiled without NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 10:33 UTC by Sascha Holzleiter
Modified: 2016-05-26 16:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (horia)

Attachments
poudriere log (33.24 KB, text/x-log)
2015-08-04 10:33 UTC, Sascha Holzleiter 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2015-08-04 10:33:10 UTC 
Created attachment 159528 [details]
poudriere log

Building lxpanel without NLS complains about missing gettext (full poudriere log attached). Adding gettext to USES fixes that for me.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2015-12-24 21:03:52 UTC 
Hi,

Can you please confirm that the problem is solved for you?
Comment 2 Sascha Holzleiter 2015-12-25 02:11:22 UTC 
I actually switched back to enable NLS a month or so ago because every other day another port was falling over this.

But i just switched the options back to WITHOUT_NLS and rebuild lxpanel and its dependencies to test this and the error still exists when built with WITHOUT_NLS.
And as before adding gettext to the USES clause fixes it.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-05-26 16:27:42 UTC 
Committer timeout.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-05-26 16:30:23 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu May 26 16:29:45 UTC 2016
New revision: 415903
URL: https://svnweb.freebsd.org/changeset/ports/415903

Log:
  - Fix build for disabled NLS case
  - Switch to options helpers
  - Simplify stripping
  - Simplify plist handling

  PR:		202076
  Reported by:	sascha@root-login.org
  Approved by:	maintainer timeout (horia@racoviceanu.com, 9 months)

Changes:
  head/x11/lxpanel/Makefile
  head/x11/lxpanel/pkg-plist