Bug 202370 - www/chromium: wrapper should exec binary
Summary: www/chromium: wrapper should exec binary
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-16 17:47 UTC by Stefan Bethke
Modified: 2015-08-20 18:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chromium)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2015-08-16 17:47:11 UTC 
The wrapper shell script should exec the chrome binary, instead of just invoking it.

Index: files/chrome.in
===================================================================
--- files/chrome.in	(revision 394317)
+++ files/chrome.in	(working copy)
@@ -15,4 +15,4 @@
 EOMSG
 	exit 1
 fi
-%%PREFIX%%/share/chromium/chrome $*
+exec %%PREFIX%%/share/chromium/chrome $*

Without this change, chromedriver can't shut down the chrome process.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-08-20 18:12:57 UTC 
A commit references this bug:

Author: rene
Date: Thu Aug 20 18:11:58 UTC 2015
New revision: 394902
URL: https://svnweb.freebsd.org/changeset/ports/394902

Log:
  - Update to 44.0.2403.155 [1]
  - Add a non-default option to install Chrome Driver [2][3]

  PR:		202368 [2]
  PR:		202370 [3]
  Submitted by:	LeFroid via GitHub [1]
  Submitted by:	stb@lassitu.de [2][3]
  MFH:		2015Q3

Changes:
  head/www/chromium/Makefile
  head/www/chromium/distinfo
  head/www/chromium/files/chrome.in
  head/www/chromium/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-08-20 18:22:01 UTC 
A commit references this bug:

Author: rene
Date: Thu Aug 20 18:21:05 UTC 2015
New revision: 394903
URL: https://svnweb.freebsd.org/changeset/ports/394903

Log:
  MFH: r394902

  - Update to 44.0.2403.155 [1]
  - Add a non-default option to install Chrome Driver [2][3]

  PR:		202368 [2]
  PR:		202370 [3]
  Submitted by:	LeFroid via GitHub [1]
  Submitted by:	stb@lassitu.de [2][3]
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/www/chromium/Makefile
  branches/2015Q3/www/chromium/distinfo
  branches/2015Q3/www/chromium/files/chrome.in
  branches/2015Q3/www/chromium/pkg-plist