Bug 20261 - fix: audio/xmms linked against both libc and libc_r
Summary: fix: audio/xmms linked against both libc and libc_r
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Maxim Sobolev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-07-28 20:00 UTC by FUJISHIMA Satsuki
Modified: 2000-07-31 08:57 UTC (History)
0 users

See Also:


Attachments
file.diff (11.18 KB, patch)
2000-07-28 20:00 UTC, FUJISHIMA Satsuki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description FUJISHIMA Satsuki 2000-07-28 20:00:01 UTC
	Currently xmms is linked against both libc and libc_r due to lack
	of LIBTOOLFILES.

Fix: Comparing before and after this patch:

/usr/ports/audio/xmms$ diff -u log-before log-after


Bogus warings have gone. Looks good.--pgMiMZYvpfiGiOWFto3KrMrpDTNh1K5Q50humpNkNA4VB20b
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/xmms/Makefile,v
retrieving revision 1.18
diff -u -w -B -b -r1.18 Makefile
--- Makefile	2000/07/13 20:20:21	1.18
+++ Makefile	2000/07/28 07:42:46
@@ -24,6 +24,7 @@
 
 USE_X_PREFIX=   yes
 USE_LIBTOOL=    yes
+LIBTOOLFILES=	configure libxmms/configure
 INSTALLS_SHLIB= yes
 
 .if !defined(WITHOUT_MIKMOD)
How-To-Repeat: 
/usr/ports/audio/xmms$ make
...
/usr/lib/libc.so.4: WARNING!  setkey(3) not present in the system!
/usr/lib/libc.so.4: warning: this program uses gets(), which is unsafe.
/usr/lib/libc.so.4: warning: mktemp() possibly used unsafely; consider using mkstemp()
/usr/lib/libc.so.4: WARNING!  des_setkey(3) not present in the system!
/usr/lib/libc.so.4: WARNING!  encrypt(3) not present in the system!
/usr/lib/libc.so.4: warning: tmpnam() possibly used unsafely; consider using mkstemp()
/usr/lib/libc.so.4: warning: this program uses f_prealloc(), which is stupid.
/usr/lib/libc.so.4: WARNING!  des_cipher(3) not present in the system!
...
Comment 1 FUJISHIMA Satsuki 2000-07-28 20:09:33 UTC
This patch is also needed to fix.

Index: pkg/PLIST
===================================================================
RCS file: /home/ncvs/ports/audio/xmms/pkg/PLIST,v
retrieving revision 1.10
diff -u -w -B -b -r1.10 PLIST
--- pkg/PLIST	2000/07/12 10:58:15	1.10
+++ pkg/PLIST	2000/07/28 19:07:08
@@ -13,7 +13,6 @@
 include/xmms/util.h
 include/xmms/xmmsctrl.h
 lib/libxmms.a
-lib/libxmms.la
 lib/libxmms.so.1
 @exec ln -fs %D/%F %B/libxmms.so
 @unexec rm -f %B/libxmms.so
Comment 2 Maxim Sobolev freebsd_committer freebsd_triage 2000-07-31 07:48:51 UTC
Responsible Changed
From-To: freebsd-ports->sobomax

I'll take this.
Comment 3 Maxim Sobolev freebsd_committer freebsd_triage 2000-07-31 08:56:53 UTC
State Changed
From-To: open->closed

Patches committed, thanks!