Created attachment 160586 [details] 15.1 diff Update to 15.1 This version needs multimedia/libcec >= 3.0.0 and it's not available yet (i'm working on it) so i marked the option CEC broken and removed it from default, i'm not sure it's the correct answer to the problem. poudriere logs: http://fneu.fr/freebsd/xbmc/freebsd9_amd64_kodi-15.1.log http://fneu.fr/freebsd/xbmc/freebsd10_i386_kodi-15.1.log http://fneu.fr/freebsd/xbmc/freebsd10_amd64_kodi-15.1.log
How is the libcec update coming along? The security issue impacted kodi-14.2's embedded ffmpeg (http://www.vuxml.org/freebsd/80c66af0-d1c5-449e-bd31-63b12525ff88.html) seems like it would a low risk for a system playing local media on an isolated home LAN. Is the CEC option something that most users would expect to use?
(In reply to Jason Unovitch from comment #1) Any update on my libcec question above?
Comment on attachment 160586 [details] 15.1 diff >+.if ${PORT_OPTIONS:MCEC} >+BROKEN= Needs libcec >= 3.0.0 >+.endif Rebase after ports r397342 and convert the above into CEC_BROKEN= Needs libcec >= 3.0.0 or to avoid repeating BUILD_DEPENDS logic CEC_BROKEN= libcec >= 3.0.0 haven't been ported yet
Only very few people with a Pulse Eight CEC adaptor use libcec library. So me and maybe ...
(In reply to mickael.maillot from comment #4) OK, so we'll make the note of it with the broken CEC option that the functionality has been temporarily turned off.
Working on QA builds at this time with the latter CEC_BROKEN suggestion from comment 3.
Created attachment 161291 [details] kodi-15.1.patch It looks like 9.3-RELEASE builds fail in the current form. Log below: https://people.freebsd.org/~junovitch/poudriere/PR202812/kodi-15.1.log I've attached an updated patch that sets USE_GCC= yes for FreeBSD < 10.0 and this appears to fix the issue. Do you know which C features are in use so that the USES= compiler:<feature> can be set?
(In reply to Jason Unovitch from comment #7) Actually, replying to myself I see that FreeBSD 9 built fine originally. I am looking into what changed now.
(In reply to Jason Unovitch from comment #8) Yes, the original 9.3 logs listed GCC 4.8.5. That is why it failed using FreeBSD 9.3's GCC 4.2.1. -- The C compiler identification is GNU 4.8.5 -- The CXX compiler identification is GNU 4.8.5
A commit references this bug: Author: junovitch Date: Wed Sep 23 02:35:16 UTC 2015 New revision: 397605 URL: https://svnweb.freebsd.org/changeset/ports/397605 Log: multimedia/kodi: update 14.2 -> 15.1 - Update to Kodi 15.1 "Isengard" - Remove CEC option from defaults - Set CEC option as broken, needs libcec >= 3.0.0 which has yet to be ported - Set USE_GCC for compilation on FreeBSD 9 - Sort USE_XORG, set USE_LDCONFIG, add under java category (portlint) PR: 202812 Submitted by: mickael.maillot@gmail.com (maintainer) Security: 80c66af0-d1c5-449e-bd31-63b12525ff88 Security: CVE-2015-3395 Security: 3d950687-b4c9-4a86-8478-c56743547af8 Security: CVE-2015-6818 Security: CVE-2015-6819 Security: CVE-2015-6820 Security: CVE-2015-6821 Security: CVE-2015-6822 Security: CVE-2015-6823 Security: CVE-2015-6824 Security: CVE-2015-6825 Security: CVE-2015-6826 MFH: 2015Q3 X-MFH-With: r397342 X-MFH-Note: opt_VARS added post 2015Q3, needs manual resolution Changes: head/multimedia/kodi/Makefile head/multimedia/kodi/distinfo head/multimedia/kodi/files/patch-configure.ac head/multimedia/kodi/files/patch-configure.in head/multimedia/kodi/files/patch-ffmpegx86 head/multimedia/kodi/files/patch-freebsd head/multimedia/kodi/files/patch-project__cmake__scripts__common__prepare-env.cmake head/multimedia/kodi/files/patch-sidplay head/multimedia/kodi/files/patch-tools__depends__target__ffmpeg__autobuild.sh head/multimedia/kodi/files/patch-xbmc__LangInfo.cpp head/multimedia/kodi/files/patch-xbmc__cores__dvdplayer__DVDDemuxSPU.cpp head/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogGamepad.cpp head/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogNumeric.cpp head/multimedia/kodi/files/patch-xbmc__guilib__GUIAction.cpp head/multimedia/kodi/files/patch-xbmc__guilib__GUISpinControl.cpp head/multimedia/kodi/files/patch-xbmc__guilib__TextureBundleXPR.h head/multimedia/kodi/files/patch-xbmc__guilib__XBTF.h head/multimedia/kodi/files/patch-xbmc__interfaces__legacy__Dialog.cpp head/multimedia/kodi/files/patch-xbmc__linux__XFileUtils.cpp head/multimedia/kodi/files/patch-xbmc__main__main.cpp head/multimedia/kodi/files/patch-xbmc__pvr__PVRActionListener.cpp head/multimedia/kodi/files/patch-xbmc__settings__AdvancedSettings.cpp head/multimedia/kodi/files/patch-xbmc__storage__linux__DeviceKitDisksProvider.cpp head/multimedia/kodi/files/patch-xbmc__storage__linux__UDisksProvider.cpp head/multimedia/kodi/files/patch-xbmc__threads__platform__pthreads__ThreadImpl.cpp head/multimedia/kodi/files/patch-xbmc__utils__CharsetConverter.cpp head/multimedia/kodi/files/patch-xbmc__windowing__WinEventsX11.cpp head/multimedia/kodi/files/patch-xbmc_cores_DllLoader_dll__tracker.cpp head/multimedia/kodi/files/patch-xbmc_cores_DllLoader_dll__tracker__file.cpp head/multimedia/kodi/files/patch-xbmc_cores_DllLoader_exports_emu__kernel32.cpp head/multimedia/kodi/files/patch-xbmc_filesystem_iso9660.cpp head/multimedia/kodi/files/patch-xbmc_linux_XFileUtils.cpp head/multimedia/kodi/files/patch-xbmc_threads_platform_pthreads_ThreadImpl.cpp head/multimedia/kodi/pkg-plist
(In reply to Jason Unovitch from comment #9) In my original poudriere build, i used: USES= compiler:c++11-lib I don't why it's not in my patch :/ I'm sorry about that.
A commit references this bug: Author: junovitch Date: Wed Sep 23 13:28:59 UTC 2015 New revision: 397613 URL: https://svnweb.freebsd.org/changeset/ports/397613 Log: multimedia/kodi: Set USES= compiler:c++11-lib - USES= compiler:c++11-lib was left out of the original patch due to an oversight. Add it and remove FreeBSD 9 specific USE_GCC= yes. - No PORTREVISION bump as the compiler choice remained the same. PR: 202812 Submitted by: mickael.maillot@gmail.com MFH: 2015Q3 X-MFH-With: r397342, r397605 Changes: head/multimedia/kodi/Makefile
(In reply to mickael.maillot from comment #11) Thank you. The updated USES was committed and USE_GCC removed.
I'm sorry for not catching this earlier but the 9.3 i386 builds failed earlier and I caught this now while double checking this for MFH. Can you review the bad C++ code error Poudriere listed in the log below? https://people.freebsd.org/~junovitch/poudriere/PR202812/93i386-kodi-15.1.log
Created attachment 161333 [details] new version of patch-configure.ac to fix 9 i386 build
Fix found here: https://github.com/openvswitch/ovs/commit/fd2e50cd333324ca18d8186a5c9211aa03c439cf
A commit references this bug: Author: junovitch Date: Fri Sep 25 12:46:37 UTC 2015 New revision: 397820 URL: https://svnweb.freebsd.org/changeset/ports/397820 Log: multimedia/kodi: regen patch-configure.ac - Add atomic lib to search libs, resolve 9.3 i386 build issue - Bump PORTREVISION due to libatomic shlib dependency PR: 202812 Submitted by: mickael.maillot@gmail.com (maintainer) MFH: 2015Q3 X-MFH-With: r397342, r397605, r397613 Changes: head/multimedia/kodi/Makefile head/multimedia/kodi/files/patch-configure.ac
A commit references this bug: Author: junovitch Date: Sat Sep 26 00:23:41 UTC 2015 New revision: 397913 URL: https://svnweb.freebsd.org/changeset/ports/397913 Log: MFH r397342, r397605, r397613, r397820 r397342 (partial) multimedia/kodi: minor cleanup - Convert to USE_GL - Drop 8.x support Approved by: portmgr blanket r397605 multimedia/kodi: update 14.2 -> 15.1 - Update to Kodi 15.1 "Isengard" - Remove CEC option from defaults - Set CEC option as broken, needs libcec >= 3.0.0 which has yet to be ported - Set USE_GCC for compilation on FreeBSD 9 - Sort USE_XORG, set USE_LDCONFIG, add under java category (portlint) PR: 202812 Submitted by: mickael.maillot@gmail.com (maintainer) Security: 80c66af0-d1c5-449e-bd31-63b12525ff88 Security: CVE-2015-3395 Security: 3d950687-b4c9-4a86-8478-c56743547af8 Security: CVE-2015-6818 Security: CVE-2015-6819 Security: CVE-2015-6820 Security: CVE-2015-6821 Security: CVE-2015-6822 Security: CVE-2015-6823 Security: CVE-2015-6824 Security: CVE-2015-6825 Security: CVE-2015-6826 r397613 multimedia/kodi: Set USES= compiler:c++11-lib - USES= compiler:c++11-lib was left out of the original patch due to an oversight. Add it and remove FreeBSD 9 specific USE_GCC= yes. - No PORTREVISION bump as the compiler choice remained the same. PR: 202812 Submitted by: mickael.maillot@gmail.com r397820 multimedia/kodi: regen patch-configure.ac - Add atomic lib to search libs, resolve 9.3 i386 build issue - Bump PORTREVISION due to libatomic shlib dependency PR: 202812 Submitted by: mickael.maillot@gmail.com (maintainer) Approved by: ports-secteam (feld) Changes: _U branches/2015Q3/ branches/2015Q3/multimedia/kodi/Makefile branches/2015Q3/multimedia/kodi/distinfo branches/2015Q3/multimedia/kodi/files/patch-configure.ac branches/2015Q3/multimedia/kodi/files/patch-configure.in branches/2015Q3/multimedia/kodi/files/patch-ffmpegx86 branches/2015Q3/multimedia/kodi/files/patch-freebsd branches/2015Q3/multimedia/kodi/files/patch-project__cmake__scripts__common__prepare-env.cmake branches/2015Q3/multimedia/kodi/files/patch-sidplay branches/2015Q3/multimedia/kodi/files/patch-tools__depends__target__ffmpeg__autobuild.sh branches/2015Q3/multimedia/kodi/files/patch-xbmc__LangInfo.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__cores__dvdplayer__DVDDemuxSPU.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogGamepad.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogNumeric.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__guilib__GUIAction.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__guilib__GUISpinControl.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__guilib__TextureBundleXPR.h branches/2015Q3/multimedia/kodi/files/patch-xbmc__guilib__XBTF.h branches/2015Q3/multimedia/kodi/files/patch-xbmc__interfaces__legacy__Dialog.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__linux__XFileUtils.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__main__main.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__pvr__PVRActionListener.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__settings__AdvancedSettings.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__storage__linux__DeviceKitDisksProvider.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__storage__linux__UDisksProvider.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__threads__platform__pthreads__ThreadImpl.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__utils__CharsetConverter.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc__windowing__WinEventsX11.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_cores_DllLoader_dll__tracker.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_cores_DllLoader_dll__tracker__file.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_cores_DllLoader_exports_emu__kernel32.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_filesystem_iso9660.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_linux_XFileUtils.cpp branches/2015Q3/multimedia/kodi/files/patch-xbmc_threads_platform_pthreads_ThreadImpl.cpp branches/2015Q3/multimedia/kodi/pkg-plist
The update has now been MFH'd and all work on this PR is competed. Mickael, In the future, can you ensure to run 'portlint -ac' on your next submission as well as run Poudriere testing on all supported releases per https://www.FreeBSD.org/security/security.html#sup? Remember i386 and amd64 are the tier 1 supported platforms and we must ensure things work on both. Thanks!