Bug 203172 - [patch] [jail] race condition in /etc/rc.d/jail when jail_parallel_start is YES
Summary: [patch] [jail] race condition in /etc/rc.d/jail when jail_parallel_start is YES
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 10.2-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Hiroki Sato
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-09-17 13:11 UTC by dmitry2004
Modified: 2016-07-17 14:16 UTC (History)
3 users (show)

See Also:


Attachments
Patch for /etc/rc.d/jail (1.37 KB, text/plain)
2015-09-17 13:11 UTC, dmitry2004
no flags Details
Patch for /etc/rc.d/jail 2016-01-07 (1.52 KB, patch)
2016-01-07 15:42 UTC, dmitry2004
no flags Details | Diff
Patch for /etc/rc.d/jail 2016-07-11 (1.48 KB, patch)
2016-07-11 09:21 UTC, Dmitry Wagin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dmitry2004 2015-09-17 13:11:37 UTC
Created attachment 161148 [details]
Patch for /etc/rc.d/jail

Race condition in /etc/rc.d/jail when jail_parallel_start is YES.

Original script fork jail's, wait 1 sec and
if jail not have 1sec for start it is considered start fail.

Patch fixes the problem.
Comment 1 dmitry2004 2016-01-07 15:42:21 UTC
Created attachment 165213 [details]
Patch for /etc/rc.d/jail 2016-01-07
Comment 2 dmitry2004 2016-01-07 15:42:55 UTC
updated patch
Comment 3 Dmitry Wagin 2016-07-11 09:21:10 UTC
Created attachment 172369 [details]
Patch for /etc/rc.d/jail 2016-07-11

updated patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-14 19:52:19 UTC
A commit references this bug:

Author: jamie
Date: Thu Jul 14 19:51:55 UTC 2016
New revision: 302855
URL: https://svnweb.freebsd.org/changeset/base/302855

Log:
  Wait for jails to complete startup if jail_parallel_start is YES,
  instead of assuming they'll take less than one second.

  PR:		203172
  Submitted by:	dmitry2004@yandex.ru

Changes:
  head/etc/rc.d/jail
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-07-17 14:05:37 UTC
A commit references this bug:

Author: jamie
Date: Sun Jul 17 14:05:11 UTC 2016
New revision: 302953
URL: https://svnweb.freebsd.org/changeset/base/302953

Log:
  MFC r302855:

    Wait for jails to complete startup if jail_parallel_start is YES,
    instead of assuming they'll take less than one second.

  PR:		203172
  Submitted by:	dmitry2004@yandex.ru
  Approved by:	re (gjb)

Changes:
_U  stable/11/
  stable/11/etc/rc.d/jail
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-17 14:12:44 UTC
A commit references this bug:

Author: jamie
Date: Sun Jul 17 14:12:34 UTC 2016
New revision: 302956
URL: https://svnweb.freebsd.org/changeset/base/302956

Log:
  MFC r302855:

      Wait for jails to complete startup if jail_parallel_start is YES,
      instead of assuming they'll take less than one second.

  PR:		203172
  Submitted by:	dmitry2004@yandex.ru

Changes:
_U  stable/10/
  stable/10/etc/rc.d/jail