Created attachment 161165 [details] Patch against current ports as of 2015-09-18. Number of minor patches to 1.9, including: * Checking Host: HTTP request header to prevent DNS rebinding attack * Fix potential memory corruption in upnpsoap.c/GetListOfPortMappings() * Fix buffer overrun in ParseHttpHeaders() if Content-Length doesn't contain any digit * Fix don't die when IPv6 is enabled and interface has no IPv4 address More details: http://miniupnp.free.fr/files/changelog.php?file=miniupnpd-1.9.20150721.tar.gz
Created attachment 161176 [details] Update to 1.9.20150721 + port cleanup At the time I was testing the port I noted it could be improved a bit, here are the changes description: - Stop calling uuidgen on port Makefile, miniupnpd Makefile already does it - Do not modify CFLAGS since it's already attributed using ?= - Remove do-install: target from ports Makefile, let miniupnpd Makefile installs it - Patch miniupnpd Makefile to install conf with .sample suffix - Patch miniupnpd Makefile to install manpage in the proper place, respecting MANPREFIX Do you approve it?
Looks good to me. I approve.
A commit references this bug: Author: garga Date: Sat Sep 19 12:20:34 UTC 2015 New revision: 397321 URL: https://svnweb.freebsd.org/changeset/ports/397321 Log: - Update net/miniupnpd to 1.9.20150721 [1] - Stop calling uuidgen on port Makefile, miniupnpd Makefile already does it - Do not modify CFLAGS since it's already attributed using ?= - Remove do-install: target from ports Makefile, let miniupnpd Makefile installs it - Patch miniupnpd Makefile to install conf with .sample suffix - Patch miniupnpd Makefile to install manpage in the proper place, respecting MANPREFIX PR: 203191 [1] Submitted by: Tor Halvard Furulund <squat@squat.no> [1] Approved by: Tor Halvard Furulund <squat@squat.no> (maintainer) Sponsored by: Rubicon Communications (Netgate) Changes: head/net/miniupnpd/Makefile head/net/miniupnpd/distinfo head/net/miniupnpd/files/patch-Makefile